From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Ajit Agarwal via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rep.dot.nop@gmail.com, Ajit Agarwal <aagarwa1@linux.ibm.com>,
Jeff Law <jeffreyalaw@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Peter Bergner <bergner@linux.ibm.com>,
Richard Biener <richard.guenther@gmail.com>
Subject: Re: PATCH v5 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces.
Date: Thu, 1 Jun 2023 08:04:56 +0200 [thread overview]
Message-ID: <20230601080456.37d4a78b@nbbrfq.loc> (raw)
In-Reply-To: <94db15dc-2ce3-bfc1-6483-fce5687bd991@linux.ibm.com>
On Thu, 1 Jun 2023 10:53:02 +0530
Ajit Agarwal via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> Hello All:
>
> This new version of patch 4 use improve ree pass for rs6000 target using defined ABI interfaces.
> Bootstrapped and regtested on power64-linux-gnu.
>
> Review comments incorporated.
Not a review:
/scratch/src/gcc-14.mine$ ./contrib/check_GNU_style.py /tmp/rs6k-ree-v5.patch
=== ERROR type #1: there should be exactly one space between function name and parenthesis (2 error(s)) ===
gcc/ree.cc:1461:33: if (state.defs_list.length() != 0)
gcc/ree.cc:1487:42: if ((i+1) < reinsn_copy_list.length())
=== ERROR type #2: trailing operator (1 error(s)) ===
gcc/ree.cc:761:24: machine_mode tgt_mode =
$ grep -E "^[-+].*[^[:space:]\.][[:space:]][[:space:]]" /tmp/rs6k-ree-v5.patch
+ an return registers. */
+ if (GET_CODE (SET_SRC (set)) != ZERO_EXTEND)
+ if (GET_CODE (SET_SRC (set)) != ZERO_EXTEND)
+ if (code != ZERO_EXTEND)
And maybe you could add fewer empty lines in combine_reaching_defs()
thanks,
next prev parent reply other threads:[~2023-06-01 6:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 5:23 Ajit Agarwal
2023-06-01 6:04 ` Bernhard Reutner-Fischer [this message]
2023-06-26 12:36 ` [PING] " Ajit Agarwal
2023-06-26 12:42 ` Ajit Agarwal
2023-06-26 12:45 ` [PING] " Ajit Agarwal
2023-07-18 7:58 ` [PING^2] " Ajit Agarwal
2023-08-01 8:18 ` [PING^3] " Ajit Agarwal
2023-08-21 6:46 ` [PING^4] " Ajit Agarwal
2023-09-12 7:21 ` [PING^5] " Ajit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601080456.37d4a78b@nbbrfq.loc \
--to=rep.dot.nop@gmail.com \
--cc=aagarwa1@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).