From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id EA45A3858CDB for ; Thu, 1 Jun 2023 06:05:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA45A3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-96f50e26b8bso55043466b.2 for ; Wed, 31 May 2023 23:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685599501; x=1688191501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XnG6bEE7yuX1ReexA71brJx0I57gLU53vOif1FKDsG8=; b=a87UwfDouQUmqZvnXo2y2LQYBXEKoEVQhUoVMAUyudcaeDRx5yj8DPP78m7ppZaYSF 6sxqXEnNyfJzU08qmpLL68gUOhORsqy9EN+8Rwhvgp0lbaDMnoGR08UxGvLReJaEc594 H+NxpN82e1x3f5u4Zt8orLYT8Nsv+pyAQwO7W+n2K2vzAqTr++x+eiPNpe60O35RkEZl LTR5nmvGrzQiP2ANF/7Ku1TWNzqMg0RumFAsb/ecLOg33M+xGKkM0A7e3D7O65F4up2g ZiSYVMko0wth6fFWm4tGlmN72vfb6ub9lFRlDUuPvupcylGPD5sJV8anRL26WFPOnLcG PjNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685599501; x=1688191501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XnG6bEE7yuX1ReexA71brJx0I57gLU53vOif1FKDsG8=; b=d/xrGThX4N19TgRyLNPmIz/CpfwqLBdoUlQ0H/gX00n1U6yS6pYGfFJ3GrTpO0wPpA s3d6U4nT8SdzuZfwjNXudAh6MSWArBpMYy4q05rDDIaYxGWFc9O/mBDM7S6ifV2uXsfj y/Q5BHILzmznNS4/qCXoJcd8E8kz9DOzsWnR7EZlnajqZerQANAcmihUh8+SqMLGs+f3 Xy5drYHH+Mo2gFvijeVshdW3+2Sgzwg1ts5pe7PfQ/lJqP4QprBWEE/kOIGN/dIm+Ljr HcceHAMgssQxZb8rgXwupIs/w00EfHmZ0CC90s5exFs3IsIqg5Rgx/Wj+v/dG28cFOSD /v6Q== X-Gm-Message-State: AC+VfDw9pivYd2fgi19un4lhDykJA/NjNC7cCOjXxnh+dXA0Y9ySSQU9 NK1OK5Fhe8bN2R6ZlCPh1KM= X-Google-Smtp-Source: ACHHUZ4xhA46sueHukmBLRbeUU4o6ufp85ufz2oD8+9XA5HFMFLMjNQy4I6i0Cb5G5uKeFFZdyjqLQ== X-Received: by 2002:a17:907:3ea0:b0:95e:d74b:d171 with SMTP id hs32-20020a1709073ea000b0095ed74bd171mr7413004ejc.28.1685599500485; Wed, 31 May 2023 23:05:00 -0700 (PDT) Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id z17-20020a170906715100b0094e597f0e4dsm9934593ejj.121.2023.05.31.23.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 23:05:00 -0700 (PDT) Date: Thu, 1 Jun 2023 08:04:56 +0200 From: Bernhard Reutner-Fischer To: Ajit Agarwal via Gcc-patches Cc: rep.dot.nop@gmail.com, Ajit Agarwal , Jeff Law , Segher Boessenkool , Peter Bergner , Richard Biener Subject: Re: PATCH v5 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces. Message-ID: <20230601080456.37d4a78b@nbbrfq.loc> In-Reply-To: <94db15dc-2ce3-bfc1-6483-fce5687bd991@linux.ibm.com> References: <94db15dc-2ce3-bfc1-6483-fce5687bd991@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 1 Jun 2023 10:53:02 +0530 Ajit Agarwal via Gcc-patches wrote: > Hello All: > > This new version of patch 4 use improve ree pass for rs6000 target using defined ABI interfaces. > Bootstrapped and regtested on power64-linux-gnu. > > Review comments incorporated. Not a review: /scratch/src/gcc-14.mine$ ./contrib/check_GNU_style.py /tmp/rs6k-ree-v5.patch === ERROR type #1: there should be exactly one space between function name and parenthesis (2 error(s)) === gcc/ree.cc:1461:33: if (state.defs_list.length() != 0) gcc/ree.cc:1487:42: if ((i+1) < reinsn_copy_list.length()) === ERROR type #2: trailing operator (1 error(s)) === gcc/ree.cc:761:24: machine_mode tgt_mode = $ grep -E "^[-+].*[^[:space:]\.][[:space:]][[:space:]]" /tmp/rs6k-ree-v5.patch + an return registers. */ + if (GET_CODE (SET_SRC (set)) != ZERO_EXTEND) + if (GET_CODE (SET_SRC (set)) != ZERO_EXTEND) + if (code != ZERO_EXTEND) And maybe you could add fewer empty lines in combine_reaching_defs() thanks,