From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 8A13F385840D; Thu, 1 Jun 2023 16:34:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A13F385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-514ab6cb529so4981965a12.1; Thu, 01 Jun 2023 09:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685637296; x=1688229296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zgYQ5ju2HVsRZqbpVoMTYwEScOhdGk4C7aC0y5VfQ2w=; b=qezB86roOPf/7Gzh0eKKiSTjgnz0NXyv8mP/NSju/X1ERQVE1jXc+jM/9lyGlf0nS1 s2J5Zp3SziJ6MSKWFqcHaLWyw+Q+7ovCGTyynxqtwxsT928eQ4+Yg4FU86stdySJCQyy 7iVPB7yZkK31hmAO0DKYeVLKw0EKrZcJM/ISzIf0LgdI0SrolPChZUQWWdz6uZeujSiR MBAm3U6/uNX1efAPa6nBAZcxMHy40KhKu4iLWwF/mUNwzFuLUUH/MehlArR3aFmJUDJT a+FebYAqDgOMozQ/6r71lSpSJUjuk9BanPxt4ygZcjkFEXX/gUPk3VrtRGbeNa8GD0sV XkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685637296; x=1688229296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zgYQ5ju2HVsRZqbpVoMTYwEScOhdGk4C7aC0y5VfQ2w=; b=Dve6rVdwgzwDUoWQAEF0kowLlGr0o16DnhlZcq8mSRN+WL1C5e1Lrv/R/bjgyxDT/f mQvNeyGcuk+O6wIPXxIiDIQKq2zIYrpp97EWjcymx4eQ+Xo+0eJs94f5I9p+EQeksK71 9zl2BVGJjY55lh+aCi6wnJeE4jKCvkOKVedaAKi6ZXB74L9/6SFWZxdpatxYVMAJuHo3 pQ5q2z0tK6BczsLOyhzKbR6N+RMo/FBRXy7kseUfMrgo94tPZuQfRNLne9BvDu6XVDp0 P7jMfLa2Ie1qc3UJuwHf19lhkR9NCqV1xPBW/RuKVp/T3b14xmwpWLj0H4+kFNzdAFL1 /DRA== X-Gm-Message-State: AC+VfDzu5BHJuVeWBx9H4cz3HBZCHR80Rov6SbAXQJzrakmXhbsMe5Rm K9+zgO7Xyg8tlwfQYXcd5Fc= X-Google-Smtp-Source: ACHHUZ5kQEM24FohQzCzJB+f0Y7SSkGYh2fB2f9CEj75g8LJOCvr8n+eHoxavb/LrRk/z88KcNRQsw== X-Received: by 2002:aa7:cf07:0:b0:50b:c56c:43d0 with SMTP id a7-20020aa7cf07000000b0050bc56c43d0mr332436edy.1.1685637295746; Thu, 01 Jun 2023 09:34:55 -0700 (PDT) Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id d25-20020a50fb19000000b0050cc4461fc5sm7281249edq.92.2023.06.01.09.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 09:34:55 -0700 (PDT) Date: Thu, 1 Jun 2023 18:33:46 +0200 From: Bernhard Reutner-Fischer To: Patrick Palka Cc: rep.dot.nop@gmail.com, gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer Subject: Re: [PATCH 04/14] c++: use _P() defines from tree.h Message-ID: <20230601183346.71664610@nbbrfq.loc> In-Reply-To: References: <20230513232321.279733-1-rep.dot.nop@gmail.com> <20230513232321.279733-5-rep.dot.nop@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 1 Jun 2023 11:24:06 -0400 Patrick Palka wrote: > On Sat, May 13, 2023 at 7:26=E2=80=AFPM Bernhard Reutner-Fischer via > Gcc-patches wrote: > > diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc > > index 131b212ff73..19dfb3ed782 100644 > > --- a/gcc/cp/tree.cc > > +++ b/gcc/cp/tree.cc > > @@ -1173,7 +1173,7 @@ build_cplus_array_type (tree elt_type, tree index= _type, int dependent) > > } > > > > /* Avoid spurious warnings with VLAs (c++/54583). */ > > - if (TYPE_SIZE (t) && EXPR_P (TYPE_SIZE (t))) > > + if (CAN_HAVE_LOCATION_P (TYPE_SIZE (t))) =20 >=20 > Hmm, this change seems undesirable... mhm, yes that is misleading. I'll prepare a patch to revert this. Let me have a look if there were other such CAN_HAVE_LOCATION_P changes that we'd want to revert. thanks,