From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id 8EA9E3858416 for ; Tue, 6 Jun 2023 08:23:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EA9E3858416 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686039833; x=1717575833; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l/3ySywJ0iYFP1f/MObdgWDkhLVGradsBQ40Gld3K1g=; b=fKbDPxzJul2ggxilPp4rsEfSTT2KFuBUfF4KWq6JJ/ia9R31z41dOI7g Hw1KQhkOzBqSOIld1HZpVSDERaxZQn+EDG0bJBW0cQWyxkeT5us004T8l Zvc7zUvItoX/lqnGdhKgF4UQt4mwL+hUqPhEM8c1TjNYH23uc5wDERj75 9Yypd/U8uHhUQQuoBD/JDi44mHPItJWk49KWBnsQFz7YIOL/ScDAPYR0V cac34YJLpWv7AQzSn4gNzNcj5mnwj3xqSqbshvI68uMQleiWECM8u31l+ 6fJEOecbGWgIQMcVZvPsY0+8x3F90DeyFPfl6UEJxrDWB4qFY9D0uD441 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="384910126" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="384910126" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 01:23:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="1039096761" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="1039096761" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by fmsmga005.fm.intel.com with ESMTP; 06 Jun 2023 01:23:50 -0700 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 2D599100562A; Tue, 6 Jun 2023 16:23:50 +0800 (CST) From: liuhongt To: gcc-patches@gcc.gnu.org Cc: crazylht@gmail.com, hjl.tools@gmail.com Subject: [PATCH v2] Explicitly view_convert_expr mask to signed type when folding pblendvb builtins. Date: Tue, 6 Jun 2023 16:21:50 +0800 Message-Id: <20230606082150.657119-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.39.1.388.g2fc9e9ca3c In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I think this is a better patch and will always be correct and still > get folded at the gimple level (correctly): > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > index d4ff56ee8dd..02bf5ba93a5 100644 > --- a/gcc/config/i386/i386.cc > +++ b/gcc/config/i386/i386.cc > @@ -18561,8 +18561,10 @@ ix86_gimple_fold_builtin (gimple_stmt_iterator *gsi) > tree itype = GET_MODE_INNER (TYPE_MODE (type)) == E_SFmode > ? intSI_type_node : intDI_type_node; > type = get_same_sized_vectype (itype, type); > - arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2); > } > + else > + type = signed_type_for (type); > + arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2); > tree zero_vec = build_zero_cst (type); > tree cmp_type = truth_type_for (type); > tree cmp = gimple_build (&stmts, LT_EXPR, cmp_type, arg2, zero_vec); > > Yes, thanks. Here's the updated patch: Since mask < 0 will be always false for vector char when -funsigned-char, but vpblendvb needs to check the most significant bit. The patch explicitly VCE to vector signed char. gcc/ChangeLog: PR target/110108 * config/i386/i386.cc (ix86_gimple_fold_builtin): Explicitly view_convert_expr mask to signed type when folding pblendvb builtins. gcc/testsuite/ChangeLog: * gcc.target/i386/pr110108-2.c: New test. --- gcc/config/i386/i386.cc | 4 +++- gcc/testsuite/gcc.target/i386/pr110108-2.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr110108-2.c diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index da20c2c49de..4e594a9c88e 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -18561,8 +18561,10 @@ ix86_gimple_fold_builtin (gimple_stmt_iterator *gsi) tree itype = GET_MODE_INNER (TYPE_MODE (type)) == E_SFmode ? intSI_type_node : intDI_type_node; type = get_same_sized_vectype (itype, type); - arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2); } + else + type = signed_type_for (type); + arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2); tree zero_vec = build_zero_cst (type); tree cmp_type = truth_type_for (type); tree cmp = gimple_build (&stmts, LT_EXPR, cmp_type, arg2, zero_vec); diff --git a/gcc/testsuite/gcc.target/i386/pr110108-2.c b/gcc/testsuite/gcc.target/i386/pr110108-2.c new file mode 100644 index 00000000000..2d1d2fd4991 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr110108-2.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-mavx2 -O2 -funsigned-char" } */ +/* { dg-final { scan-assembler-times "vpblendvb" 2 } } */ + +#include +__m128i do_stuff_128(__m128i X0, __m128i X1, __m128i X2) { + __m128i Result = _mm_blendv_epi8(X0, X1, X2); + return Result; +} + +__m256i do_stuff_256(__m256i X0, __m256i X1, __m256i X2) { + __m256i Result = _mm256_blendv_epi8(X0, X1, X2); + return Result; +} -- 2.39.1.388.g2fc9e9ca3c