From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=XPPO=B3=axis.com=Hans-Peter.Nilsson@sourceware.org>
Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18])
	by sourceware.org (Postfix) with ESMTPS id 629413858C54;
	Wed,  7 Jun 2023 14:42:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 629413858C54
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=axis.com; q=dns/txt; s=axis-central1; t=1686148967;
  x=1717684967;
  h=from:to:cc:in-reply-to:subject:mime-version:
   content-transfer-encoding:references:message-id:date;
  bh=RJ5ady+DU3+4DiW1lpECXjCBWBh6qMDkTlss58KSPeE=;
  b=EswR1LQuIwVmMyJLLbc+/4AJL+PDJZ7lENv5s7e6FgP1bhtvIpTvEurC
   E2vrYCrj/XyjINr+ZV4V8lNiVhQQR7qilosO0qD1bUDW4rkL9po6FA03s
   pWMiMMWZ1crluZ8ENOLWuE2E14/2155Nbr6CLj0TwD3RCdyn9S8v6n916
   BSW3vL5rHEcrxXo0KH3WE9HjcCh1C88UOmiKyKrXxwpSmLhrplVKN6e1G
   SYNjjibNIda7AaiG92xPUm366P8de6Rb7/XWjoOGviEoHf8K/2kh7Hzn6
   YtYharAE5iKrofq9qlFHNwN52XJd3+5ABbLHzEAvr1BYxRxWyPCvKM9Rw
   w==;
From: Hans-Peter Nilsson <hp@axis.com>
To: Jonathan Wakely <jwakely@redhat.com>
CC: <jwakely@redhat.com>, <libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
In-Reply-To: <CACb0b4=3nTrzZzq0_b9LQ0ckx5D_Mo-=kydusueSx49yXimLUw@mail.gmail.com>
	(message from Jonathan Wakely via Gcc-patches on Tue, 6 Jun 2023
	16:30:12 +0100)
Subject: Re: [PATCH] libstdc++: Use AS_IF in configure.ac
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
References: <20230601155856.305565-1-jwakely@redhat.com> 
 <CACb0b4=3nTrzZzq0_b9LQ0ckx5D_Mo-=kydusueSx49yXimLUw@mail.gmail.com>
Message-ID: <20230607144244.A0DC120420@pchp3.se.axis.com>
Date: Wed, 7 Jun 2023 16:42:44 +0200
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

> Date: Tue, 6 Jun 2023 16:30:12 +0100
> From: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>

> On Thu, 1 Jun 2023 at 16:59, Jonathan Wakely via Libstdc++ <
> libstdc++@gcc.gnu.org> wrote:
> 
> > Tested x86_64-linux. I'd appreciate a second set of eyeballs on this
> > before I push it.
> >
> 
> Pushed to trunk now.

...as r14-1581-g97a5e8a2a48d16, after which (apparently)
*all* linking libstdc++ tests for cris-elf (a "newlib
target") get (for example):

FAIL: 17_intro/freestanding.cc (test for excess errors)
Excess errors:
/x/cris-elf/pre/cris-elf/bin/ld: cannot find -liconv: No such file or directory

(deduced from libstdc++.log and the commits in the range
ce2188e4320c..585c660f041c where 4144 regressions in
libstdc++ were introduced for cris-elf)

>From the generated configure and a brief RTFM for AS_IF, it
looks almost like AS_IF was "miscompiled" and behaving
literally AS_IF (!) in that the condition TEST1 (here
[$GLIBCXX_IS_NATIVE] seems to be emitted *after* the
RUN-IF-TRUE1 clause (the next 31 lines).  Not obvious what
went wrong.  I even tried regenerating configure.  HTH.

brgds, H-P