From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 1235F3858C20; Fri, 9 Jun 2023 05:28:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1235F3858C20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3595HCww005599; Fri, 9 Jun 2023 05:28:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : mime-version; s=pp1; bh=RtEBnUyJVVeHBrC0E2PFuQ3+AKY8+Myxde8OaqF9QVg=; b=VUSpIxtSBezxZODtyujuV2JPOjcC8CABE/pREe/OlhTJpaJ4T6zjhn9NfZYgFN/MN1Zc mZsn2a7Fav5HQfglzUjUCX9Wjxww1GlesWQ817W0+JXLo07ENwOXTAqRH2NnyHamxi0J jpXB/Pa9gmiiQR0Qv7S9wc63rQgU9ip+uCnQcK/2aT0m6szFp7RsUImGMA0msK/Js/E6 GQbwq4i6ltIeiDWOb2BMTt/7wYFSc94pgDkKD8WgKjYDZMwcvip0vy9aK6kQtq4MazDp BU6AzxoKfy6OOsRh80SNv713IZK1QeUlwtv9Qnk+StlTlM+Zgai8m6PXcySA17RB2+kM ow== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r3wt0r5yw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Jun 2023 05:28:56 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3595K3vb012037; Fri, 9 Jun 2023 05:28:55 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r3wt0r5y5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Jun 2023 05:28:55 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3590JQVg025304; Fri, 9 Jun 2023 05:28:53 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3r2a78ssgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Jun 2023 05:28:53 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3595SnB213435628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Jun 2023 05:28:49 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B9D5E20043; Fri, 9 Jun 2023 05:28:49 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B2E620040; Fri, 9 Jun 2023 05:28:48 +0000 (GMT) Received: from ltcden2-lp1.aus.stglabs.ibm.com (unknown [9.3.90.43]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 9 Jun 2023 05:28:48 +0000 (GMT) From: Jiufu Guo To: gcc-patches@gcc.gnu.org Cc: rguenther@suse.de, jeffreyalaw@gmail.com, richard.sandiford@arm.com, segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, guojiufu@linux.ibm.com Subject: [PATCH] Make sure SCALAR_INT_MODE_P before invoke try_const_anchors Date: Fri, 9 Jun 2023 13:28:47 +0800 Message-Id: <20230609052847.2128612-1-guojiufu@linux.ibm.com> X-Mailer: git-send-email 2.39.3 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tMw1Y3EUC59W-z8n8JZ2emMhC0NqA4qx X-Proofpoint-GUID: _U86sIVRddW7GaEV0rEoHeLBfOUVuTyl Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-09_02,2023-06-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306090043 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, As checking the code, there is a "gcc_assert (SCALAR_INT_MODE_P (mode))" in "try_const_anchors". This assert seems correct because the function try_const_anchors cares about integer values currently, and modes other than SCALAR_INT_MODE_P are not needed to support. This patch makes sure SCALAR_INT_MODE_P when calling try_const_anchors. This patch is raised when drafting below one. https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603530.html. With that patch, "{[%1:DI]=0;} stack_tie" with BLKmode runs into try_const_anchors, and hits the assert/ice. Boostrap and regtest pass on ppc64{,le} and x86_64. Is this ok for trunk? BR, Jeff (Jiufu Guo) gcc/ChangeLog: * cse.cc (cse_insn): Add SCALAR_INT_MODE_P condition. --- gcc/cse.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/cse.cc b/gcc/cse.cc index 2bb63ac4105..f213fa0faf7 100644 *** a/gcc/cse.cc --- b/gcc/cse.cc *************** *** 5003,5009 **** if (targetm.const_anchor && !src_related && src_const ! && GET_CODE (src_const) == CONST_INT) { src_related = try_const_anchors (src_const, mode); src_related_is_const_anchor = src_related != NULL_RTX; - - --- 5003,5010 ---- if (targetm.const_anchor && !src_related && src_const ! && GET_CODE (src_const) == CONST_INT ! && SCALAR_INT_MODE_P (mode)) { src_related = try_const_anchors (src_const, mode); src_related_is_const_anchor = src_related != NULL_RTX; 2.39.3