From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 0673A3856956 for ; Fri, 9 Jun 2023 07:40:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0673A3856956 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4011D1FDF1; Fri, 9 Jun 2023 07:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686296405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=kUNLHNLTiWlanY5omxBFI5CYuv4morCCA0rUOb5endo=; b=g35kYVXNXq4oxpYWG3zj5ZZv0AJKhyIkY7XQFcbKiMz4NLRbw/BXdihWrIeJw6tB3umXqH Uo/C4zxc22f8YOwaREWs1/Au5RbYwbTTgNgKNrnU+/GG8+5o5S7zBlHGgBOL+hNGcqdsjm 2gLEGdzMt6VZsgNi+kLqG/L3d3/AGko= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686296405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=kUNLHNLTiWlanY5omxBFI5CYuv4morCCA0rUOb5endo=; b=ogcy8BeZx1hJWdaiHnk9w7ci9EKjg1YewpyIPobrugvDPnBLVfXrfrfTG/v7IUvlnlVAyW oeXbD3nY26sg0+BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2815F13A47; Fri, 9 Jun 2023 07:40:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +eOlCFXXgmQ/TAAAMHmgww (envelope-from ); Fri, 09 Jun 2023 07:40:05 +0000 Date: Fri, 9 Jun 2023 09:40:04 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: pinskia@gmail.com Subject: [PATCH] Prevent TYPE_PRECISION on VECTOR_TYPEs MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20230609074005.2815F13A47@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The following makes sure that using TYPE_PRECISION on VECTOR_TYPE ICEs when tree checking is enabled. This should avoid wrong-code in cases like PR110182 and instead ICE. Bootstrap and regtest pending on x86_64-unknown-linux-gnu, I guess there will be some fallout of such change ... * tree.h (TYPE_PRECISION): Check for non-VECTOR_TYPE. --- gcc/tree.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/tree.h b/gcc/tree.h index 1854fe4a7d4..9c525d14474 100644 --- a/gcc/tree.h +++ b/gcc/tree.h @@ -2191,7 +2191,8 @@ class auto_suppress_location_wrappers #define TYPE_SIZE_UNIT(NODE) (TYPE_CHECK (NODE)->type_common.size_unit) #define TYPE_POINTER_TO(NODE) (TYPE_CHECK (NODE)->type_common.pointer_to) #define TYPE_REFERENCE_TO(NODE) (TYPE_CHECK (NODE)->type_common.reference_to) -#define TYPE_PRECISION(NODE) (TYPE_CHECK (NODE)->type_common.precision) +#define TYPE_PRECISION(NODE) \ + (TREE_NOT_CHECK (TYPE_CHECK (NODE), VECTOR_TYPE)->type_common.precision) #define TYPE_NAME(NODE) (TYPE_CHECK (NODE)->type_common.name) #define TYPE_NEXT_VARIANT(NODE) (TYPE_CHECK (NODE)->type_common.next_variant) #define TYPE_MAIN_VARIANT(NODE) (TYPE_CHECK (NODE)->type_common.main_variant) -- 2.35.3