From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by sourceware.org (Postfix) with ESMTPS id E890D385800A for ; Tue, 13 Jun 2023 06:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E890D385800A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FEF861EF0; Tue, 13 Jun 2023 06:29:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D326C433D2; Tue, 13 Jun 2023 06:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686637747; bh=85L3P8MiCQ+TPEi4vCZgBSemZXARSOsnyhZhJqBMxHY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uPtoU8FivfU7EUMTAoN3aVYUxexGvI+adaoMJ0Xy03I4tRZwoykAOH5ZRBsMeWgUO hKuvylypRSb3YyJGhHh0kDcIfdXsI51CgykgGKoRcCi1IZaXz+Cfx8ceARAY7JnBwB rwXK4U//jRceFIStS/dC5v6lC4kDUpSBSgM7meM5LyMioXl1fdvMfrmpT5SMr8y4NR nrQIogvd5COGLES+mr25dsKT/gNE1ArXxUMiyTv2bg9/qPyZMeREUYzfZIS/LGTIfy oDiQQRTRKgU+UdaPaFNYC/KhH1DOIG869jiXwq/psNU+HX2Sd1XiO9jlCib5HOjmqC WBT1haYZdmr4w== Received: by pali.im (Postfix) id 47AB37FD; Tue, 13 Jun 2023 08:29:04 +0200 (CEST) Date: Tue, 13 Jun 2023 08:29:04 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jonathan Yong <10walls@gmail.com> Cc: LIU Hao , gcc-patches@gcc.gnu.org, Jacek Caban , NightStrike Subject: Re: [PATCH] Add MinGW option -mcrtdll= for choosing C RunTime DLL library Message-ID: <20230613062904.nh3tpyw4l2x7tkjd@pali> References: <20230527101412.19562-1-pali@kernel.org> <2617dc57-ec7a-197b-411f-db4b48d04bc2@gmail.com> <47c4f558-8972-1272-3ccb-1e868ccef14a@126.com> <6d1db80b-703f-52e1-5860-8dd32572914f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6d1db80b-703f-52e1-5860-8dd32572914f@gmail.com> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Monday 12 June 2023 23:13:00 Jonathan Yong wrote: > On 6/12/23 01:26, LIU Hao wrote: > > 在 2023/6/12 07:08, Jonathan Yong 写道: > > > +preprocessor is done. MinGW import library @code{msvcrt} is just a > > > +symlink (or file copy) to the other MinGW CRT import library > > > > I suggest a change to this line: > > > >    symlink to (or a copy of) another MinGW CRT import library > > > > > > Also, as discussed earlier, linking against a CRT version different from > > the value of `__MSVCRT_VERSION__` in _mingw.h is not officially > > supported and should be warned. So maybe we can append a paragraph to > > the documentation: > > > >    Generally speaking, changing the CRT DLL requires recompiling > >    the entire MinGW CRT. This option is for experimental and testing > >    purposes only. > > > > > > > > Pali, mind updating the patch? > Of course, just I'm not sure where to put the new paragraph. At the beginning? Or after the text? What do you think?