From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 65DB03858C74 for ; Tue, 13 Jun 2023 07:37:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65DB03858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-30e3caa6aa7so5126256f8f.1 for ; Tue, 13 Jun 2023 00:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1686641864; x=1689233864; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Syi3WRT0yDo7OpfWuagG3lPbEi0Kn2NNr75a1vEVFpY=; b=VK2XMMNSnDHHozIpDqgDHLbKNyvijMFzUcFK+mtJfKfkrogXXxOvs27R90RsRPmvWd 4B3YWTk67iudJMrGpZ9abrV4TOIG6GNfLwOOogXRQpAVhfh7vARoBVmnFvax2aoWESTg HWDGVxAcNPfCAVWgoEd62ezhzw3jpyFimG1Tj5qAHBfBJgQAr1hDAScfbH5yWFMTry9D Xm0ByL4niFZgkIpt8q1VGXiRO9KROxG8l/rzZaqcJIgG9uLwIMTYJN5Xy9gLOJLXZJrE QPevTNGiRvCWDhX0mMWZGhIrN3NdKvjg75ssZ5gB+1TOapZso5OTpGrwDoFB1do/zDam xNUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686641864; x=1689233864; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Syi3WRT0yDo7OpfWuagG3lPbEi0Kn2NNr75a1vEVFpY=; b=bLMZ7mjXJ5DH4VnAVl6fdvf+nSjyTz3RibbnhRcxK09HZXiyFcFIPxP0Guhwuh5LPk LU2r0fgrD+SHsyTBxF4F1nJ6Hp/fKPx0kIo9RM3VkAudI+lNCpwzTS53X9LCQgBR1e+L ea0cVfh9pq42IfWWHfDckC2F6V6/C3JcCeA4hWtGZf3TCqtxnBZU64Sq/NEw4BWO4n0D Ct1JgDE7cWy8AfcXP96zvE2EGO43TR8zVC5OrW6RD5f0Nm88Q57dex/MHrMMAkbURe6A NiwKujtLixiXvs4AGMQ0QqKJ7bdOdINlu/jcPGNgGtqAV6thGuHVdF3SRfuIF4GLXSwp A1gg== X-Gm-Message-State: AC+VfDzajYCE1UNZfma6YbxCSyk9AjzmHlGMY5s9uIKuZjzPOfV7p+jK cozn519T7YtMLM0vVEr4y1bqQT9NtyXzj3TqRz2khg== X-Google-Smtp-Source: ACHHUZ4Aqf2hkvoLyvdtk2PvDJ4cSdJHQG1J35PsHJxU68NQdXo/Ox9KijgUgk/cY4Btvu9ncHTWEA== X-Received: by 2002:adf:f68c:0:b0:2f6:bf04:c8cc with SMTP id v12-20020adff68c000000b002f6bf04c8ccmr6524141wrp.55.1686641864184; Tue, 13 Jun 2023 00:37:44 -0700 (PDT) Received: from localhost.localdomain ([2001:861:3382:1a90:bfa8:5d29:40e5:cc66]) by smtp.gmail.com with ESMTPSA id k6-20020a5d6286000000b0030903371ef9sm14372351wru.22.2023.06.13.00.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 00:37:43 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Tune style in detection of writable function actuals Date: Tue, 13 Jun 2023 09:37:42 +0200 Message-Id: <20230613073742.238961-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Piotr Trojanek Cleanup; semantics is unaffected. gcc/ada/ * sem_util.adb (Check_Function_Writable_Actuals): Tune style; use subtype name to detect membership test nodes. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_util.adb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb index a75ebf5d7b1..237bbd3987c 100644 --- a/gcc/ada/sem_util.adb +++ b/gcc/ada/sem_util.adb @@ -2899,6 +2899,10 @@ package body Sem_Util is function Get_Record_Part (N : Node_Id) return Node_Id; -- Return the record part of this record type definition + --------------------- + -- Get_Record_Part -- + --------------------- + function Get_Record_Part (N : Node_Id) return Node_Id is Type_Def : constant Node_Id := Type_Definition (N); begin @@ -3293,9 +3297,7 @@ package body Sem_Util is & "in unspecified order", Node (Elmt_2)); - when N_In - | N_Not_In - => + when N_Membership_Test => Error_Msg_N ("value may be affected by call in other " & "alternative because they are evaluated " @@ -3307,7 +3309,7 @@ package body Sem_Util is ("value of actual may be affected by call in " & "other actual because they are evaluated " & "in unspecified order", - Node (Elmt_2)); + Node (Elmt_2)); end case; end if; -- 2.40.0