From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 95C553858438 for ; Thu, 15 Jun 2023 08:04:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95C553858438 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b344476595so23350091fa.2 for ; Thu, 15 Jun 2023 01:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1686816240; x=1689408240; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4hqDFtP+NPTN+3kbMpXBixKYg637uUcCG11h54lzy1g=; b=Z8co2yRjcfqqoFcp2h1P0dJPnnDceSM9V9j3IXUZ/vbVmVS/HDWQZijyFQ+lEQfcNA i9B7gBk5p/hPwINLzMXS/3XF8tQTFVcWs+j8lDZCZIKr7YPw62GdotMQkfLs9miWkXed q6LEJXYn4Bb55DumzRF4I9uH7vdtGTio8Mitmhc3YLsEe0mTgkSWWG1uLCmgwHPdNP3H qLn8EMY/pl+n7k9WIKohe4Q5g6TDvDq32T0jgufGyibg3UsEv/20jikD6CPDwXLWLhIb CAXAwEK2tXJiPgBffQhn8OR8NlHqYg4hW29wXQQwHw0ruUqqkNQFbb940sRMv1L2LoV7 dLhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686816240; x=1689408240; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4hqDFtP+NPTN+3kbMpXBixKYg637uUcCG11h54lzy1g=; b=kICHSYamsWcUc3VPwJInha+eAocq6QVb+76Lo6IBQKdSJq8hIMOMoJITbEE5LfR1Hv uXG5fsnQOIu5PRx/Wm+sXsbpZp4hoAJi9CB1gSZMybUBxJ9+0rkGzicjewQn6y4LCEaW 1hNg5N5fC7mIBjTifkYahNZYU/aMNnj7oPOp/wwqczO/1ewi3FptPlnUtHaADmFAVIdC srOLrUPvxGICPa/eBPDuN8Lhnlirr4i6UBhOl0dLmiSLCqYw8+E++k9SZWHNbcEmY8Ko i73LzzxU+A9+YmKb6tsuMgktKTdxnree0KPFW7XMEjCF6ZQ5BddePai17IyrwaqBSmBT Gv+A== X-Gm-Message-State: AC+VfDxI01YeC+d3Hy78DVDJZ5+jfokB/fJDrcvEIJ7Kt4fR6XmjD38c 7bVHqoGmGp4WtByXVkLp+o4MI/tRNJKviQWYV0j+mw== X-Google-Smtp-Source: ACHHUZ6FVphLEZJ/ZYJWvT82beiBYbp6+pHvqiTjF/JYyO3509wsrTQUs3LggHx8TNq1HjEemji6sA== X-Received: by 2002:a2e:8ec8:0:b0:2b3:4ace:fcdd with SMTP id e8-20020a2e8ec8000000b002b34acefcddmr2645706ljl.10.1686816240156; Thu, 15 Jun 2023 01:04:00 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id u26-20020a05600c211a00b003f42314832fsm19626425wml.18.2023.06.15.01.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 01:03:59 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Eric Botcazou Subject: [COMMITTED] ada: Fix inverted implementation of RM 8.4(10) clause for operators Date: Thu, 15 Jun 2023 10:03:58 +0200 Message-Id: <20230615080358.939037-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Eric Botcazou The comment is correct but the code implements the opposite outcome. gcc/ada/ * sem_type.adb (Disambiguate): Fix pasto in the implementation of the RM 8.4(10) clause for operators. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_type.adb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ada/sem_type.adb b/gcc/ada/sem_type.adb index d4006e4270b..8519b97fa41 100644 --- a/gcc/ada/sem_type.adb +++ b/gcc/ada/sem_type.adb @@ -2229,7 +2229,7 @@ package body Sem_Type is Is_Immediately_Visible (Base_Type (Etype (Right_Opnd (N)))) and then Is_Potentially_Use_Visible (User_Subp) then - if It2.Nam = Predef_Subp then + if It1.Nam = Predef_Subp then return It1; else return It2; -- 2.40.0