From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Eric Botcazou <ebotcazou@adacore.com>
Subject: [COMMITTED] ada: Remove dead code in Expand_Iterator_Loop_Over_Container
Date: Thu, 15 Jun 2023 10:04:19 +0200 [thread overview]
Message-ID: <20230615080419.939862-1-poulhies@adacore.com> (raw)
From: Eric Botcazou <ebotcazou@adacore.com>
The Condition_Actions field can only be populated for while loops.
gcc/ada/
* exp_ch5.adb (Expand_Iterator_Loop_Over_Container): Do not insert
an always empty list. Remove unused parameter Isc.
(Expand_Iterator_Loop): Adjust call to above procedure.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/exp_ch5.adb | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/gcc/ada/exp_ch5.adb b/gcc/ada/exp_ch5.adb
index d8214bd6ce2..a4c7db9f365 100644
--- a/gcc/ada/exp_ch5.adb
+++ b/gcc/ada/exp_ch5.adb
@@ -181,14 +181,13 @@ package body Exp_Ch5 is
procedure Expand_Iterator_Loop_Over_Container
(N : Node_Id;
- Isc : Node_Id;
I_Spec : Node_Id;
Container : Node_Id;
Container_Typ : Entity_Id);
-- Expand loop over containers that uses the form "for X of C" with an
- -- optional subtype mark, or "for Y in C". Isc is the iteration scheme.
- -- I_Spec is the iterator specification and Container is either the
- -- Container (for OF) or the iterator (for IN).
+ -- optional subtype mark, or "for Y in C". I_Spec is the iterator
+ -- specification and Container is either the Container (for OF) or the
+ -- iterator (for IN).
procedure Expand_Predicated_Loop (N : Node_Id);
-- Expand for loop over predicated subtype
@@ -4836,7 +4835,7 @@ package body Exp_Ch5 is
else
Expand_Iterator_Loop_Over_Container
- (N, Isc, I_Spec, Container, Container_Typ);
+ (N, I_Spec, Container, Container_Typ);
end if;
end Expand_Iterator_Loop;
@@ -5133,7 +5132,6 @@ package body Exp_Ch5 is
procedure Expand_Iterator_Loop_Over_Container
(N : Node_Id;
- Isc : Node_Id;
I_Spec : Node_Id;
Container : Node_Id;
Container_Typ : Entity_Id)
@@ -5606,13 +5604,6 @@ package body Exp_Ch5 is
Mutate_Ekind (Cursor, Id_Kind);
end;
- -- If the range of iteration is given by a function call that returns
- -- a container, the finalization actions have been saved in the
- -- Condition_Actions of the iterator. Insert them now at the head of
- -- the loop.
-
- Insert_List_Before (N, Condition_Actions (Isc));
-
Rewrite (N, New_Loop);
Analyze (N);
end Expand_Iterator_Loop_Over_Container;
--
2.40.0
reply other threads:[~2023-06-15 8:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615080419.939862-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).