From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [IPv6:2a03:4000:10:469::]) by sourceware.org (Postfix) with ESMTPS id 429E33858D20 for ; Mon, 26 Jun 2023 05:58:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 429E33858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id 3CE0E4208A; Mon, 26 Jun 2023 07:58:28 +0200 (CEST) Date: Mon, 26 Jun 2023 07:58:28 +0200 From: Jan-Benedict Glaw To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist Message-ID: <20230626055827.t57twu4yykagzdpt@lug-owl.de> References: <20230505151719.1031737-1-apinski@marvell.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hftqtqkm4emcorix" Content-Disposition: inline In-Reply-To: <20230505151719.1031737-1-apinski@marvell.com> X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --hftqtqkm4emcorix Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrew, On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches wrote: > While looking into a different issue, I noticed that it > would take until the second forwprop pass to do some > forward proping and it was because the ssa name was > used more than once but the second statement was > "dead" and we don't remove that until much later. [...] > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. Since this patch, I see a bit of fallout building the Linux kernel using the adder875_defconfig: # CC arch/powerpc/kernel/ptrace/ptrace-view.o powerpc-linux-gcc -Wp,-MMD,arch/powerpc/kernel/ptrace/.ptrace-view.o.d -n= ostdinc -I./arch/powerpc/include -I./arch/powerpc/include/generated -I./in= clude -I./arch/powerpc/include/uapi -I./arch/powerpc/include/generated/uapi= -I./include/uapi -I./include/generated/uapi -include ./include/linux/compi= ler-version.h -include ./include/linux/kconfig.h -include ./include/linux/c= ompiler_types.h -D__KERNEL__ -I ./arch/powerpc -fmacro-prefix-map=3D./=3D -= Wall -Wundef -Werror=3Dstrict-prototypes -Wno-trigraphs -fno-strict-aliasin= g -fno-common -fshort-wchar -fno-PIE -Werror=3Dimplicit-function-declaratio= n -Werror=3Dimplicit-int -Werror=3Dreturn-type -Wno-format-security -funsig= ned-char -std=3Dgnu11 -mbig-endian -m32 -msoft-float -pipe -ffixed-r2 -mmul= tiple -mno-readonly-in-sdata -mcpu=3D860 -mno-prefixed -mno-pcrel -mno-alti= vec -mno-vsx -mno-mma -fno-asynchronous-unwind-tables -mno-string -mbig-end= ian -mstack-protector-guard=3Dtls -mstack-protector-guard-reg=3Dr2 -fno-del= ete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-form= at-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -= Wframe-larger-than=3D1024 -fstack-protector-strong -Wno-main -Wno-unused-bu= t-set-variable -Wno-unused-const-variable -Wno-dangling-pointer -fomit-fram= e-pointer -ftrivial-auto-var-init=3Dzero -fno-stack-clash-protection -Wdecl= aration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-s= tringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitia= lized -Wno-array-bounds -Wno-alloc-size-larger-than -Wimplicit-fallthrough= =3D5 -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=3Ddate-= time -Werror=3Dincompatible-pointer-types -Werror=3Ddesignated-init -Wno-pa= cked-not-aligned -g -mstack-protector-guard-offset=3D544 -Werror -DUTS_MACH= INE=3D'"ppc"' -DKBUILD_MODFILE=3D'"arch/powerpc/kernel/ptrace/ptrace-vie= w"' -DKBUILD_BASENAME=3D'"ptrace_view"' -DKBUILD_MODNAME=3D'"ptrace_view"' = -D__KBUILD_MODNAME=3Dkmod_ptrace_view -c -o arch/powerpc/kernel/ptrace/ptra= ce-view.o arch/powerpc/kernel/ptrace/ptrace-view.c =20 during GIMPLE pass: pre arch/powerpc/kernel/ptrace/ptrace-view.c: In function 'gpr32_set_common': arch/powerpc/kernel/ptrace/ptrace-view.c:649:5: internal compiler error: in= gimple_redirect_edge_and_branch, at tree-cfg.cc:6262 649 | int gpr32_set_common(struct task_struct *target, | ^~~~~~~~~~~~~~~~ 0x1a562a6 internal_error(char const*, ...) ???:0 0x826ea1 fancy_abort(char const*, int, char const*) ???:0 0x9b77c9 redirect_edge_and_branch(edge_def*, basic_block_def*) ???:0 0x9b7e43 split_edge(edge_def*) ???:0 0xee1cc7 split_critical_edges(bool) ???:0 Please submit a full bug report, with preprocessed source (by using -frepor= t-bug). Please include the complete backtrace with any bug report. See for instructions. make[4]: *** [scripts/Makefile.build:252: arch/powerpc/kernel/ptrace/ptrace= -view.o] Error 1 make[3]: *** [scripts/Makefile.build:494: arch/powerpc/kernel/ptrace] Error= 2 make[2]: *** [scripts/Makefile.build:494: arch/powerpc/kernel] Error 2 make[1]: *** [scripts/Makefile.build:494: arch/powerpc] Error 2 make: *** [Makefile:2026: .] Error 2 (Full log at http://toolchain.lug-owl.de/laminar/jobs/linux-powerpc-adder87= 5_defconfig/100) Thanks, Jan-Benedict --=20 --hftqtqkm4emcorix Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZJkpAAAKCRAdvV51g5nh u0IFAJ96/kDjpR5kjhcevjHQMHoKJQjIBACfR0MwW+SfiTMBMu2FDP6O82FxVHQ= =FFN1 -----END PGP SIGNATURE----- --hftqtqkm4emcorix--