From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2089.outbound.protection.outlook.com [40.107.20.89]) by sourceware.org (Postfix) with ESMTPS id A4D223858D35 for ; Wed, 28 Jun 2023 15:15:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4D223858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TYyYtcSuCm5FF7E7zdVxcrqsPCDhEiTGLpEzrhJyl8U=; b=iPI8ZdrWjFJc7oaKnoTMcUiokyOYhVagB/3BAayxe+7I4M9Gg12cNV40+vPYL+d09v7P+01YnT/Pwzi0j1NFYKmPSYscE2WsJOkwuHEWQYUtFUV9mx+rUyiLMR59NrCPvf6LNv8CoYWRDluaowKAvZGK6xiX3s1tXSly2pU0xUs= Received: from DUZPR01CA0239.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::28) by PAWPR08MB9892.eurprd08.prod.outlook.com (2603:10a6:102:342::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Wed, 28 Jun 2023 15:15:08 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b5:cafe::9c) by DUZPR01CA0239.outlook.office365.com (2603:10a6:10:4b5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.18 via Frontend Transport; Wed, 28 Jun 2023 15:15:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.20 via Frontend Transport; Wed, 28 Jun 2023 15:15:07 +0000 Received: ("Tessian outbound b11b8bb4dfe8:v142"); Wed, 28 Jun 2023 15:15:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 46ce616a1a9a5e58 X-CR-MTA-TID: 64aa7808 Received: from cde32c205781.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 595AFAAF-916B-4F7A-A2A8-EE8330C1CEED.1; Wed, 28 Jun 2023 15:15:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cde32c205781.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Jun 2023 15:15:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TrRwka2iUjS7jIVR2igLNEpRvHZhhD5O+pz0+hBP4dpR5/H2TvAYtyV79pGydmDPQ2ft7KOqTLbYTCoBKh8GL8KGHMy+1nmivy7Qhv5NN4Xl5DOnvu7b4UAGxDhH77YFdN7O6Vn9Sw0CmE3bQFqj1dbEUly9MsasBtHS8E8HUj3PmnI8GOJyY7mmo57THZqtZqtaMb3nZkHsbHKp6wN+SYnrdzrREihRYtHsFMLVNy5Qr30WVk935Usca8jiGq6orJ1Q7NBRV6r/hbjNHHyG+q/ezmM4D7TRCiQPv59e7iPaV+qRRT/r9u7dueSfRSH0k9G4IXyaeajsDaGbtI4t7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TYyYtcSuCm5FF7E7zdVxcrqsPCDhEiTGLpEzrhJyl8U=; b=XbJa8a0i37T7nHLPzBCH+obk5Rwr57OGsEIVK80HSWnosObCAbVhSVTlMGSliV3FzoKDbJz3tHUJSj/mzG6Ax8W1tpERLGCHWW3fpMTtHMUH86/rLG75VYIMtrWJ8XVMh9HGbhb8FtiY9ad2OVnmkL1iJnS9RMrBfGYS2CsvetL5fqndNMnxLFrXlVExag2iG1qaq8depPa868bA9jxUswom+oD9SEpnBpN60a51JKiJJtApbKc4pzHYw8fOp3lrljWQUCUP8U/QpiSI2pvJxHP0dNT7VW6zlJXIgDWRbOh+7g2FqZaILTlNTqukFAgx0m/xhEk6037WPTR9NJBLSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TYyYtcSuCm5FF7E7zdVxcrqsPCDhEiTGLpEzrhJyl8U=; b=iPI8ZdrWjFJc7oaKnoTMcUiokyOYhVagB/3BAayxe+7I4M9Gg12cNV40+vPYL+d09v7P+01YnT/Pwzi0j1NFYKmPSYscE2WsJOkwuHEWQYUtFUV9mx+rUyiLMR59NrCPvf6LNv8CoYWRDluaowKAvZGK6xiX3s1tXSly2pU0xUs= Received: from DB8PR09CA0015.eurprd09.prod.outlook.com (2603:10a6:10:a0::28) by PAVPR08MB9604.eurprd08.prod.outlook.com (2603:10a6:102:31b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Wed, 28 Jun 2023 15:15:00 +0000 Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::22) by DB8PR09CA0015.outlook.office365.com (2603:10a6:10:a0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19 via Frontend Transport; Wed, 28 Jun 2023 15:14:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6544.20 via Frontend Transport; Wed, 28 Jun 2023 15:14:59 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 15:14:59 +0000 Received: from e119885.cambridge.arm.com (10.2.78.55) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 28 Jun 2023 15:14:58 +0000 From: Oluwatamilore Adebayo To: CC: , , Subject: Re: [PATCH 2/2] AArch64: New RTL for ABDL Date: Wed, 28 Jun 2023 16:14:53 +0100 Message-ID: <20230628151453.48317-1-oluwatamilore.adebayo@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT009:EE_|PAVPR08MB9604:EE_|DBAEUR03FT031:EE_|PAWPR08MB9892:EE_ X-MS-Office365-Filtering-Correlation-Id: 77e5ca83-1f22-4ab6-26cc-08db77ea757e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lRHi+GiXhItiZwtLdJV3/lK7cCHxtAvJO3wkZWd6BwWKydvU2ogsZ8NbT2ZGU1SCP/LyQp6I3OW3Md0xZs2lNW5OrT8LpGYyTD26AaYoof29qDThAcOSr8/kbXzAouDBTJKXF6mM888Z2U1YiVWBvy/0+48hsf5GyVKro9VxsPsXUJOh1FvimJ4hppksR6/EvG/wtGm2mmmKNanuuokFtKk6UqX5DAAfnMp6avimJ9Q7UVQmpgYMA02u+/Qe617DD5dyNTkujZEtZPnBmwpkbxU7fJ92uFAmN5k3+UgMmhgph32HpNQNdE/9DeIj8BgEVuJ//ohoyflhg/dPwYUvocgMj071DBXcOVGt0UO+suaXkUFbRBw7M2+BjqpisnpD7BdjJYkHVhfw1TV2QlKdli1q2Y3JRSe6Bd0XITb95GZUsR7dpPYzna4HwxgHgxHCSd1+dDbbig/nv0tsAh8j0GbG/oC+ddNRw0SwBj/wrdAvHTQADu+vi/FK5/RxN75zV1aNwR6uCdZiMrwJri5G1XcdB/+eSvjXBg5AJ5h/n3rhh0cnO9LFGcwXPPIa7fbywYWEji28xEfdEE+fQek8uk0aut1Se7N0lU4Y6JodC+RUpBB5IMEG1axpuIE1Q5pCd4pTm4WQQEYIMfRRbTqgdx8iYLQJWUfRK+9CTi06moP2/ekG3S46dgTdfNbhDnJOGr5lKMMAfhs0eODJtySZBT27nTmpxM4yUx/N8Ldo4KDJMFjYFtg+oV58WIusiycyuFWQSMr4i13M/bSsedOg6Q== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199021)(36840700001)(46966006)(40470700004)(40460700003)(2906002)(186003)(7696005)(40480700001)(82310400005)(82740400003)(81166007)(2616005)(47076005)(6666004)(26005)(336012)(86362001)(426003)(356005)(1076003)(36860700001)(37006003)(41300700001)(54906003)(70206006)(478600001)(316002)(36756003)(4326008)(70586007)(6636002)(44832011)(5660300002)(6862004)(8676002)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9604 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 53ef6153-6ee1-4a09-06d8-08db77ea70b2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uOTSx3jFh/WN6e3bVLo2f2Z9enafeS9qVJB75bJMAnC8Z7hoD/d4/rUtPkP2vf9RcztFxh/rEtfyz41QN6P56QGbUVr9X7QlBXoxQFvX9ajhZhmxi2lJ+d1n/14cZ83em4MOpOFbNHNmqz6rl2tPQHeyBOBb30Jlj/a2nU4Uupgt6CtwJagKnAI1orj9jh2LRuyHMWWQfV+wYjBNWZjkaapJAf/a0l/1okwZbbpaSRQ0T0eceaupDky6kFw3KURdW+DQA10suQJjb9bZ9Jcw7GFkRQnDb4pcRWKw5Zh3jAB29079kzTYKGNOA72pTGp5qHOLGGnOsAoLBaYRP1HBFtcM5VEJsF4qs+qmLqwQOfHvfE1Dq6BK6zdUEYZ1TLwdHkwVxDyCRpcFOZy4rPzmDGJCZGjBNfd5dESi9wgnpXnbDR/CTxo4JSowzFq89BS0uuwrlb9Fm/KvglI5p2phadjT5tY84YfumcGRI/7BXJip1ypw37oyLKOUMalVkLSDNcJB78cFr5ADMvFh7je9CFMx9NUKmUNdmesFqIws2uhazTAYs38jYHzVq958uMoU+vpIhDIrwHAdaTVqSheuQIkux2/VktD5u/GtUZO5bRS7+fvFZAirGc7CvykqJUtElRcHTyvYpFCA/Whor0LHu0N80U761UKg/KOvtciwb5WNasDu/hJpfpjd7CIfB1JQfW1RMpHI+qDqZqOTVZu1WUH4jNiY/0e7X5HsEL3VqOLhiSJ3N/sx9AckkWaLU2bA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199021)(40470700004)(36840700001)(46966006)(82310400005)(36860700001)(47076005)(1076003)(478600001)(107886003)(54906003)(336012)(2906002)(26005)(7696005)(6666004)(2616005)(37006003)(186003)(426003)(44832011)(86362001)(41300700001)(70206006)(6862004)(36756003)(5660300002)(4326008)(6636002)(81166007)(316002)(82740400003)(70586007)(8936002)(40460700003)(40480700001)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 15:15:07.9999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77e5ca83-1f22-4ab6-26cc-08db77ea757e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9892 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > +(define_insn "aarch64_abdl_hi_internal" > > + [(set (match_operand: 0 "register_operand" "=w") > > + (minus: > > + (USMAX: > > + (: > > + (vec_select: > > + (match_operand:VQW 1 "register_operand" "w") > > + (match_operand:VQW 3 "vect_par_cnst_hi_half" ""))) > > + (: > > + (vec_select: > > + (match_operand:VQW 2 "register_operand" "w") > > + (match_dup 3)))) > > + (: > > + (: > > + (vec_select: (match_dup 1) (match_dup 3))) > > + (: > > + (vec_select: (match_dup 2) (match_dup 3))))))] > > + "TARGET_SIMD" > > + "abdl2\t%0., %1., %2." > > + [(set_attr "type" "neon_abd_long")] > > +) > > We don't need the (minus (max…) (min…)) thing when widening is > involved. It should be enough to do something like: > > (abs: > (minus: > (ANY_EXTEND: > (vec_select:…)) > (ANY_EXTEND: > (vec_select:…)))) Change made. > Sorry to be awkward, but could you put the widening cases in a separate > file? It's not very easy as things stand to work out which tests are > matched against widening ops and which aren't. Done. Patch in next email.