From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id E16653858C50 for ; Wed, 28 Jun 2023 21:22:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E16653858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1687987352; x=1719523352; h=from:to:subject:mime-version:content-transfer-encoding: message-id:date; bh=G3alC5UXGLZyMWq2DYLCRv/bI5zP4k3hDARRw3GYiFA=; b=ddtfkgRs/1SaTQ77ZAcdLk2brXg2U4fqKqwJbLmkfGNKPjAiEAk4I8nz +9rbsReu/HRsMbLFHknDabiClgotMhajF448n7HsQ/Uy9yp5E7IZfW5qt RSyZYMg2RjQqHVqrMdzLNiSpTTMjOkMZzINymMwba2E1lR38v58lUKxYu uzdssifqRsxgVaGxKUTRTA+AAEWx/HRJDpGCiAOBnUUU/v/btCaiOPVJ0 kO5X5/O6CuxxVeZnIdu0/IKtpGZSzx+EzzB5h0062NibiyK+oO8/0cNcJ e64KPWLgM+Dglo58bUXUEyYZCxinTcTEJOWYX1vsAefdPlS9/S9dF0CO1 A==; From: Hans-Peter Nilsson To: Subject: [committed] CRIS: Don't apply PATTERN to insn before validation (PR 110144) MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20230628212228.013E720418@pchp3.se.axis.com> Date: Wed, 28 Jun 2023 23:22:27 +0200 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Oops. The validation was there, but PATTERN was applied before that. Noticeable only with rtl-checking (for example as in the report: "--enable-checking=yes,rtl") as this statement was only a (one of many) straggling olde-C declare-and-initialize-at-beginning-of-block thing. PR target/110144 * config/cris/cris.cc (cris_postdbr_cmpelim): Don't apply PATTERN to insn before validating it. --- gcc/config/cris/cris.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/cris/cris.cc b/gcc/config/cris/cris.cc index 7fca2af085a7..f04f501326e7 100644 --- a/gcc/config/cris/cris.cc +++ b/gcc/config/cris/cris.cc @@ -375,7 +375,6 @@ cris_postdbr_cmpelim () for (insn = get_insns (); insn; insn = next) { rtx_insn *outer_insn = insn; - rtx pat = PATTERN (insn); next = NEXT_INSN (outer_insn); @@ -389,6 +388,7 @@ cris_postdbr_cmpelim () if (!NONDEBUG_INSN_P (insn)) continue; + rtx pat = PATTERN (insn); /* Consider filled delay slots; there might be a comparison there. It's only the second insn in a sequence that is interesting. */ -- 2.30.2