From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Jie Mei <jie.mei@oss.cipunited.com>
Cc: gcc-patches@gcc.gnu.org, YunQiang Su <yunqiang.su@cipunited.com>,
"Maciej W . Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH v4 4/9] MIPS: Add bitwise instructions for mips16e2
Date: Fri, 7 Jul 2023 01:06:57 +0200 [thread overview]
Message-ID: <20230706230657.wpokedcvtr25zwrz@lug-owl.de> (raw)
In-Reply-To: <030d4fdfe082a5a76f469e21117389acd4a9b0eb.1687162620.git.jie.mei@oss.cipunited.com>
[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]
Hi!
On Mon, 2023-06-19 16:29:53 +0800, Jie Mei <jie.mei@oss.cipunited.com> wrote:
> There are shortened bitwise instructions in the mips16e2 ASE,
> for instance, ANDI, ORI/XORI, EXT, INS etc. .
>
> This patch adds these instrutions with corresponding tests.
[...]
Starting with this patch, I see some new warning:
[all 2023-07-06 23:04:01] g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -I. -Ibuild -I../../gcc/gcc -I../../gcc/gcc/build -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include \
[all 2023-07-06 23:04:01] -o build/gencondmd.o build/gencondmd.cc
[all 2023-07-06 23:04:02] ../../gcc/gcc/config/mips/mips-msa.md:435:26: warning: 'and' of mutually exclusive equal-tests is always 0
[all 2023-07-06 23:04:02] 435 | DONE;
[all 2023-07-06 23:04:02] ../../gcc/gcc/config/mips/mips-msa.md:435:26: warning: 'and' of mutually exclusive equal-tests is always 0
[all 2023-07-06 23:04:03] ../../gcc/gcc/config/mips/mips.md:822:1: warning: 'and' of mutually exclusive equal-tests is always 0
[all 2023-07-06 23:04:03] 822 | ;; conditional-move-type condition is needed.
[all 2023-07-06 23:04:03] | ^
[all 2023-07-06 23:04:03] g++ -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstdc++ -static-libgcc -o build/gencondmd \
[all 2023-07-06 23:04:03] build/gencondmd.o build/errors.o ../build-x86_64-pc-linux-gnu/libiberty/libiberty.a
[all 2023-07-06 23:04:03] build/gencondmd > tmp-cond.md
(Full build log available as eg. http://toolchain.lug-owl.de/laminar/jobs/gcc-mips-linux/76)
Thanks, JBG
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-07-06 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 8:29 [PATCH v4 0/9] MIPS: Add MIPS16e2 ASE instrucions Jie Mei
2023-06-19 8:29 ` [PATCH v4 1/9] MIPS: Add basic support for mips16e2 Jie Mei
2023-06-19 8:29 ` [PATCH v4 2/9] MIPS: Add MOVx instructions " Jie Mei
2023-06-19 8:29 ` [PATCH v4 3/9] MIPS: Add instruction about global pointer register " Jie Mei
2023-06-19 8:29 ` [PATCH v4 4/9] MIPS: Add bitwise instructions " Jie Mei
2023-07-06 23:06 ` Jan-Benedict Glaw [this message]
2023-07-07 8:38 ` 梅杰
2023-07-07 10:53 ` Jan-Benedict Glaw
2023-06-19 8:29 ` [PATCH v4 5/9] MIPS: Add LUI instruction " Jie Mei
2023-06-19 8:29 ` [PATCH v4 6/9] MIPS: Add load/store word left/right instructions " Jie Mei
2023-06-19 8:29 ` [PATCH v4 7/9] MIPS: Use ISA_HAS_9BIT_DISPLACEMENT " Jie Mei
2023-06-19 8:29 ` [PATCH v4 8/9] MIPS: Add CACHE instruction " Jie Mei
2023-06-19 8:29 ` [PATCH v4 9/9] MIPS: Make mips16e2 generating ZEB/ZEH instead of ANDI under certain conditions Jie Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706230657.wpokedcvtr25zwrz@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jie.mei@oss.cipunited.com \
--cc=macro@orcam.me.uk \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).