* [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp
@ 2023-07-13 10:21 Christophe Lyon
2023-07-13 10:21 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
2023-07-14 15:43 ` [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Kyrylo Tkachov
0 siblings, 2 replies; 6+ messages in thread
From: Christophe Lyon @ 2023-07-13 10:21 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw; +Cc: Christophe Lyon
If GCC is configured with the default (soft) -mfloat-abi, and we don't
override the target_board test flags appropriately,
gcc.target/arm/mve/general-c/nomve_fp_1.c fails for lack of
-mfloat-abi=softfp or -mfloat-abi=hard, because it doesn't use
dg-add-options arm_v8_1m_mve (on purpose, see comment in the test).
Require and use the options needed for arm_fp to fix this problem.
2023-06-28 Christophe Lyon <christophe.lyon@linaro.org>
gcc/testsuite/
* gcc.target/arm/mve/general-c/nomve_fp_1.c: Require arm_fp.
---
gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
index 21c2af16a61..c9d279ead68 100644
--- a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
+++ b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
@@ -1,9 +1,11 @@
/* { dg-do compile } */
/* { dg-require-effective-target arm_v8_1m_mve_ok } */
+/* { dg-require-effective-target arm_fp_ok } */
/* Do not use dg-add-options arm_v8_1m_mve, because this might expand to "",
which could imply mve+fp depending on the user settings. We want to make
sure the '+fp' extension is not enabled. */
/* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
+/* { dg-add-options arm_fp } */
#include <arm_mve.h>
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU
2023-07-13 10:21 [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Christophe Lyon
@ 2023-07-13 10:21 ` Christophe Lyon
2023-07-14 15:44 ` Kyrylo Tkachov
2023-07-14 15:43 ` [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Kyrylo Tkachov
1 sibling, 1 reply; 6+ messages in thread
From: Christophe Lyon @ 2023-07-13 10:21 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov, richard.earnshaw; +Cc: Christophe Lyon
This tests currently expect a directive containing .fpu fpv5-sp-d16
and thus may fail if the test is executed for instance with
-march=armv8.1-m.main+mve.fp+fp.dp
This patch accepts either fpv5-sp-d16 or fpv5-d16 to avoid the failure.
2023-06-28 Christophe Lyon <christophe.lyon@linaro.org>
gcc/testsuite/
* gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c: Fix .fpu
scan-assembler.
* gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c: Likewise.
---
gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c | 2 +-
gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
index e375327fb97..8358a616bb5 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
@@ -12,4 +12,4 @@ foo1 (int8x16_t value)
return b;
}
-/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
+/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
index 1fca1100cf0..5dd2feefc35 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
@@ -12,4 +12,4 @@ foo1 (int8x16_t value)
return b;
}
-/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
+/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp
2023-07-13 10:21 [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Christophe Lyon
2023-07-13 10:21 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
@ 2023-07-14 15:43 ` Kyrylo Tkachov
1 sibling, 0 replies; 6+ messages in thread
From: Kyrylo Tkachov @ 2023-07-14 15:43 UTC (permalink / raw)
To: Christophe Lyon, gcc-patches, Richard Earnshaw
> -----Original Message-----
> From: Christophe Lyon <christophe.lyon@linaro.org>
> Sent: Thursday, July 13, 2023 11:22 AM
> To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>;
> Richard Earnshaw <Richard.Earnshaw@arm.com>
> Cc: Christophe Lyon <christophe.lyon@linaro.org>
> Subject: [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp
>
> If GCC is configured with the default (soft) -mfloat-abi, and we don't
> override the target_board test flags appropriately,
> gcc.target/arm/mve/general-c/nomve_fp_1.c fails for lack of
> -mfloat-abi=softfp or -mfloat-abi=hard, because it doesn't use
> dg-add-options arm_v8_1m_mve (on purpose, see comment in the test).
>
> Require and use the options needed for arm_fp to fix this problem.
Ok.
Thanks,
Kyrill
>
> 2023-06-28 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/mve/general-c/nomve_fp_1.c: Require arm_fp.
> ---
> gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> index 21c2af16a61..c9d279ead68 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/general-c/nomve_fp_1.c
> @@ -1,9 +1,11 @@
> /* { dg-do compile } */
> /* { dg-require-effective-target arm_v8_1m_mve_ok } */
> +/* { dg-require-effective-target arm_fp_ok } */
> /* Do not use dg-add-options arm_v8_1m_mve, because this might expand
> to "",
> which could imply mve+fp depending on the user settings. We want to
> make
> sure the '+fp' extension is not enabled. */
> /* { dg-options "-mfpu=auto -march=armv8.1-m.main+mve" } */
> +/* { dg-add-options arm_fp } */
>
> #include <arm_mve.h>
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU
2023-07-13 10:21 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
@ 2023-07-14 15:44 ` Kyrylo Tkachov
0 siblings, 0 replies; 6+ messages in thread
From: Kyrylo Tkachov @ 2023-07-14 15:44 UTC (permalink / raw)
To: Christophe Lyon, gcc-patches, Richard Earnshaw
> -----Original Message-----
> From: Christophe Lyon <christophe.lyon@linaro.org>
> Sent: Thursday, July 13, 2023 11:22 AM
> To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>;
> Richard Earnshaw <Richard.Earnshaw@arm.com>
> Cc: Christophe Lyon <christophe.lyon@linaro.org>
> Subject: [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or
> double precision FPU
>
> This tests currently expect a directive containing .fpu fpv5-sp-d16
> and thus may fail if the test is executed for instance with
> -march=armv8.1-m.main+mve.fp+fp.dp
>
> This patch accepts either fpv5-sp-d16 or fpv5-d16 to avoid the failure.
>
Ok.
Thanks,
Kyrill
> 2023-06-28 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c: Fix .fpu
> scan-assembler.
> * gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c: Likewise.
> ---
> gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c | 2 +-
> gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> index e375327fb97..8358a616bb5 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> @@ -12,4 +12,4 @@ foo1 (int8x16_t value)
> return b;
> }
>
> -/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
> +/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
> diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> index 1fca1100cf0..5dd2feefc35 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> @@ -12,4 +12,4 @@ foo1 (int8x16_t value)
> return b;
> }
>
> -/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
> +/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
> --
> 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] [testsuite, arm]: Make mve_fp_fpu[12].c accept single or double precision FPU
2023-06-28 9:26 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
@ 2023-06-28 10:20 ` Richard Earnshaw (lists)
0 siblings, 0 replies; 6+ messages in thread
From: Richard Earnshaw (lists) @ 2023-06-28 10:20 UTC (permalink / raw)
To: Christophe Lyon, gcc-patches, Kyrylo.Tkachov
On 28/06/2023 10:26, Christophe Lyon via Gcc-patches wrote:
> This tests currently expect a directive containing .fpu fpv5-sp-d16
> and thus may fail if the test is executed for instance with
> -march=armv8.1-m.main+mve.fp+fp.dp
>
> This patch accepts either fpv5-sp-d16 or fpv5-d16 to avoid the failure.
>
> 2023-06-28 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c: Fix .fpu
> scan-assembler.
> * gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c: Likewise.
> ---
> gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c | 2 +-
> gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> index e375327fb97..8358a616bb5 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
> @@ -12,4 +12,4 @@ foo1 (int8x16_t value)
> return b;
> }
>
> -/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
> +/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
> diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> index 1fca1100cf0..5dd2feefc35 100644
> --- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> +++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
> @@ -12,4 +12,4 @@ foo1 (int8x16_t value)
> return b;
> }
>
> -/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
> +/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
OK.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU
2023-06-28 9:26 Christophe Lyon
@ 2023-06-28 9:26 ` Christophe Lyon
2023-06-28 10:20 ` [PATCH 2/2] [testsuite, arm]: " Richard Earnshaw (lists)
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Lyon @ 2023-06-28 9:26 UTC (permalink / raw)
To: gcc-patches, Kyrylo.Tkachov; +Cc: Christophe Lyon
This tests currently expect a directive containing .fpu fpv5-sp-d16
and thus may fail if the test is executed for instance with
-march=armv8.1-m.main+mve.fp+fp.dp
This patch accepts either fpv5-sp-d16 or fpv5-d16 to avoid the failure.
2023-06-28 Christophe Lyon <christophe.lyon@linaro.org>
gcc/testsuite/
* gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c: Fix .fpu
scan-assembler.
* gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c: Likewise.
---
gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c | 2 +-
gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
index e375327fb97..8358a616bb5 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c
@@ -12,4 +12,4 @@ foo1 (int8x16_t value)
return b;
}
-/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
+/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
diff --git a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
index 1fca1100cf0..5dd2feefc35 100644
--- a/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
+++ b/gcc/testsuite/gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c
@@ -12,4 +12,4 @@ foo1 (int8x16_t value)
return b;
}
-/* { dg-final { scan-assembler "\.fpu fpv5-sp-d16" } } */
+/* { dg-final { scan-assembler "\.fpu fpv5(-sp|)-d16" } } */
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-14 15:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 10:21 [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Christophe Lyon
2023-07-13 10:21 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
2023-07-14 15:44 ` Kyrylo Tkachov
2023-07-14 15:43 ` [PATCH 1/2] [testsuite,arm]: Make nomve_fp_1.c require arm_fp Kyrylo Tkachov
-- strict thread matches above, loose matches on Subject: below --
2023-06-28 9:26 Christophe Lyon
2023-06-28 9:26 ` [PATCH 2/2] [testsuite,arm]: Make mve_fp_fpu[12].c accept single or double precision FPU Christophe Lyon
2023-06-28 10:20 ` [PATCH 2/2] [testsuite, arm]: " Richard Earnshaw (lists)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).