public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: liuhongt <hongtao.liu@intel.com>
To: gcc-patches@gcc.gnu.org
Cc: crazylht@gmail.com, hjl.tools@gmail.com
Subject: [PATCH] Remove # from <mask_codefor>one_cmpl<mode>2<mask_name> assemble output.
Date: Mon, 17 Jul 2023 15:48:38 +0800	[thread overview]
Message-ID: <20230717074838.2724136-1-hongtao.liu@intel.com> (raw)

optimize_insn_for_speed () in assemble output is not aligned with
splitter condition, and it cause an ICE when building SPEC2017
blender_r.

Not sure if ctrl is supposed to be reliable in assemble output, the patch just remove that as a walkaround.
Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}
Ready to push to trunk.

libpng/pngread.c: In function ‘png_read_image’:
libpng/pngread.c:786:1: internal compiler error: in final_scan_insn_1, at final.cc:2813
  786 | }
      | ^
0x73ac3d final_scan_insn_1
	../../gcc/final.cc:2813
0xb3420b final_scan_insn(rtx_insn*, _IO_FILE*, int, int, int*)
	../../gcc/final.cc:2887
0xb344c4 final_1
	../../gcc/final.cc:1979
0xb34f64 rest_of_handle_final
	../../gcc/final.cc:4240
0xb34f64 execute
	../../gcc/final.cc:4318

gcc/ChangeLog:

	PR target/110438
	* config/i386/sse.md (<mask_codefor>one_cmpl<mode>2<mask_name>):
	Remove # from assemble output.
---
 gcc/config/i386/sse.md | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 6bf9c99a2c1..e1158c5717a 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -17220,10 +17220,6 @@ (define_insn_and_split "<mask_codefor>one_cmpl<mode>2<mask_name>"
        || <ssescalarmode>mode == SImode
        || <ssescalarmode>mode == DImode)"
 {
-  if (!<mask_applied> && which_alternative
-      && optimize_insn_for_speed_p ())
-    return "#";
-
   if (TARGET_AVX512VL)
     return "vpternlog<ternlogsuffix>\t{$0x55, %1, %0, %0<mask_operand3>|%0<mask_operand3>, %0, %1, 0x55}";
   else
-- 
2.39.1.388.g2fc9e9ca3c


                 reply	other threads:[~2023-07-17  7:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717074838.2724136-1-hongtao.liu@intel.com \
    --to=hongtao.liu@intel.com \
    --cc=crazylht@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).