From: pan2.li@intel.com
To: gcc-patches@gcc.gnu.org
Cc: juzhe.zhong@rivai.ai, pan2.li@intel.com, yanzhang.wang@intel.com,
kito.cheng@gmail.com
Subject: [PATCH v2] RISC-V: Fix RVV frm run test failure on RV32
Date: Tue, 18 Jul 2023 10:49:53 +0800 [thread overview]
Message-ID: <20230718024953.1343484-1-pan2.li@intel.com> (raw)
In-Reply-To: <20230714132050.2728477-1-pan2.li@intel.com>
From: Pan Li <pan2.li@intel.com>
Refine the run test case to avoid interactive checking in RV32, by
separating each checks in different functions.
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/testsuite/ChangeLog:
* gcc.target/riscv/rvv/base/float-point-frm-run-1.c: Fix run failure.
---
.../riscv/rvv/base/float-point-frm-run-1.c | 59 +++++++++++--------
1 file changed, 36 insertions(+), 23 deletions(-)
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c
index 245ce7d1fc0..1b2789a924b 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-run-1.c
@@ -5,6 +5,24 @@
#include <stdio.h>
#include <stdint-gcc.h>
+#define DEFINE_TEST_FUNC(FRM) \
+vfloat32m1_t __attribute__ ((noinline)) \
+test_float_point_frm_run_##FRM (vfloat32m1_t op1, vfloat32m1_t op2, size_t vl) \
+{ \
+ vfloat32m1_t result; \
+ \
+ set_frm (0); \
+ \
+ result = __riscv_vfadd_vv_f32m1_rm (op1, result, FRM, vl); \
+ \
+ assert_equal (FRM, get_frm (), "The value of frm should be " #FRM "."); \
+ \
+ return result; \
+}
+
+#define RUN_TEST_FUNC(FRM, op1, op2, vl) \
+ test_float_point_frm_run_##FRM (op1, op2, vl)
+
static int
get_frm ()
{
@@ -41,28 +59,11 @@ assert_equal (int a, int b, char *message)
}
}
-vfloat32m1_t __attribute__ ((noinline))
-test_float_point_frm_run (vfloat32m1_t op1, vfloat32m1_t op2, size_t vl)
-{
- vfloat32m1_t result;
-
- result = __riscv_vfadd_vv_f32m1_rm (op1, result, 1, vl);
- assert_equal (1, get_frm (), "The value of frm register should be 1.");
-
- result = __riscv_vfadd_vv_f32m1_rm (op1, result, 2, vl);
- assert_equal (2, get_frm (), "The value of frm register should be 2.");
-
- result = __riscv_vfadd_vv_f32m1_rm (op1, result, 3, vl);
- assert_equal (3, get_frm (), "The value of frm register should be 3.");
-
- result = __riscv_vfadd_vv_f32m1_rm (op1, result, 4, vl);
- assert_equal (4, get_frm (), "The value of frm register should be 4.");
-
- result = __riscv_vfadd_vv_f32m1_rm (op1, result, 0, vl);
- assert_equal (0, get_frm (), "The value of frm register should be 0.");
-
- return result;
-}
+DEFINE_TEST_FUNC (0)
+DEFINE_TEST_FUNC (1)
+DEFINE_TEST_FUNC (2)
+DEFINE_TEST_FUNC (3)
+DEFINE_TEST_FUNC (4)
int
main ()
@@ -72,8 +73,20 @@ main ()
vfloat32m1_t op2;
set_frm (4);
- test_float_point_frm_run (op1, op2, vl);
+ RUN_TEST_FUNC (0, op1, op2, vl);
+ assert_equal (4, get_frm (), "The value of frm register should be 4.");
+
+ RUN_TEST_FUNC (1, op1, op2, vl);
+ assert_equal (4, get_frm (), "The value of frm register should be 4.");
+
+ RUN_TEST_FUNC (2, op1, op2, vl);
+ assert_equal (4, get_frm (), "The value of frm register should be 4.");
+
+ RUN_TEST_FUNC (3, op1, op2, vl);
+ assert_equal (4, get_frm (), "The value of frm register should be 4.");
+
+ RUN_TEST_FUNC (4, op1, op2, vl);
assert_equal (4, get_frm (), "The value of frm register should be 4.");
return 0;
--
2.34.1
next prev parent reply other threads:[~2023-07-18 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 13:20 [PATCH v1] " pan2.li
2023-07-18 1:09 ` juzhe.zhong
2023-07-18 2:52 ` Li, Pan2
2023-07-18 2:49 ` pan2.li [this message]
2023-07-18 2:53 ` [PATCH v2] " juzhe.zhong
2023-07-18 3:04 ` Li, Pan2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718024953.1343484-1-pan2.li@intel.com \
--to=pan2.li@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=yanzhang.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).