From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D30CF3858C33 for ; Wed, 19 Jul 2023 19:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D30CF3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689794457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q4cm+V7AjhtR4ZMvNi29+esmvGrzPqd9uIldFvl6UiM=; b=C22rh6YpNyV4QybLPpJyQv023xXSu8St1PQsu0H9ke4k0Wnn3S0qV4Iz7YxGVs3Z4teitG tuxJvHxWunep5lXvOHTOzrYRTqAjUd6EFCC3706XhkGOGVDrqHehu5eS0J29p9B1a3SbuN 8MwH4xL2YsnmIpD/kRAXItnf2uWpDTU= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-sqOxklmGPLmGX_O2cV49Vw-1; Wed, 19 Jul 2023 15:20:56 -0400 X-MC-Unique: sqOxklmGPLmGX_O2cV49Vw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E69CF28237CB for ; Wed, 19 Jul 2023 19:20:55 +0000 (UTC) Received: from pdp-11.lan (unknown [10.22.9.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF8B31454142; Wed, 19 Jul 2023 19:20:55 +0000 (UTC) From: Marek Polacek To: GCC Patches , Jason Merrill Cc: Patrick Palka Subject: [PATCH] c++: -Wmissing-field-initializers and empty class [PR110064] Date: Wed, 19 Jul 2023 15:20:47 -0400 Message-ID: <20230719192047.449259-1-polacek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- Let's suppress -Wmissing-field-initializers for empty classes. Here I don't think I need the usual COMPLETE_TYPE_P/dependent_type_p checks. PR c++/110064 gcc/cp/ChangeLog: * typeck2.cc (process_init_constructor_record): Don't emit -Wmissing-field-initializers for empty classes. gcc/testsuite/ChangeLog: * g++.dg/warn/Wmissing-field-initializers-3.C: New test. --- gcc/cp/typeck2.cc | 3 +- .../warn/Wmissing-field-initializers-3.C | 48 +++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C diff --git a/gcc/cp/typeck2.cc b/gcc/cp/typeck2.cc index 1c204c8612b..582a73bb053 100644 --- a/gcc/cp/typeck2.cc +++ b/gcc/cp/typeck2.cc @@ -1874,7 +1874,8 @@ process_init_constructor_record (tree type, tree init, int nested, int flags, to zero. */ if ((complain & tf_warning) && !cp_unevaluated_operand - && !EMPTY_CONSTRUCTOR_P (init)) + && !EMPTY_CONSTRUCTOR_P (init) + && !is_really_empty_class (fldtype, /*ignore_vptr*/false)) warning (OPT_Wmissing_field_initializers, "missing initializer for member %qD", field); diff --git a/gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C b/gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C new file mode 100644 index 00000000000..a8d75b92bd1 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wmissing-field-initializers-3.C @@ -0,0 +1,48 @@ +// PR c++/110064 +// { dg-do compile { target c++17 } } +// { dg-options "-Wmissing-field-initializers" } + +struct B { }; +struct D : B { + int x; + int y; +}; + +struct E { + int x; + int y; + B z; +}; + +template struct X { }; + +template +struct F { + int i; + int j; + X x; +}; + +int +main () +{ + D d = {.x=1, .y=2}; // { dg-bogus "missing" } + (void)d; + E e = {.x=1, .y=2}; // { dg-bogus "missing" } + (void)e; + F f = {.i=1, .j=2 }; // { dg-bogus "missing" } + (void)f; +} + +template +void fn () +{ + F f = {.i=1, .j=2 }; // { dg-bogus "missing" } + (void)f; +} + +void +g () +{ + fn (); +} base-commit: 2971ff7b1d564ac04b537d907c70e6093af70832 -- 2.41.0