From: Marek Polacek <polacek@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: [PATCH] c++: Improve printing of base classes [PR110745]
Date: Wed, 19 Jul 2023 17:51:22 -0400 [thread overview]
Message-ID: <20230719215122.513059-1-polacek@redhat.com> (raw)
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?
-- >8 --
This patch changes
warning: missing initializer for member 'D::<anonymous>' [-Wmissing-field-initializers]
to
warning: missing initializer for member 'D::B' [-Wmissing-field-initializers]
PR c++/110745
gcc/cp/ChangeLog:
* error.cc (dump_simple_decl): Print base class name.
gcc/testsuite/ChangeLog:
* g++.dg/diagnostic/base.C: New test.
---
gcc/cp/error.cc | 2 ++
gcc/testsuite/g++.dg/diagnostic/base.C | 16 ++++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 gcc/testsuite/g++.dg/diagnostic/base.C
diff --git a/gcc/cp/error.cc b/gcc/cp/error.cc
index 31319aa9e87..8a5219a68a1 100644
--- a/gcc/cp/error.cc
+++ b/gcc/cp/error.cc
@@ -1177,6 +1177,8 @@ dump_simple_decl (cxx_pretty_printer *pp, tree t, tree type, int flags)
}
else if (DECL_DECOMPOSITION_P (t))
pp_string (pp, M_("<structured bindings>"));
+ else if (TREE_CODE (t) == FIELD_DECL && DECL_FIELD_IS_BASE (t))
+ dump_type (pp, TREE_TYPE (t), flags);
else
pp_string (pp, M_("<anonymous>"));
diff --git a/gcc/testsuite/g++.dg/diagnostic/base.C b/gcc/testsuite/g++.dg/diagnostic/base.C
new file mode 100644
index 00000000000..1540414072e
--- /dev/null
+++ b/gcc/testsuite/g++.dg/diagnostic/base.C
@@ -0,0 +1,16 @@
+// PR c++/110745
+// { dg-do compile { target c++17 } }
+// { dg-options "-Wmissing-field-initializers" }
+
+struct B { int i; };
+struct D : B {
+ int x;
+ int y;
+};
+
+int
+main ()
+{
+ D d = {.x=1, .y=2}; // { dg-warning "missing initializer for member .D::B." }
+ (void)d;
+}
base-commit: b1ae46bdd19fc2aaea41bc894168bdaf4799be80
--
2.41.0
next reply other threads:[~2023-07-19 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 21:51 Marek Polacek [this message]
2023-07-19 21:56 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719215122.513059-1-polacek@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).