From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id BE2653858409 for ; Thu, 20 Jul 2023 12:38:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE2653858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D4E0B2069D; Thu, 20 Jul 2023 12:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689856716; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=DDkdgb0YcXCtoiYZiNLwBnhYLpoRhWyFstmrt79Gtd4=; b=G5GCK3BJO66sv3Dn6ZSU8A73wIOEUwicF2UN5PIVZTX8Bu3Demz4lK8VT2DRyo8uW7x2FT XZVHQDNZsen4m1wZl6lma05CQjJujBBGRZEQ15qvK6BaU6eg1SXqTx/yoJxhCxxXW9gdYE Uyad4r9dxocZrOfz1ZINykDE1npoK/A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689856716; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=DDkdgb0YcXCtoiYZiNLwBnhYLpoRhWyFstmrt79Gtd4=; b=lWwFN7zNyn6X7w4YLjRii49xBUH7fyP0ys0KJVrkd/qT/crKeyWWBqOmYKLIGBeN+gPf9E So0k10+4VzDP2PDA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C339B2C142; Thu, 20 Jul 2023 12:38:36 +0000 (UTC) Date: Thu, 20 Jul 2023 12:38:36 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: richard.sandiford@arm.com Subject: [PATCH] tree-optimization/110742 - fix latent issue with permuting existing vectors User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,MISSING_MID,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230720123836.a_73bJ1MSfZW75BflJ2zdG6SHoVboCsBWQDkygd2hFw@z> When we materialize a layout we push edge permutes to constant/external defs without checking we can actually do so. For externals defined by vector stmts rather than scalar components we can't. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK? Thanks, Richard. PR tree-optimization/110742 * tree-vect-slp.cc (vect_optimize_slp_pass::get_result_with_layout): Do not materialize an edge permutation in an external node with vector defs. (vect_slp_analyze_node_operations_1): Guard purely internal nodes better. * g++.dg/torture/pr110742.C: New testcase. --- gcc/testsuite/g++.dg/torture/pr110742.C | 47 +++++++++++++++++++++++++ gcc/tree-vect-slp.cc | 8 +++-- 2 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/torture/pr110742.C diff --git a/gcc/testsuite/g++.dg/torture/pr110742.C b/gcc/testsuite/g++.dg/torture/pr110742.C new file mode 100644 index 00000000000..d41ac0479d2 --- /dev/null +++ b/gcc/testsuite/g++.dg/torture/pr110742.C @@ -0,0 +1,47 @@ +// { dg-do compile } + +struct HARD_REG_SET { + HARD_REG_SET operator~() const { + HARD_REG_SET res; + for (unsigned int i = 0; i < (sizeof(elts) / sizeof((elts)[0])); ++i) + res.elts[i] = ~elts[i]; + return res; + } + HARD_REG_SET operator&(const HARD_REG_SET &other) const { + HARD_REG_SET res; + for (unsigned int i = 0; i < (sizeof(elts) / sizeof((elts)[0])); ++i) + res.elts[i] = elts[i] & other.elts[i]; + return res; + } + unsigned long elts[4]; +}; +typedef const HARD_REG_SET &const_hard_reg_set; +inline bool hard_reg_set_subset_p(const_hard_reg_set x, const_hard_reg_set y) { + unsigned long bad = 0; + for (unsigned int i = 0; i < (sizeof(x.elts) / sizeof((x.elts)[0])); ++i) + bad |= (x.elts[i] & ~y.elts[i]); + return bad == 0; +} +inline bool hard_reg_set_empty_p(const_hard_reg_set x) { + unsigned long bad = 0; + for (unsigned int i = 0; i < (sizeof(x.elts) / sizeof((x.elts)[0])); ++i) + bad |= x.elts[i]; + return bad == 0; +} +extern HARD_REG_SET rr[2]; +extern int t[2]; +extern HARD_REG_SET nn; +static HARD_REG_SET mm; +void setup_reg_class_relations(void) { + HARD_REG_SET intersection_set, union_set, temp_set2; + for (int cl2 = 0; cl2 < 2; cl2++) { + temp_set2 = rr[cl2] & ~nn; + if (hard_reg_set_empty_p(mm) && hard_reg_set_empty_p(temp_set2)) { + mm = rr[0] & nn; + if (hard_reg_set_subset_p(mm, intersection_set)) + if (!hard_reg_set_subset_p(mm, temp_set2) || + hard_reg_set_subset_p(rr[0], rr[t[cl2]])) + t[cl2] = 0; + } + } +} diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 693621ca990..1d79c77e8ce 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -5198,7 +5198,10 @@ vect_optimize_slp_pass::get_result_with_layout (slp_tree node, return result; if (SLP_TREE_DEF_TYPE (node) == vect_constant_def - || SLP_TREE_DEF_TYPE (node) == vect_external_def) + || (SLP_TREE_DEF_TYPE (node) == vect_external_def + && (to_layout_i == 0 + /* We can't permute vector defs. */ + || SLP_TREE_VEC_DEFS (node).is_empty ()))) { /* If the vector is uniform or unchanged, there's nothing to do. */ if (to_layout_i == 0 || vect_slp_tree_uniform_p (node)) @@ -5944,7 +5947,8 @@ vect_slp_analyze_node_operations_1 (vec_info *vinfo, slp_tree node, calculated by the recursive call). Otherwise it is the number of scalar elements in one scalar iteration (DR_GROUP_SIZE) multiplied by VF divided by the number of elements in a vector. */ - if (!STMT_VINFO_DATA_REF (stmt_info) + if (SLP_TREE_CODE (node) != VEC_PERM_EXPR + && !STMT_VINFO_DATA_REF (stmt_info) && REDUC_GROUP_FIRST_ELEMENT (stmt_info)) { for (unsigned i = 0; i < SLP_TREE_CHILDREN (node).length (); ++i) -- 2.35.3