From: Drew Ross <drross@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Drew Ross <drross@redhat.com>
Subject: [PATCH] match.pd: Implement missed optimization (x << c) >> c -> -(x & 1) [PR101955]
Date: Fri, 21 Jul 2023 11:08:51 -0400 [thread overview]
Message-ID: <20230721150851.94504-1-drross@redhat.com> (raw)
Simplifies (x << c) >> c where x is a signed integral type of
width >= int and c = precision(type) - 1 into -(x & 1). Tested successfully
on x86_64 and x86 targets.
PR middle-end/101955
gcc/ChangeLog:
* match.pd (x << c) >> c -> -(x & 1): New simplification.
gcc/testsuite/ChangeLog:
* gcc.dg/pr101955.c: New test.
---
gcc/match.pd | 10 +++++
gcc/testsuite/gcc.dg/pr101955.c | 69 +++++++++++++++++++++++++++++++++
2 files changed, 79 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/pr101955.c
diff --git a/gcc/match.pd b/gcc/match.pd
index 8543f777a28..820fc890e8e 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -3766,6 +3766,16 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
&& (wi::ltu_p (wi::to_wide (@1), element_precision (type))))
(bit_and @0 (rshift { build_minus_one_cst (type); } @1))))
+/* Optimize (X << C) >> C where C = precision(type) - 1 and X is signed
+ into -(X & 1). */
+(simplify
+ (rshift (nop_convert? (lshift @0 uniform_integer_cst_p@1)) @@1)
+ (with { tree cst = uniform_integer_cst_p (@1); }
+ (if (ANY_INTEGRAL_TYPE_P (type)
+ && !TYPE_UNSIGNED (type)
+ && wi::eq_p (wi::to_wide (cst), element_precision (type) - 1))
+ (negate (bit_and (convert @0) { build_one_cst (type); })))))
+
/* Optimize x >> x into 0 */
(simplify
(rshift @0 @0)
diff --git a/gcc/testsuite/gcc.dg/pr101955.c b/gcc/testsuite/gcc.dg/pr101955.c
new file mode 100644
index 00000000000..386154911c5
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr101955.c
@@ -0,0 +1,69 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-dse1 -Wno-psabi" } */
+
+typedef int v4si __attribute__((vector_size(4 * sizeof(int))));
+
+__attribute__((noipa)) int
+t1 (int x)
+{
+ return (x << 31) >> 31;
+}
+
+__attribute__((noipa)) int
+t2 (int x)
+{
+ int y = x << 31;
+ int z = y >> 31;
+ return z;
+}
+
+__attribute__((noipa)) int
+t3 (int x)
+{
+ int w = 31;
+ int y = x << w;
+ int z = y >> w;
+ return z;
+}
+
+__attribute__((noipa)) long long
+t4 (long long x)
+{
+ return (x << 63) >> 63;
+}
+
+__attribute__((noipa)) long long
+t5 (long long x)
+{
+ long long y = x << 63;
+ long long z = y >> 63;
+ return z;
+}
+
+__attribute__((noipa)) long long
+t6 (long long x)
+{
+ int w = 63;
+ long long y = x << w;
+ long long z = y >> w;
+ return z;
+}
+
+__attribute__((noipa)) v4si
+t7 (v4si x)
+{
+ return (x << 31) >> 31;
+}
+
+__attribute__((noipa)) v4si
+t8 (v4si x)
+{
+ v4si t = {31,31,31,31};
+ return (x << t) >> t;
+}
+
+/* { dg-final { scan-tree-dump-not " >> " "dse1" } } */
+/* { dg-final { scan-tree-dump-not " << " "dse1" } } */
+/* { dg-final { scan-tree-dump-times " -" 8 "dse1" } } */
+/* { dg-final { scan-tree-dump-times " & " 8 "dse1" } } */
+
--
2.39.3
next reply other threads:[~2023-07-21 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:08 Drew Ross [this message]
2023-07-21 17:27 ` Andrew Pinski
2023-07-22 6:09 ` Jeff Law
2023-07-24 7:16 ` Richard Biener
2023-07-24 19:29 ` Drew Ross
2023-07-24 19:42 ` Jakub Jelinek
2023-07-25 6:54 ` Richard Biener
2023-07-25 19:25 ` Drew Ross
2023-07-25 19:43 ` Jakub Jelinek
2023-07-26 8:39 ` Richard Biener
2023-07-26 18:18 ` Drew Ross
2023-07-28 6:30 ` Richard Biener
2023-08-01 19:20 ` [PATCH] match.pd: Canonicalize (signed x << c) >> c [PR101955] Drew Ross
2023-08-01 21:36 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721150851.94504-1-drross@redhat.com \
--to=drross@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).