From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id A356C3858D3C for ; Tue, 25 Jul 2023 13:40:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A356C3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 2450D1FD6D; Tue, 25 Jul 2023 13:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690292404; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=EDgd4yaV6JVf1tbgbcQShjNmSkTXSAbZ535IRI+MO2U=; b=CxspkyVK34zse3HI+0ING1zNEEe5S0SA3MIaZb4meYAAsWj9y17SwNABnEUWzBcJW4tg3e naKSYDUwIpvK5r0VLwea2/dSLscosidcQf7DxeS/pjPKzQE/Y3iV+Zqen4qwOG+Dy3M/An +U8i3XFYA1YF60ocaHxHniYi54hjZXE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690292404; h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=EDgd4yaV6JVf1tbgbcQShjNmSkTXSAbZ535IRI+MO2U=; b=vuYC4gcU6MfL4bgWybAeWyEj7kgBHj575wznVO0Y95ARHO2zaBNxBLGSxaOorpF01hKtgp b5dlJRDs9WfVW7Bg== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 12C002C143; Tue, 25 Jul 2023 13:40:04 +0000 (UTC) Date: Tue, 25 Jul 2023 13:40:04 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: vmakarov@redhat.com Subject: [PATCH] rtl-optimization/110587 - remove quadratic regno_in_use_p User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,MISSING_MID,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230725134004.-phJ9FKHi3JypsTkFB-pGGLs8ZK7Ofu3tngn2AUx5FY@z> The following removes the code checking whether a noop copy is between something involved in the return sequence composed of a SET and USE. Instead of checking for this special-case the following makes us only ever remove noop copies between pseudos - which is the case that is necessary for IRA/LRA interfacing to function according to the comment. That makes looking for the return reg special case unnecessary, reducing the compile-time in LRA non-specific to zero for the testcase. Bootstrapped and tested on x86_64-unknown-linux-gnu with all languages and {,-m32}. OK? Thanks, Richard. PR rtl-optimization/110587 * lra-spills.cc (return_regno_p): Remove. (regno_in_use_p): Likewise. (lra_final_code_change): Do not remove noop moves between hard registers. --- gcc/lra-spills.cc | 69 +---------------------------------------------- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/gcc/lra-spills.cc b/gcc/lra-spills.cc index 3a7bb7e8cd9..fe58f162d05 100644 --- a/gcc/lra-spills.cc +++ b/gcc/lra-spills.cc @@ -705,72 +705,6 @@ alter_subregs (rtx *loc, bool final_p) return res; } -/* Return true if REGNO is used for return in the current - function. */ -static bool -return_regno_p (unsigned int regno) -{ - rtx outgoing = crtl->return_rtx; - - if (! outgoing) - return false; - - if (REG_P (outgoing)) - return REGNO (outgoing) == regno; - else if (GET_CODE (outgoing) == PARALLEL) - { - int i; - - for (i = 0; i < XVECLEN (outgoing, 0); i++) - { - rtx x = XEXP (XVECEXP (outgoing, 0, i), 0); - - if (REG_P (x) && REGNO (x) == regno) - return true; - } - } - return false; -} - -/* Return true if REGNO is in one of subsequent USE after INSN in the - same BB. */ -static bool -regno_in_use_p (rtx_insn *insn, unsigned int regno) -{ - static lra_insn_recog_data_t id; - static struct lra_static_insn_data *static_id; - struct lra_insn_reg *reg; - int i, arg_regno; - basic_block bb = BLOCK_FOR_INSN (insn); - - while ((insn = next_nondebug_insn (insn)) != NULL_RTX) - { - if (BARRIER_P (insn) || bb != BLOCK_FOR_INSN (insn)) - return false; - if (! INSN_P (insn)) - continue; - if (GET_CODE (PATTERN (insn)) == USE - && REG_P (XEXP (PATTERN (insn), 0)) - && regno == REGNO (XEXP (PATTERN (insn), 0))) - return true; - /* Check that the regno is not modified. */ - id = lra_get_insn_recog_data (insn); - for (reg = id->regs; reg != NULL; reg = reg->next) - if (reg->type != OP_IN && reg->regno == (int) regno) - return false; - static_id = id->insn_static_data; - for (reg = static_id->hard_regs; reg != NULL; reg = reg->next) - if (reg->type != OP_IN && reg->regno == (int) regno) - return false; - if (id->arg_hard_regs != NULL) - for (i = 0; (arg_regno = id->arg_hard_regs[i]) >= 0; i++) - if ((int) regno == (arg_regno >= FIRST_PSEUDO_REGISTER - ? arg_regno : arg_regno - FIRST_PSEUDO_REGISTER)) - return false; - } - return false; -} - /* Final change of pseudos got hard registers into the corresponding hard registers and removing temporary clobbers. */ void @@ -821,8 +755,7 @@ lra_final_code_change (void) if (NONJUMP_INSN_P (insn) && GET_CODE (pat) == SET && REG_P (SET_SRC (pat)) && REG_P (SET_DEST (pat)) && REGNO (SET_SRC (pat)) == REGNO (SET_DEST (pat)) - && (! return_regno_p (REGNO (SET_SRC (pat))) - || ! regno_in_use_p (insn, REGNO (SET_SRC (pat))))) + && REGNO (SET_SRC (pat)) >= FIRST_PSEUDO_REGISTER) { lra_invalidate_insn_data (insn); delete_insn (insn); -- 2.35.3