From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 3A0A73856254 for ; Wed, 26 Jul 2023 13:27:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A0A73856254 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 15228218E5 for ; Wed, 26 Jul 2023 13:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690378054; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=ZChCuTjf9aJ1OiVlMjxBbHXGZAWUoKZzueETde3rH2A=; b=qLS0+UArntnrAIrwO5TB0TsNd1MjeyHV/rnx0FnrsQMYUOywWqE7vtS69NUZwaOVGKj8RY 8OoJPvEJ0P532/zrupuPLpLHQ6fWfvlfQogZBMlMbcUJnkkscFUtsYRepBPIat+JXvcj0h N0TS3KT7/p8u1QXoxtwuH5DbLeZ1TQM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690378054; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=ZChCuTjf9aJ1OiVlMjxBbHXGZAWUoKZzueETde3rH2A=; b=9suUjH6KGQBQ0j0u7uhh0DeJwbBiBw7uSiJzRtPteJkTZLpysfiGxW2G49TQWaBKsJWKqm xE8hfB9GlFF6KgBA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 0AA692C142 for ; Wed, 26 Jul 2023 13:27:33 +0000 (UTC) Date: Wed, 26 Jul 2023 13:27:33 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/106081 - elide redundant permute User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,MISSING_MID,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230726132733.ufCG5aONAEw6S95vg-kZOG8rqqiII6fkitKkw_UTbew@z> The following patch makes sure to elide a redundant permute that can be merged with existing splats represented as load permutations as we now do for non-grouped SLP loads. This is the last bit missing to fix this PR where the main fix was already done by r14-2117-gdd86a5a69cbda4 Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/106081 * tree-vect-slp.cc (vect_optimize_slp_pass::start_choosing_layouts): Assign layout -1 to splats. * gcc.dg/vect/pr106081.c: New testcase. --- gcc/testsuite/gcc.dg/vect/pr106081.c | 33 ++++++++++++++++++++++++++++ gcc/tree-vect-slp.cc | 5 ++++- 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/vect/pr106081.c diff --git a/gcc/testsuite/gcc.dg/vect/pr106081.c b/gcc/testsuite/gcc.dg/vect/pr106081.c new file mode 100644 index 00000000000..8f97af2d642 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr106081.c @@ -0,0 +1,33 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-ffast-math -fdump-tree-optimized" } */ +/* { dg-additional-options "-mavx2" { target x86_64-*-* i?86-*-* } } */ +/* { dg-require-effective-target vect_double } */ +/* { dg-require-effective-target vect_unpack } */ +/* { dg-require-effective-target vect_intdouble_cvt } */ +/* { dg-require-effective-target vect_perm } */ + +struct pixels +{ + short a,b,c,d; +} *pixels; +struct dpixels +{ + double a,b,c,d; +}; + +double +test(double *k) +{ + struct dpixels results={}; + for (int u=0; u<1000*16;u++,k--) + { + results.a += *k*pixels[u].a; + results.b += *k*pixels[u].b; + results.c += *k*pixels[u].c; + results.d += *k*pixels[u].d; + } + return results.a+results.b*2+results.c*3+results.d*4; +} + +/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" } } */ +/* { dg-final { scan-tree-dump-times "VEC_PERM" 4 "optimized" { target x86_64-*-* i?86-*-* } } } */ diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index e4430248ab5..a1b153035e1 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -4605,7 +4605,10 @@ vect_optimize_slp_pass::start_choosing_layouts () IFN_MASK_LOADs). */ gcc_assert (partition.layout == 0 && !m_slpg->vertices[node_i].succ); if (!STMT_VINFO_GROUPED_ACCESS (dr_stmt)) - continue; + { + partition.layout = -1; + continue; + } dr_stmt = DR_GROUP_FIRST_ELEMENT (dr_stmt); imin = DR_GROUP_SIZE (dr_stmt) + 1; tmp_perm.safe_splice (SLP_TREE_LOAD_PERMUTATION (node)); -- 2.35.3