From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (unknown [192.55.52.115]) by sourceware.org (Postfix) with ESMTPS id ED9FF3858C36 for ; Thu, 27 Jul 2023 13:37:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED9FF3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690465022; x=1722001022; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=rQrsiqEFa+sdVMpehZ31SSF9poexvYN9Ns9L/SQr3F8=; b=F9P69I4M3bIxxO+xKNMiroClzZol79jOL8lDrwklfVchUSBLQb4yba16 LwQni3oekd5kxT2i69KlzJ6aa/iDel936nKtIEjHj+WufLcJiYCBS+AHf x+8juOtbjO9Inppv3RjdFsva5VqaY2qnIwPAR3nuU33aiTDiFCGnVQj2n fE0X+8eobnLnS7ZbWJ4fj4ntU5sBt+k/2ykQsdWZtgeEaKw2vJsYK+qHG B1jcROD2TWMv06BP1JciRVKIOMYJR6v6MESeiaBNNXb47Vh0Q+nnzSsEr fOqwX57FRvDJST51MqZY0jzltswrnZ0KcooDNWJj8/wPJpt54YNaIwebQ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="368325670" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="368325670" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 06:36:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="817083790" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="817083790" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2023 06:36:40 -0700 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 087EA1007817; Thu, 27 Jul 2023 21:36:40 +0800 (CST) From: liuhongt To: gcc-patches@gcc.gnu.org Cc: crazylht@gmail.com, hjl.tools@gmail.com Subject: [PATCH] [x86] Add UNSPEC_MASKOP to vpbroadcastm pattern. Date: Thu, 27 Jul 2023 21:36:39 +0800 Message-Id: <20230727133639.2208533-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.39.1.388.g2fc9e9ca3c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Prevent rtl optimization of vec_duplicate + zero_extend to vpbroadcastm since there could be an extra kmov after RA. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,} Ready to push to trunk. gcc/ChangeLog: PR target/110788 * config/i386/sse.md (avx512cd_maskb_vec_dup): Add UNSPEC_MASKOP. (avx512cd_maskw_vec_dup: Ditto. gcc/testsuite/ChangeLog: * gcc.target/i386/pr110788.c: New test. --- gcc/config/i386/sse.md | 8 ++++++-- gcc/testsuite/gcc.target/i386/pr110788.c | 11 +++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr110788.c diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 35fd66ed4aa..51961bbfc0b 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -26778,11 +26778,14 @@ (define_insn "avx512dq_broadcast_1" (set_attr "prefix" "evex") (set_attr "mode" "")]) +;; Use unspec to prevent rtl optimizer to optimize zero_extend + vec_duplicate +;; to pbroadcastm, there could be an extra kmov after RA. (define_insn "avx512cd_maskb_vec_dup" [(set (match_operand:VI8_AVX512VL 0 "register_operand" "=v") (vec_duplicate:VI8_AVX512VL (zero_extend:DI - (match_operand:QI 1 "register_operand" "k"))))] + (match_operand:QI 1 "register_operand" "k")))) + (unspec [(const_int 0)] UNSPEC_MASKOP)] "TARGET_AVX512CD" "vpbroadcastmb2q\t{%1, %0|%0, %1}" [(set_attr "type" "mskmov") @@ -26793,7 +26796,8 @@ (define_insn "avx512cd_maskw_vec_dup" [(set (match_operand:VI4_AVX512VL 0 "register_operand" "=v") (vec_duplicate:VI4_AVX512VL (zero_extend:SI - (match_operand:HI 1 "register_operand" "k"))))] + (match_operand:HI 1 "register_operand" "k")))) + (unspec [(const_int 0)] UNSPEC_MASKOP)] "TARGET_AVX512CD" "vpbroadcastmw2d\t{%1, %0|%0, %1}" [(set_attr "type" "mskmov") diff --git a/gcc/testsuite/gcc.target/i386/pr110788.c b/gcc/testsuite/gcc.target/i386/pr110788.c new file mode 100644 index 00000000000..4cf1676ccb6 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr110788.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -march=cascadelake --param vect-partial-vector-usage=2" } */ +/* { dg-final { scan-assembler-not "vpbroadcastm" } } */ + +double a[1024], b[1024]; + +void foo (int n) +{ + for (int i = 0; i < n; ++i) + a[i] = b[i] * 3.; +} -- 2.39.1.388.g2fc9e9ca3c