From: Andrew Pinski <apinski@marvell.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: [PATCH 2/2] MATCH: Add `a == b | a cmp b` and `a != b & a cmp b` simplifications
Date: Sun, 30 Jul 2023 22:34:12 -0700 [thread overview]
Message-ID: <20230731053412.2102672-2-apinski@marvell.com> (raw)
In-Reply-To: <20230731053412.2102672-1-apinski@marvell.com>
Even though these are done by combine_comparisons, we can add them to match
to allow simplifcations during match rather than just during reassoc/ifcombine.
OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
gcc/ChangeLog:
PR tree-optimization/106164
* match.pd (`a != b & a <= b`, `a != b & a >= b`,
`a == b | a < b`, `a == b | a > b`): Handle these cases
too.
gcc/testsuite/ChangeLog:
PR tree-optimization/106164
* gcc.dg/tree-ssa/cmpbit-2.c: New test.
---
gcc/match.pd | 32 +++++++++++++++++--
gcc/testsuite/gcc.dg/tree-ssa/cmpbit-2.c | 39 ++++++++++++++++++++++++
2 files changed, 69 insertions(+), 2 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/cmpbit-2.c
diff --git a/gcc/match.pd b/gcc/match.pd
index 00af5d99119..cf8057701ea 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -2832,7 +2832,21 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(switch
(if (code1 == EQ_EXPR && val) @3)
(if (code1 == EQ_EXPR && !val) { constant_boolean_node (false, type); })
- (if (code1 == NE_EXPR && !val) @4)))))))
+ (if (code1 == NE_EXPR && !val) @4)
+ (if (code1 == NE_EXPR
+ && code2 == GE_EXPR
+ && cmp == 0)
+ (gt @0 @1))
+ (if (code1 == NE_EXPR
+ && code2 == LE_EXPR
+ && cmp == 0)
+ (lt @0 @1))
+ )
+ )
+ )
+ )
+ )
+)
/* Convert (X OP1 CST1) && (X OP2 CST2).
Convert (X OP1 Y) && (X OP2 Y). */
@@ -2917,7 +2931,21 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(switch
(if (code1 == EQ_EXPR && val) @4)
(if (code1 == NE_EXPR && val) { constant_boolean_node (true, type); })
- (if (code1 == NE_EXPR && !val) @3)))))))
+ (if (code1 == NE_EXPR && !val) @3)
+ (if (code1 == EQ_EXPR
+ && code2 == GT_EXPR
+ && cmp == 0)
+ (ge @0 @1))
+ (if (code1 == EQ_EXPR
+ && code2 == LT_EXPR
+ && cmp == 0)
+ (le @0 @1))
+ )
+ )
+ )
+ )
+ )
+)
/* Convert (X OP1 CST1) || (X OP2 CST2).
Convert (X OP1 Y) || (X OP2 Y). */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/cmpbit-2.c b/gcc/testsuite/gcc.dg/tree-ssa/cmpbit-2.c
new file mode 100644
index 00000000000..c4226ef01af
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/tree-ssa/cmpbit-2.c
@@ -0,0 +1,39 @@
+/* { dg-do compile } */
+/* { dg-options "-O1 -fno-tree-reassoc -fdump-tree-optimized-raw" } */
+
+_Bool f(int a, int b)
+{
+ _Bool c = a == b;
+ _Bool d = a > b;
+ return c | d;
+}
+
+_Bool f1(int a, int b)
+{
+ _Bool c = a != b;
+ _Bool d = a >= b;
+ return c & d;
+}
+
+_Bool g(int a, int b)
+{
+ _Bool c = a == b;
+ _Bool d = a < b;
+ return c | d;
+}
+
+_Bool g1(int a, int b)
+{
+ _Bool c = a != b;
+ _Bool d = a <= b;
+ return c & d;
+}
+
+
+/* We should be able to optimize these without reassociation too. */
+/* { dg-final { scan-tree-dump-not "bit_and_expr," "optimized" } } */
+/* { dg-final { scan-tree-dump-not "bit_ior_expr," "optimized" } } */
+/* { dg-final { scan-tree-dump-times "gt_expr," 1 "optimized" } } */
+/* { dg-final { scan-tree-dump-times "ge_expr," 1 "optimized" } } */
+/* { dg-final { scan-tree-dump-times "lt_expr," 1 "optimized" } } */
+/* { dg-final { scan-tree-dump-times "le_expr," 1 "optimized" } } */
--
2.31.1
next prev parent reply other threads:[~2023-07-31 5:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 5:34 [PATCH 1/2] MATCH: PR 106164 : Optimize `(X CMP1 Y) AND/IOR (X CMP2 Y)` Andrew Pinski
2023-07-31 5:34 ` Andrew Pinski [this message]
2023-07-31 10:52 ` [PATCH 2/2] MATCH: Add `a == b | a cmp b` and `a != b & a cmp b` simplifications Richard Biener
2023-07-31 17:11 ` Andrew Pinski
2023-07-31 10:50 ` [PATCH 1/2] MATCH: PR 106164 : Optimize `(X CMP1 Y) AND/IOR (X CMP2 Y)` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731053412.2102672-2-apinski@marvell.com \
--to=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).