From: Drew Ross <drross@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Drew Ross <drross@redhat.com>
Subject: [PATCH] match.pd: Canonicalize (signed x << c) >> c [PR101955]
Date: Tue, 1 Aug 2023 15:20:33 -0400 [thread overview]
Message-ID: <20230801192033.432742-1-drross@redhat.com> (raw)
In-Reply-To: <CAFiYyc1+rKid8Xg-NFrV6objWNa8k+COwb2_QvWV3J4+V2YoRQ@mail.gmail.com>
Canonicalizes (signed x << c) >> c into the lowest
precision(type) - c bits of x IF those bits have a mode precision or a
precision of 1. Also combines this rule with (unsigned x << c) >> c -> x &
((unsigned)-1 >> c) to prevent duplicate pattern. Tested successfully on
x86_64 and x86 targets.
PR middle-end/101955
gcc/ChangeLog:
* match.pd ((signed x << c) >> c): New canonicalization.
gcc/testsuite/ChangeLog:
* gcc.dg/pr101955.c: New test.
---
gcc/match.pd | 20 +++++++----
gcc/testsuite/gcc.dg/pr101955.c | 63 +++++++++++++++++++++++++++++++++
2 files changed, 77 insertions(+), 6 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/pr101955.c
diff --git a/gcc/match.pd b/gcc/match.pd
index 8543f777a28..62f7c84f565 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -3758,13 +3758,21 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
- TYPE_PRECISION (TREE_TYPE (@2)))))
(bit_and (convert @0) (lshift { build_minus_one_cst (type); } @1))))
-/* Optimize (x << c) >> c into x & ((unsigned)-1 >> c) for unsigned
- types. */
+/* For (x << c) >> c, optimize into x & ((unsigned)-1 >> c) for
+ unsigned x OR truncate into the precision(type) - c lowest bits
+ of signed x (if they have mode precision or a precision of 1) */
(simplify
- (rshift (lshift @0 INTEGER_CST@1) @1)
- (if (TYPE_UNSIGNED (type)
- && (wi::ltu_p (wi::to_wide (@1), element_precision (type))))
- (bit_and @0 (rshift { build_minus_one_cst (type); } @1))))
+ (rshift (nop_convert? (lshift @0 INTEGER_CST@1)) @@1)
+ (if (wi::ltu_p (wi::to_wide (@1), element_precision (type)))
+ (if (TYPE_UNSIGNED (type))
+ (bit_and @0 (rshift { build_minus_one_cst (type); } @1))
+ (if (INTEGRAL_TYPE_P (type))
+ (with {
+ int width = element_precision (type) - tree_to_uhwi (@1);
+ tree stype = build_nonstandard_integer_type (width, 0);
+ }
+ (if (width == 1 || type_has_mode_precision_p (stype))
+ (convert (convert:stype @0))))))))
/* Optimize x >> x into 0 */
(simplify
diff --git a/gcc/testsuite/gcc.dg/pr101955.c b/gcc/testsuite/gcc.dg/pr101955.c
new file mode 100644
index 00000000000..8619661b291
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr101955.c
@@ -0,0 +1,63 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+
+__attribute__((noipa)) int
+t1 (int x)
+{
+ int y = x << 31;
+ int z = y >> 31;
+ return z;
+}
+
+__attribute__((noipa)) int
+t2 (unsigned int x)
+{
+ int y = x << 31;
+ int z = y >> 31;
+ return z;
+}
+
+__attribute__((noipa)) int
+t3 (int x)
+{
+ return (x << 31) >> 31;
+}
+
+__attribute__((noipa)) int
+t4 (int x)
+{
+ return (x << 24) >> 24;
+}
+
+__attribute__((noipa)) int
+t5 (int x)
+{
+ return (x << 16) >> 16;
+}
+
+__attribute__((noipa)) long long
+t6 (long long x)
+{
+ return (x << 63) >> 63;
+}
+
+__attribute__((noipa)) long long
+t7 (long long x)
+{
+ return (x << 56) >> 56;
+}
+
+__attribute__((noipa)) long long
+t8 (long long x)
+{
+ return (x << 48) >> 48;
+}
+
+__attribute__((noipa)) long long
+t9 (long long x)
+{
+ return (x << 32) >> 32;
+}
+
+/* { dg-final { scan-tree-dump-not " >> " "optimized" } } */
+/* { dg-final { scan-tree-dump-not " << " "optimized" } } */
--
2.39.3
next prev parent reply other threads:[~2023-08-01 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:08 [PATCH] match.pd: Implement missed optimization (x << c) >> c -> -(x & 1) [PR101955] Drew Ross
2023-07-21 17:27 ` Andrew Pinski
2023-07-22 6:09 ` Jeff Law
2023-07-24 7:16 ` Richard Biener
2023-07-24 19:29 ` Drew Ross
2023-07-24 19:42 ` Jakub Jelinek
2023-07-25 6:54 ` Richard Biener
2023-07-25 19:25 ` Drew Ross
2023-07-25 19:43 ` Jakub Jelinek
2023-07-26 8:39 ` Richard Biener
2023-07-26 18:18 ` Drew Ross
2023-07-28 6:30 ` Richard Biener
2023-08-01 19:20 ` Drew Ross [this message]
2023-08-01 21:36 ` [PATCH] match.pd: Canonicalize (signed x << c) >> c [PR101955] Jakub Jelinek
[not found] <20230801191657.432375-1-drross@redhat.com>
2023-08-01 19:18 ` Drew Ross
[not found] <20230802162143.447292-1-drross@redhat.com>
2023-08-02 16:23 ` Drew Ross
2023-08-04 7:10 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801192033.432742-1-drross@redhat.com \
--to=drross@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).