From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2127.outbound.protection.outlook.com [40.107.255.127]) by sourceware.org (Postfix) with ESMTPS id 383783858D1E for ; Thu, 3 Aug 2023 03:17:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 383783858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cipunited.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WB20IenJjUNy8yrDwX01LZAevRs0/6uOG4ZY1e8CX22u2Qw++iGRPZk9Fns8pTk07d7alVTMugqIGYHHlnaN0rtHPs3S5lOwNOetBzyezQH+GHVx/pXCs7EHoNZWw3T83qRewBQJls3esN0f/fCIrENBMhCE+WYXVg5QnRnOnaG5JC8FggeRbu4Ppjp2OiGKw+7soUbrMv48b2MNlUm+RpV9/9ncophz7vz4uxMGLqd38xmVInypVS1fnHekrEU6fEtk3FJXZG6sFj2JQTVv+pu8simmNMSffN3wdA22Qhpy+Q5PznswOTh5eJ7C3WPNE9i377ZiPmpuy8pEkn0kKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lAYlrJ+5hfPTSaozmu4D246BanpOcrq3uqNsyzWk1E=; b=AaFB6mrCsnXddYpdghv5RTAr3C3phKZ527IfREuALi0MXGCYULSFJHh6JitFyQpMp1r56j//lPRtAJpFVgrmDKrLt3Uj++Go23faeWkIFx9eMf7ULUiBJRi/0JhjoI/JXRzjcn7cRrbAzgu/ThgVMFwnw2Xzk7TnvJ/Ntsac560Rd+X7+LNctzi0oMgo+p2+APcHLkTt0s0LjDl7BBXng68q6pqFSmSOzlckSpn26yXO7Lb+2FxNlIE7eH7xNuUgWx/Pj3JZORzvLRE0kRLpitm0m5zeoN0eNd/4vEGwOH/g9Xiy3llO+aWOTsHxW7SI2XTsfC9vfeNpHEuF3IEUBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cipunited.com; dmarc=pass action=none header.from=cipunited.com; dkim=pass header.d=cipunited.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipunited.onmicrosoft.com; s=selector1-cipunited-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7lAYlrJ+5hfPTSaozmu4D246BanpOcrq3uqNsyzWk1E=; b=clnbfR75J6fMS4+e4bU2NBcgGsbBNI3n59LuW851hDPBQksBs8dtzSI3NdFeb6u1izshrO8EwngaP2wKJmehSRwBTwzTK+kDpcOBQprCkaij5oqOLhlEDhAuJH+nAiyQTu9UqEVM+4Ob/R2VjWLwpChsShv0q0LH9zuQv8Z4elg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cipunited.com; Received: from SEZPR04MB6121.apcprd04.prod.outlook.com (2603:1096:101:98::10) by TYSPR04MB7275.apcprd04.prod.outlook.com (2603:1096:400:471::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 3 Aug 2023 03:17:34 +0000 Received: from SEZPR04MB6121.apcprd04.prod.outlook.com ([fe80::584c:e7:eb86:8083]) by SEZPR04MB6121.apcprd04.prod.outlook.com ([fe80::584c:e7:eb86:8083%3]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 03:17:33 +0000 From: YunQiang Su To: gcc-patches@gcc.gnu.org Cc: pinskia@gmail.com, jeffreyalaw@gmail.com, ian@airs.com, rguenther@suse.de, botcazou@adacore.com, richard.sandiford@arm.com, tdevries@suse.de, thomas@codesourcery.com, julian@codesourcery.com, ams@codesourcery.com, macro@embecosm.com, YunQiang Su Subject: [RFC] Combine zero_extract and sign_extend for TARGET_TRULY_NOOP_TRUNCATION Date: Thu, 3 Aug 2023 11:17:13 +0800 Message-Id: <20230803031713.912298-1-yunqiang.su@cipunited.com> X-Mailer: git-send-email 2.30.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI1PR02CA0052.apcprd02.prod.outlook.com (2603:1096:4:1f5::20) To SEZPR04MB6121.apcprd04.prod.outlook.com (2603:1096:101:98::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR04MB6121:EE_|TYSPR04MB7275:EE_ X-MS-Office365-Filtering-Correlation-Id: bf1fe3fd-7219-4eef-5c21-08db93d02d74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IpAc9ILNrCxE8C3/AsMvHd9to58wuddt4pEbla06bB/V2Jst/Rr77zHoPbipiJSWahyd3WIbRAFbPyY/l3LdEPuzV4va1V/cpjKTbwOG4scCr5tiGdFbzNXWh2QzvCxMs9uS53RGS+5kTli9T/imC3t5ZAxfWgomEG5nJvS+y5ih5KW2l2wTSP+kU6NYVb/rfLl1WM1aMsrlixEjd+9vxCzpkdN3GW+Kx2YVvovUjYrx4uYhcN/RZTw7fn/BK9IpW4FSVyHVgMvEJgh45fetLEw8lCW3lCZ6hvceubtcl13DdwoTHtIW79TMk+kVLLq9erqxwPE1/rewE5J1spSA2BGrGuK85wKJHQjBKRr2ku5s2e/jYbSNZL+GdaDFvARNjOBuUDXa34W9t8j+RNIZmC4r/2UXcqu8twCYEx1lL1Kx97V8BSNFmTtbq8uzcgEnjMIVI3CMag1uyR/iyO4KtfMfRFbTNmATL9RbzfwlzQksNh4/fIavNjDqunB/NbSSV9Zh4EUGk5hvBRS31T9HyZaLGHdGtd6RK/a1uGC3kxFCAIgYLwlh8enhST8lSyYtG2jDs+0RgrChkx38WGNeRxn6hL9BrcoL2wuWM3JjikQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR04MB6121.apcprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(136003)(366004)(376002)(39830400003)(451199021)(36756003)(38100700002)(38350700002)(86362001)(84970400001)(316002)(186003)(6506007)(41300700001)(8676002)(5660300002)(26005)(7416002)(1076003)(107886003)(66946007)(8936002)(52116002)(2906002)(2616005)(83380400001)(478600001)(4326008)(66476007)(6486002)(6666004)(6916009)(66556008)(6512007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iu3gaLN09YC4c5x2A54DsZqPQPIFiLPM3aM5j0obBkt3SCuudtbLtcs38/XN?= =?us-ascii?Q?GY5I2wDlB9ZwBNd/V1SSFpDevNmdBZvP/CEt4szEpRRyYPQrH2JsEK7KIj/y?= =?us-ascii?Q?+lkRaFLplBIeQEd03x2GZ7+wtHux/SfayraIbOSrF8RKyjcOt4LC/nm3/QR0?= =?us-ascii?Q?CVsRwMIiGYGtO1+BRZjUZ9N6BvyVy7HtPy7kCruHsT3E4yu16dxHsHn5vWVA?= =?us-ascii?Q?yh6FpqVc41AQ6DAR8N6LNVh9oWcF+dzpEnIF2jDRLoIDf1UhSeQHInanGPBV?= =?us-ascii?Q?eCzD92YyouhrE2yxZQi+8gUBhsZvKu7shiGWbTkRm9Hw9VaVBQxVwi2OugWL?= =?us-ascii?Q?zDlFiisl9W8X/LjWihBffdK6MNY04Jt1tl8EBR7yf3tQVEsBZui8eE54+GMC?= =?us-ascii?Q?b1OXFtEA8W3IvGnj9ODBY0pyka/0mfuT3ck5fci0J9DDGw3BMyI0scVdjrpR?= =?us-ascii?Q?g2WIj4qoJXAAZGjuL5i9wLn5YkCRKmZSYJIUhIG7VrjGTPhz6FtnEIXB3AEj?= =?us-ascii?Q?U20gd3zPXnglgsG+ow94MkDfQfBTgbbUm0ZpbUKMSjGD1J3TzU0SCc4r7CO1?= =?us-ascii?Q?TtmW+QyUSEIg+6ATx+ABcWxjWP6WTXmr8GoCZJSlg7kZFG3obhs+kAIUvrjp?= =?us-ascii?Q?GiicyDIJwPlmW+IZlMlcyqBoj0BO3lWTBYX2eYWyr39geclF1oBxJwRwLoUM?= =?us-ascii?Q?1CFlI3f0pN3Yp9uGPoRx2th4wcy71wTd++O+901DGs9YdtcGRE7H6zCqHC6g?= =?us-ascii?Q?BorVEe/fZLz04sXSFZ/BZVBBZoIu0XBDVvNl48h5hYSj07PXsHoxXyvjcyVn?= =?us-ascii?Q?WmlnVU+46ISWVeKGAe5LQr+l91BFXLH3SilFfl8+llNkWSX3PjFxE22mBpY6?= =?us-ascii?Q?8pO8NoZ9DtcNsamLanITEdT1IB+aBUh1UyJ/WN4jI9cMVkmG1isw61qqALGy?= =?us-ascii?Q?IFkP0uzv+XEJsBqKZjhHVjjULDXjkJSn6Tml3RmbHSKXz8OzJWYPyczg6Sv9?= =?us-ascii?Q?ZgqxRFgtl2ChRJYLte0D5N5NmFZne9J6krAR7hXakcnqKdMkN+M6YoYlslHu?= =?us-ascii?Q?FRpDXcqbYUSwlLICi58+SEj/yZKc0kl14wnugCLbaXthgAjXAGM9/UAb7Sjv?= =?us-ascii?Q?SV9FdMH98p4NChUvGmKZLYOoibm+nFMgGnv2DQSDHnJqjDGti3GJ8/Luerii?= =?us-ascii?Q?YFFFobIgMnDj+GRC8X4bQfS05Sb6+5ydr+SG630BsPIu+wfnH4zzhYGxd8qq?= =?us-ascii?Q?vasfU1+ffHYC+5QEqwFwKjzTMBk4LRyK0wYc+pjIbs+Nhc6Xu5+eTylXgyL0?= =?us-ascii?Q?l9DjtZo3sxFMZOfylDB1HdBjaDEN2ruxEzQw/+A8hu/twlZrwLiFpyD9iglR?= =?us-ascii?Q?i99yGkRSnp8yB1jfCmin0lwL05OqDN/u4nPuQXwaOnYriNx3ZJrm4aBmd3H6?= =?us-ascii?Q?V2OfpGmhGZN4SlH7Bxvz+04Hw9iNoIKbhgiiN7IWC3FsW/ETQlrg0IOBhW6t?= =?us-ascii?Q?GqoRT2TuR0Jtm0JIIF/eG9oT5aD1PMrdgBOMPeMG3DQoRECbe7EZPfs99DxW?= =?us-ascii?Q?aexwXFV4m1BOdR8ZYueEt8lY7d/J3iWLbPPVPY9FeWSoJN5XBXI+aBHKJmaP?= =?us-ascii?Q?fQ=3D=3D?= X-OriginatorOrg: cipunited.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf1fe3fd-7219-4eef-5c21-08db93d02d74 X-MS-Exchange-CrossTenant-AuthSource: SEZPR04MB6121.apcprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 03:17:33.1280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e31cf5b5-ee69-4d5f-9c69-edeeda2458c0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1fWj/yUzgTJFX+AcSARB2ZqM+jfTlWlu2aR+XfyFvckEnwvyaTLecPClbZvN2ipiIW+U/XKl8Dpq53gQTACDOm/9SThOcPsHLYJIYZCO6P4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR04MB7275 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PR #104914 On TRULY_NOOP_TRUNCATION_MODES_P (DImode, SImode)) == true platforms, zero_extract (SI, SI) can be sign-extended. So, if a zero_extract (DI, DI) following with an sign_extend(SI, DI) can be merged to a single zero_extract (SI, SI). gcc/ChangeLog: PR: 104914. * combine.cc (try_combine): Combine zero_extract (DI, DI) and following sign_extend (DI, SI) for TRULY_NOOP_TRUNCATION_MODES_P (DImode, SImode)) == true. (subst): Allow replacing reg(DI) with subreg(SI (reg DI)) if to is SImode and from is DImode for TRULY_NOOP_TRUNCATION_MODES_P (DImode, SImode)) == true. gcc/testsuite/ChangeLog: PR: 104914. * gcc.target/mips/pr104914.c: New testcase. --- gcc/combine.cc | 88 ++++++++++++++++++++---- gcc/testsuite/gcc.target/mips/pr104914.c | 17 +++++ 2 files changed, 90 insertions(+), 15 deletions(-) create mode 100644 gcc/testsuite/gcc.target/mips/pr104914.c diff --git a/gcc/combine.cc b/gcc/combine.cc index e46d202d0a7..701b7c33b17 100644 --- a/gcc/combine.cc +++ b/gcc/combine.cc @@ -3294,15 +3294,64 @@ try_combine (rtx_insn *i3, rtx_insn *i2, rtx_insn *i1, rtx_insn *i0, n_occurrences = 0; /* `subst' counts here */ subst_low_luid = DF_INSN_LUID (i2); - /* If I1 feeds into I2 and I1DEST is in I1SRC, we need to make a unique - copy of I2SRC each time we substitute it, in order to avoid creating - self-referential RTL when we will be substituting I1SRC for I1DEST - later. Likewise if I0 feeds into I2, either directly or indirectly - through I1, and I0DEST is in I0SRC. */ - newpat = subst (PATTERN (i3), i2dest, i2src, false, false, - (i1_feeds_i2_n && i1dest_in_i1src) - || ((i0_feeds_i2_n || (i0_feeds_i1_n && i1_feeds_i2_n)) - && i0dest_in_i0src)); + /* Try to combine zero_extract (DImode) and sign_extend (SImode to DImode) + for TARGET_TRULY_NOOP_TRUNCATION. The RTL may look like: + + (insn 10 49 11 2 (set (zero_extract:DI (reg/v:DI 200 [ val ]) + (const_int 8 [0x8]) + (const_int 0 [0])) + (subreg:DI (reg:QI 202 [ *buf_8(D) ]) 0)) "xx.c":4:29 278 {*insvdi} + (expr_list:REG_DEAD (reg:QI 202 [ *buf_8(D) ]) (nil))) + (insn 11 10 12 2 (set (reg/v:DI 200 [ val ]) + + (sign_extend:DI (subreg:SI (reg/v:DI 200 [ val ]) 0))) 238 {extendsidi2} + (nil)) + + Since these architectures (MIPS64 as an example), the 32bit operation + instructions will sign-extend the reuslt to 64bit. The result can be: + + (insn 10 49 11 2 (set (zero_extract:SI (subreg:SI (reg/v:DI 200 [ val ]) 0) + (const_int 8 [0x8]) + (const_int 0 [0])) + (subreg:SI (reg:QI 202 [ *buf_8(D) ]) 0)) "xx.c":4:29 280 {*insvsi} + (expr_list:REG_DEAD (reg:QI 202 [ *buf_8(D) ]) (nil))) + */ + if (i0 == 0 && i1 == 0 && i3 != 0 && i2 != 0 && GET_CODE (i2) == INSN + && GET_CODE (i3) == INSN && GET_CODE (PATTERN (i2)) == SET + && GET_CODE (PATTERN (i3)) == SET + && GET_CODE (SET_DEST (single_set (i2))) == ZERO_EXTRACT + && GET_CODE (SET_SRC (single_set (i3))) == SIGN_EXTEND + && SUBREG_P (XEXP (SET_SRC (single_set (i3)), 0)) + && REGNO (SUBREG_REG (XEXP (SET_SRC (single_set (i3)), 0))) + == REGNO (SET_DEST (single_set (i3))) + && REGNO (XEXP (SET_DEST (single_set (i2)), 0)) + == REGNO (SET_DEST (single_set (i3))) + && GET_MODE (SET_DEST (single_set (i2))) == DImode + && GET_MODE (SET_DEST (single_set (i3))) == DImode + && GET_MODE (XEXP (SET_SRC (single_set (i3)), 0)) == SImode + && TRULY_NOOP_TRUNCATION_MODES_P (DImode, SImode)) + { + newpat = copy_rtx (PATTERN (i2)); + PUT_MODE (SET_DEST (newpat), SImode); + PUT_MODE (SET_SRC (newpat), SImode); + + rtx i2dest_r = XEXP (SET_DEST (newpat), 0); + rtx i3src_r = XEXP (SET_SRC (single_set (i3)), 0); + newpat = subst (newpat, i2dest_r, i3src_r, false, false, false); + } + else + { + /* If I1 feeds into I2 and I1DEST is in I1SRC, we need to make a + unique copy of I2SRC each time we substitute it, in order to + avoid creating self-referential RTL when we will be substituting + I1SRC for I1DEST later. Likewise if I0 feeds into I2, either + directly or indirectly through I1, and I0DEST is in I0SRC. */ + newpat = subst ( + PATTERN (i3), i2dest, i2src, false, false, + (i1_feeds_i2_n && i1dest_in_i1src) + || ((i0_feeds_i2_n || (i0_feeds_i1_n && i1_feeds_i2_n)) + && i0dest_in_i0src)); + } substed_i2 = true; /* Record whether I2's body now appears within I3's body. */ @@ -5482,13 +5531,22 @@ subst (rtx x, rtx from, rtx to, bool in_dest, bool in_cond, bool unique_copy) } else if (fmt[i] == 'e') { - /* If this is a register being set, ignore it. */ new_rtx = XEXP (x, i); - if (in_dest - && i == 0 - && (((code == SUBREG || code == ZERO_EXTRACT) - && REG_P (new_rtx)) - || code == STRICT_LOW_PART)) + /* Allow replacing reg with subreg if it is sign extension. */ + if (in_dest && (code == SUBREG || code == ZERO_EXTRACT) + && TRULY_NOOP_TRUNCATION_MODES_P (DImode, SImode) + && GET_MODE (from) == DImode && GET_MODE (to) == SImode + && i == 0) + { + new_rtx + = (unique_copy && n_occurrences ? copy_rtx (to) : to); + n_occurrences++; + } + /* If this is a register being set, ignore it. */ + else if (in_dest && i == 0 + && (((code == SUBREG || code == ZERO_EXTRACT) + && REG_P (new_rtx)) + || code == STRICT_LOW_PART)) ; else if (COMBINE_RTX_EQUAL_P (XEXP (x, i), from)) diff --git a/gcc/testsuite/gcc.target/mips/pr104914.c b/gcc/testsuite/gcc.target/mips/pr104914.c new file mode 100644 index 00000000000..fd6ef6af446 --- /dev/null +++ b/gcc/testsuite/gcc.target/mips/pr104914.c @@ -0,0 +1,17 @@ +/* { dg-do compile } */ +/* { dg-options "-march=mips64r2 -mabi=64" } */ + +/* { dg-final { scan-assembler-not "\tdins\t" } } */ + +NOMIPS16 int test (const unsigned char *buf) +{ + int val; + ((unsigned char*)&val)[0] = *buf++; + ((unsigned char*)&val)[1] = *buf++; + ((unsigned char*)&val)[2] = *buf++; + ((unsigned char*)&val)[3] = *buf++; + if(val > 0) + return 1; + else + return 0; +} -- 2.30.2