From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2F6DC385703C for ; Thu, 10 Aug 2023 16:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F6DC385703C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691683745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x8xRqy5RYMFdjV3ucJbMH7wVKShoWie2RR7qVRVmPdg=; b=Q52CJlzynXDpVMgBRGq5GNh9MziatVxFFGlOisBfQYTMhjtTMJOwA4yiHIGPRLkDGePY/q LHWY21Kbkl+y5cEfBKgTZC9t5PuCol3isnMESQ8qDK7jmumnH8BjVeT4FIp+f6eMR3L3D2 8NZDLNMdZp95Uot4w8XgE7mZFLs6jrs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-fZX34gQHNheVI6Vt1FOw4w-1; Thu, 10 Aug 2023 12:09:04 -0400 X-MC-Unique: fZX34gQHNheVI6Vt1FOw4w-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-63d0c38e986so11851176d6.1 for ; Thu, 10 Aug 2023 09:09:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691683743; x=1692288543; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x8xRqy5RYMFdjV3ucJbMH7wVKShoWie2RR7qVRVmPdg=; b=bCoXFe5GtoOzsTUaeF/PBcyD68IjgBvgifPO+onu5YibSTVrDs4ehvA3R4m+W0Z0EC 6ifE014r3pmZg+PmBqcoHcLcPKtol7KZq1GpvP36wXgBKwA1j6lF98a4iIXHZbKKf1fW LwIkGg9R7LQuW4VMwRhhmCYjNlWiv0DRJ/KiRiP6WVYApI+zMNFDvS24yxUXyZa1GcX8 aQOdiNGQ299zQndCG0NqTwmDZvcB6AZaowKf4PnwoMxt+CStTJBna9rmAs26SZoy/m+y IXBOtdF4HC+TecBXPhQQOTLGG8uFVv+D2iw7MJFHCdPFkukNe9K3uqECLcm6/LJeE0UU sd/w== X-Gm-Message-State: AOJu0YwGPuSHrhH6gE5DEcHr1d54nsdkvM37qGKgR9T7efpb03o5fhjH SJPRlNm0d6ekKFrw+oF1bRlT8q4KRcssRkfOcksT4dqjkj2hQHSbWd3sUOBlps4XxjBHaDEFv6L NbAT8jHVCsTPQgEZdGQUYkVA3SGVYseMdHO/OkmRHoOkoQ8a75/WR7tIrnGOWmaS93gGEUh6giK k= X-Received: by 2002:a05:6214:1043:b0:63f:a4be:d799 with SMTP id l3-20020a056214104300b0063fa4bed799mr2599555qvr.18.1691683743286; Thu, 10 Aug 2023 09:09:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhVfVyrM3Yj4F4p5g8l7/yz+utWJC9zcpfSkuzW43R3vgmIyi/Ed9661ZZU2u7StWJPRs0VA== X-Received: by 2002:a05:6214:1043:b0:63f:a4be:d799 with SMTP id l3-20020a056214104300b0063fa4bed799mr2599526qvr.18.1691683742847; Thu, 10 Aug 2023 09:09:02 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id h2-20020a0cf202000000b006300e1db3ecsm381284qvk.141.2023.08.10.09.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 09:09:02 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, Patrick Palka Subject: [PATCH] c++: bogus warning w/ deduction guide in anon ns [PR106604] Date: Thu, 10 Aug 2023 12:09:00 -0400 Message-ID: <20230810160900.1513252-1-ppalka@redhat.com> X-Mailer: git-send-email 2.42.0.rc0.25.ga82fb66fed MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Booststrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk and perhaps 13? -- >8 -- We shouldn't issue a "declared static but never defined" warning for a deduction guide (declared in an anonymous namespace). PR c++/106604 gcc/cp/ChangeLog: * decl.cc (wrapup_namespace_globals): Don't issue a -Wunused-function warning for a deduction guide. gcc/testsuite/ChangeLog: * g++.dg/cpp1z/class-deduction116.C: New test. --- gcc/cp/decl.cc | 1 + gcc/testsuite/g++.dg/cpp1z/class-deduction116.C | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 gcc/testsuite/g++.dg/cpp1z/class-deduction116.C diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc index 792ab330dd0..9fe3a0b98fd 100644 --- a/gcc/cp/decl.cc +++ b/gcc/cp/decl.cc @@ -856,6 +856,7 @@ wrapup_namespace_globals () && !TREE_PUBLIC (decl) && !DECL_ARTIFICIAL (decl) && !DECL_FRIEND_PSEUDO_TEMPLATE_INSTANTIATION (decl) + && !deduction_guide_p (decl) && !warning_suppressed_p (decl, OPT_Wunused_function)) warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wunused_function, diff --git a/gcc/testsuite/g++.dg/cpp1z/class-deduction116.C b/gcc/testsuite/g++.dg/cpp1z/class-deduction116.C new file mode 100644 index 00000000000..00f6d5fef41 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/class-deduction116.C @@ -0,0 +1,8 @@ +// PR c++/106604 +// { dg-do compile { target c++17 } } +// { dg-additional-options "-Wunused-function" } + +namespace { + template struct A { A(...); }; + A(bool) -> A; // { dg-bogus "never defined" } +} -- 2.42.0.rc0.25.ga82fb66fed