From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: hongtao.liu@intel.com, hjl.tools@gmail.com
Subject: [PATCH] Fix FAIL: gcc.target/i386/pr87007-5.c
Date: Mon, 21 Aug 2023 12:24:55 +0000 (UTC) [thread overview]
Message-ID: <20230821122455.jT2Om_mRD-7OGlbP-ObZUXuU4rRUD73Y4Ch45d2VQVg@z> (raw)
The following fixes the gcc.target/i386/pr87007-5.c testcase which
changed code generation again after the recent sinking improvements.
We now have
vxorps %xmm0, %xmm0, %xmm0
vsqrtsd d2(%rip), %xmm0, %xmm0
and an unnecessary xor again in one case, the other vsqrtsd has
a register source and a properly zeroing load:
vmovsd d3(%rip), %xmm0
testl %esi, %esi
jg .L11
.L3:
vsqrtsd %xmm0, %xmm0, %xmm0
the following patch XFAILs the scan. I'm not sure what's at
fault here, there are no loops in the CFG, but somehow
r84:DF=sqrt(['d2']) gets a pxor but r84:DF=sqrt(r83:DF)
doesn't. I guess I don't really understand what
remove_partial_avx_dependency is supposed to do so can't
really assess whether the pxor is necessary or not.
OK?
* gcc.target/i386/pr87007-5.c: Update comment, XFAIL
subtest.
---
gcc/testsuite/gcc.target/i386/pr87007-5.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr87007-5.c b/gcc/testsuite/gcc.target/i386/pr87007-5.c
index a6cdf11522e..5902616d1f1 100644
--- a/gcc/testsuite/gcc.target/i386/pr87007-5.c
+++ b/gcc/testsuite/gcc.target/i386/pr87007-5.c
@@ -1,6 +1,8 @@
/* { dg-do compile } */
/* { dg-options "-Ofast -march=skylake-avx512 -mfpmath=sse -fno-tree-vectorize -fdump-tree-cddce3-details -fdump-tree-lsplit-optimized" } */
-/* Load of d2/d3 is hoisted out, vrndscalesd will reuse loades register to avoid partial dependence. */
+/* Load of d2/d3 is hoisted out, the loop is split, store of d1 and sqrt
+ are sunk out of the loop and the loop is elided. One vsqrtsd with
+ memory operand will need a xor to avoid partial dependence. */
#include<math.h>
@@ -17,4 +19,4 @@ foo (int n, int k)
/* { dg-final { scan-tree-dump "optimized: loop split" "lsplit" } } */
/* { dg-final { scan-tree-dump-times "removing loop" 2 "cddce3" } } */
-/* { dg-final { scan-assembler-times "vxorps\[^\n\r\]*xmm\[0-9\]" 0 } } */
+/* { dg-final { scan-assembler-times "vxorps\[^\n\r\]*xmm\[0-9\]" 1 } } */
--
2.35.3
next reply other threads:[~2023-08-21 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 12:24 Richard Biener [this message]
[not found] <20230821122515.5A627385697D@sourceware.org>
2023-08-21 12:40 ` Hongtao Liu
2023-08-21 12:41 ` Hongtao Liu
2023-08-21 12:59 ` Richard Biener
2023-08-21 13:08 ` Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821122455.jT2Om_mRD-7OGlbP-ObZUXuU4rRUD73Y4Ch45d2VQVg@z \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hongtao.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).