From: Edwin Lu <ewlu@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] RISC-V: Add Types to Un-Typed Sync Instructions:
Date: Tue, 22 Aug 2023 07:42:52 -0700 [thread overview]
Message-ID: <f0da8eb9-b493-43b8-b2f8-7c96041ffc8d@rivosinc.com> (raw)
Message-ID: <20230822144252.yDSkma3YAar512ZV5chI70O6t2riUr4ZWZakvEFIOl8@z> (raw)
In-Reply-To: <c9de76c6-f870-39d1-1a2c-a5fef62ac43a@gmail.com>
On 8/21/2023 2:41 PM, Jeff Law via Gcc-patches wrote:
>
>
> On 8/21/23 10:51, Edwin Lu wrote:
>> @@ -77,4 +78,4 @@ (define_insn "atomic_store_ztso<mode>"
>> return "s<amo>\t%z1,%0";
>> }
>> [(set_attr "type" "atomic")
>> - (set (attr "length") (const_int 8))])
>> \ No newline at end of file
>> + (set (attr "length") (const_int 8))])
> This raises a question. We're likely better off using "multi" for a
> define_insn which generates multiple instructions.
That makes sense to me.
>
> Can you respin changing atomic to multi for those cases where we're
> generating more than one instruction out of a define_insn?
>
Thanks for the feedback! I'll update those instructions with "multi".
Edwin Lu
next prev parent reply other threads:[~2023-08-22 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 16:51 Edwin Lu
2023-08-21 21:41 ` Jeff Law
2023-08-22 14:42 ` Edwin Lu [this message]
2023-08-22 14:42 ` Edwin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0da8eb9-b493-43b8-b2f8-7c96041ffc8d@rivosinc.com \
--to=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).