From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 481A9385B81D for ; Tue, 22 Aug 2023 18:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 481A9385B81D Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qYWNV-0001mC-Tn for gcc-patches@gcc.gnu.org; Tue, 22 Aug 2023 20:45:21 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH] Fortran: implement vector sections in DATA statements [PR49588] Date: Tue, 22 Aug 2023 20:45:15 +0200 Message-ID: <32a1acd3-11c6-4692-a940-87f343c862f4@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230822184515.bqTiZMyVPUbJWK62gUS5MtdjjHccMzY1Jp4ZgKv6WAg@z> Hi Paul, Am 22.08.23 um 08:32 schrieb Paul Richard Thomas via Gcc-patches: > Hi Harald, > > It all looks good to me and does indeed make the code clearer. OK for trunk. > > Thanks for the patch. thanks for the review! > I was shocked to find that there are 217 older bugs than 49588. Does > anybody test older bugs to check if any of them have been fixed? I am not aware of this being done systematically. At the same time, we have over 100 PRs marked as regression, with a few being fixed on mainline but not backported (or undecided whether to backport). Fixing and/or closing them might be low-hanging fruits. There are also far more than 100 TODOs in gcc/fortran/*.cc ... And with the usual PRs, there's enough work left for all kinds of contributions. Cheers, Harald > Paul > > On Mon, 21 Aug 2023 at 20:48, Harald Anlauf via Fortran > wrote: >> >> Dear all, >> >> the attached patch implements vector sections in DATA statements. >> >> The implementation is simpler than the size of the patch suggests, >> as part of changes try to clean up the existing code to make it >> easier to understand, as ordinary sections (start:end:stride) >> and vector sections may actually share some common code. >> >> The basisc idea of the implementation is that one needs a >> temporary vector that keeps track of the offsets into the >> array constructors for the indices in the array reference >> that are vectors. >> >> Regtested on x86_64-pc-linux-gnu. OK for mainline? >> >> Thanks, >> Harald >> >