From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id 3D43D3858C53 for ; Fri, 25 Aug 2023 01:20:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D43D3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1692926418; x=1724462418; h=from:to:cc:in-reply-to:subject:mime-version: content-transfer-encoding:references:message-id:date; bh=bcBa8ahFo8swUokXBzjb40lEObQ7NCEYeKD5WFNdNg4=; b=PwpEuZ+kU+4gutQ3iSwtOYjXkYHFlFRj/SHwBYHeCZKhS0lasXDXci2o Mp7hdzrjsdsf0O+IcLazJNLeLoM/FIWOpfD1invq1TScDFe68zLxb+IRi ptulAUY0dMylJvWycqAhsIkxK2wuEVJlZxNSoB/tbSiQz18rtVqA95A5+ VzxKNUSphR31Vow+4H2aQ3m4RG2FXU9oRdX2/KQ7cmplAm1KkfR5Dp2qo +1iAGUeCtS3cSisqlGYmuLGzv/yvf4QleJhw/LKO7FpZoed2CmeXF77i9 TTxO/oJFXiaF7NerFeKnOSh/CO0rjARaJpqNA7wJKSpkfeY3ocKFn6RuF w==; From: Hans-Peter Nilsson To: Jan Hubicka CC: , In-Reply-To: (message from Jan Hubicka via Gcc-patches on Wed, 23 Aug 2023 11:10:02 +0200) Subject: Re: Fix profile update in tree-ssa-reassoc MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: Message-ID: <20230825012015.B14D92042E@pchp3.se.axis.com> Date: Fri, 25 Aug 2023 03:20:15 +0200 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Wed, 23 Aug 2023 11:10:02 +0200 > From: Jan Hubicka via Gcc-patches > Hi, > this patch adds missing profile update to maybe_optimize_range_tests. [...] > Jakub, it seems that the code is originally yours. Any idea why those are not turned to > constant true or false conditionals? > > Bootstrapped/regtested x86_64-linux, does it seem to make sense? > > gcc/ChangeLog: > > PR tree-optimization/110628 > * tree-ssa-reassoc.cc (maybe_optimize_range_tests): Add profile update. Hi. Feeling somewhat guilty for not noticing that you had posted a patch before me xfailing it, I went ahead and tested this patch for cris-elf against r14-3431-g7e05cd632fab, but unfortunately it regresses a few tests, and it appears it's not just testcase (dumps) that need tweaking. Four test-cases regress (counting multiple runs as just one): Running /x/gcc/gcc/testsuite/gcc.c-torture/execute/execute.exp ... FAIL: gcc.c-torture/execute/pr95731.c -O1 execution test FAIL: gcc.c-torture/execute/pr95731.c -O2 execution test FAIL: gcc.c-torture/execute/pr95731.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions execution test FAIL: gcc.c-torture/execute/pr95731.c -O3 -g execution test FAIL: gcc.c-torture/execute/pr95731.c -Os execution test FAIL: gcc.c-torture/execute/pr95731.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test FAIL: gcc.c-torture/execute/pr95731.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test ... Running /x/gcc/gcc/testsuite/gcc.dg/dg.exp ... FAIL: gcc.dg/pr46309-2.c scan-tree-dump-times reassoc2 "Optimizing range tests [^\r\n]*_[0-9]* -.0, 0. and -.128, 128.[\n\r]* into" 1 ... Running /x/gcc/gcc/testsuite/gcc.dg/torture/dg-torture.exp ... FAIL: gcc.dg/torture/pr63464.c -Os execution test ... Running /x/gcc/gcc/testsuite/gcc.dg/tree-ssa/tree-ssa.exp ... ... FAIL: gcc.dg/tree-ssa/pr95731.c scan-tree-dump-times optimized " >= 0| < 0" 6 brgds, H-P