From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by sourceware.org (Postfix) with ESMTPS id AD6CE3858431 for ; Fri, 25 Aug 2023 16:21:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD6CE3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=marvell.com Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37P3ctgY001856 for ; Fri, 25 Aug 2023 09:21:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=0pi8+bXh4QykL0rv4jS1Rn3T/uTm6Js02e5y+iu0bs0=; b=fQOOQ7WXkti5jcCN9gjtE5mjJXS/Umi8BSXGZHNINxTFYNNebpYH7meu4FODTrmVwr6D LTQ/srHyuoby0l/7uMzfXUoVSxYSIto8XbyEWTeyBAIiHAp6OvOxIJb7qw17uNrlDrBt T7IOHxVmGU0Gjvo8Zgze2jRfclV/00rPmx4MqzwMvR/j6qJUhEzk9bfns4H+5WBZWdnA T93uoKkoVqA7SEQf1thNpmOq5iWQmnxIOl6YRXR0NpyRQOSwS+fTTg+DLSaB7NlJJMVy 0TjeBSGcmWz5vUEVJfKrdwl8FP1IzgE9IkwdxNoXalEMrcRxxBqMjkGKWJToIm7jYhMF 5Q== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3spmk2a1q8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 25 Aug 2023 09:21:44 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 25 Aug 2023 09:21:42 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 25 Aug 2023 09:21:42 -0700 Received: from vpnclient.wrightpinski.org.com (unknown [10.69.242.187]) by maili.marvell.com (Postfix) with ESMTP id 561A63F7093; Fri, 25 Aug 2023 09:21:42 -0700 (PDT) From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH] MATCH: Move `(X & ~Y) | (~X & Y)` over to use bitwise_inverted_equal_p Date: Fri, 25 Aug 2023 09:21:22 -0700 Message-ID: <20230825162122.3599370-1-apinski@marvell.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: t1h5LLKiTKMBLWua4fw-UbwqxMjJUl5G X-Proofpoint-GUID: t1h5LLKiTKMBLWua4fw-UbwqxMjJUl5G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-25_14,2023-08-25_01,2023-05-22_02 X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This moves the pattern `(X & ~Y) | (~X & Y)` to use bitwise_inverted_equal_p so we can simplify earlier the case where X and Y are defined by comparisons. We were able to optimize to (!X)^(!Y) in the end due to the pattern added in r14-3110-g7fb65f102851248bafa0815 and the older pattern r13-4620-g4d9db4bdd458 . But folding it earlier is better. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. Note pr87009.c now gets `return x ^ s; in one case where the test had been expecting `return s ^ x;` both are valid and would be expectly the same; just we now chose a slightly different order of simplification which causes the order of the operands to be different. gcc/ChangeLog: * match.pd (`(X & ~Y) | (~X & Y)`): Use bitwise_inverted_equal_p instead of specifically checking for ~X. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/cmpbit-3.c: New test. * gcc.dg/pr87009.c: Update test. --- gcc/match.pd | 13 +++++----- gcc/testsuite/gcc.dg/pr87009.c | 2 +- gcc/testsuite/gcc.dg/tree-ssa/cmpbit-3.c | 33 ++++++++++++++++++++++++ 3 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/cmpbit-3.c diff --git a/gcc/match.pd b/gcc/match.pd index 70884bd48eb..e41403664d0 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -1228,12 +1228,13 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) /* Simplify (X & ~Y) |^+ (~X & Y) -> X ^ Y. */ (for op (bit_ior bit_xor plus) (simplify - (op (bit_and:c @0 (bit_not @1)) (bit_and:c (bit_not @0) @1)) - (bit_xor @0 @1)) - (simplify - (op:c (bit_and @0 INTEGER_CST@2) (bit_and (bit_not @0) INTEGER_CST@1)) - (if (~wi::to_wide (@2) == wi::to_wide (@1)) - (bit_xor @0 @1)))) + (op (bit_and:c @0 @2) (bit_and:c @3 @1)) + (with { bool wascmp0, wascmp1; } + (if (bitwise_inverted_equal_p (@2, @1, wascmp0) + && bitwise_inverted_equal_p (@0, @3, wascmp1) + && ((!wascmp0 && !wascmp1) + || element_precision (type) == 1)) + (bit_xor @0 @1))))) /* PR53979: Transform ((a ^ b) | a) -> (a | b) */ (simplify diff --git a/gcc/testsuite/gcc.dg/pr87009.c b/gcc/testsuite/gcc.dg/pr87009.c index eb8a4ecd920..6f0341d17cc 100644 --- a/gcc/testsuite/gcc.dg/pr87009.c +++ b/gcc/testsuite/gcc.dg/pr87009.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O -fdump-tree-original" } */ -/* { dg-final { scan-tree-dump-times "return s \\^ x;" 4 "original" } } */ +/* { dg-final { scan-tree-dump-times "return s \\^ x;|return x \\^ s;" 4 "original" } } */ int f1 (int x, int s) { diff --git a/gcc/testsuite/gcc.dg/tree-ssa/cmpbit-3.c b/gcc/testsuite/gcc.dg/tree-ssa/cmpbit-3.c new file mode 100644 index 00000000000..936c0934a10 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/cmpbit-3.c @@ -0,0 +1,33 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-optimized-raw -fdump-tree-dse1-raw -fdump-tree-forwprop1" } */ + +_Bool f(int a, int b) +{ + _Bool X = a==1, Y = b == 2; +return (X & !Y) | (!X & Y); +} + + +_Bool f1(int a, int b) +{ + _Bool X = a==1, Y = b == 2; + _Bool c = (X & !Y); + _Bool d = (!X & Y); + return c | d; +} + +/* Both of these should be optimized to (a==1) ^ (b==2) or (a != 1) ^ (b != 2) */ +/* { dg-final { scan-tree-dump-not "gimple_cond " "optimized" } } */ +/* { dg-final { scan-tree-dump-not "gimple_phi " "optimized" } } */ +/* { dg-final { scan-tree-dump-times "ne_expr|eq_expr, " 4 "optimized" } } */ +/* { dg-final { scan-tree-dump-times "bit_xor_expr, " 2 "optimized" } } */ +/* { dg-final { scan-tree-dump-times "gimple_assign " 6 "optimized" } } */ + +/* Both of these should be optimized early in the pipeline after forwprop1 */ +/* { dg-final { scan-tree-dump-times "ne_expr|eq_expr, " 4 "forwprop1" { xfail *-*-* } } } */ +/* { dg-final { scan-tree-dump-times "bit_xor_expr, " 2 "forwprop1" { xfail *-*-* } } } */ +/* { dg-final { scan-tree-dump-times "gimple_assign " 6 "forwprop1" { xfail *-*-* } } } */ +/* Note forwprop1 does not remove all unused statements sometimes so test dse1 also. */ +/* { dg-final { scan-tree-dump-times "ne_expr|eq_expr, " 4 "dse1" } } */ +/* { dg-final { scan-tree-dump-times "bit_xor_expr, " 2 "dse1" } } */ +/* { dg-final { scan-tree-dump-times "gimple_assign " 6 "dse1" } } */ -- 2.31.1