* [PATCH] Bug 111071: fix the subr with -1 to not due to the simplify.
@ 2023-08-30 1:09 yanzhang.wang
2023-09-04 15:21 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: yanzhang.wang @ 2023-08-30 1:09 UTC (permalink / raw)
To: gcc-patches
Cc: juzhe.zhong, kito.cheng, jeffreyalaw, apinski, thiago.bauermann,
pan2.li, yanzhang.wang
From: Yanzhang Wang <yanzhang.wang@intel.com>
gcc/testsuite/ChangeLog:
* gcc.target/aarch64/sve/acle/asm/subr_s8.c: Modify subr with -1
to not.
Signed-off-by: Yanzhang Wang <yanzhang.wang@intel.com>
---
Tested on my local arm environment and passed. Thanks Andrew Pinski's comment
the code is the same with that.
gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
index b9615de6655..1cf6916a5e0 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
@@ -76,8 +76,7 @@ TEST_UNIFORM_Z (subr_1_s8_m_untied, svint8_t,
/*
** subr_m1_s8_m:
-** mov (z[0-9]+\.b), #-1
-** subr z0\.b, p0/m, z0\.b, \1
+** not z0.b, p0/m, z0.b
** ret
*/
TEST_UNIFORM_Z (subr_m1_s8_m, svint8_t,
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Bug 111071: fix the subr with -1 to not due to the simplify.
2023-08-30 1:09 [PATCH] Bug 111071: fix the subr with -1 to not due to the simplify yanzhang.wang
@ 2023-09-04 15:21 ` Richard Sandiford
2023-09-04 18:59 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2023-09-04 15:21 UTC (permalink / raw)
To: yanzhang.wang--- via Gcc-patches
Cc: yanzhang.wang, apinski, juzhe.zhong, kito.cheng
"yanzhang.wang--- via Gcc-patches" <gcc-patches@gcc.gnu.org> writes:
> From: Yanzhang Wang <yanzhang.wang@intel.com>
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/sve/acle/asm/subr_s8.c: Modify subr with -1
> to not.
>
> Signed-off-by: Yanzhang Wang <yanzhang.wang@intel.com>
> ---
>
> Tested on my local arm environment and passed. Thanks Andrew Pinski's comment
> the code is the same with that.
>
> gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
> index b9615de6655..1cf6916a5e0 100644
> --- a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
> +++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
> @@ -76,8 +76,7 @@ TEST_UNIFORM_Z (subr_1_s8_m_untied, svint8_t,
>
> /*
> ** subr_m1_s8_m:
> -** mov (z[0-9]+\.b), #-1
> -** subr z0\.b, p0/m, z0\.b, \1
> +** not z0.b, p0/m, z0.b
> ** ret
> */
> TEST_UNIFORM_Z (subr_m1_s8_m, svint8_t,
I think we need this for subr_u8.c too. OK with that change,
and thanks for the fix!
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bug 111071: fix the subr with -1 to not due to the simplify.
2023-09-04 15:21 ` Richard Sandiford
@ 2023-09-04 18:59 ` Richard Sandiford
0 siblings, 0 replies; 3+ messages in thread
From: Richard Sandiford @ 2023-09-04 18:59 UTC (permalink / raw)
To: yanzhang.wang--- via Gcc-patches
Cc: yanzhang.wang, apinski, juzhe.zhong, kito.cheng
Richard Sandiford <richard.sandiford@arm.com> writes:
> "yanzhang.wang--- via Gcc-patches" <gcc-patches@gcc.gnu.org> writes:
>> From: Yanzhang Wang <yanzhang.wang@intel.com>
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/aarch64/sve/acle/asm/subr_s8.c: Modify subr with -1
>> to not.
>>
>> Signed-off-by: Yanzhang Wang <yanzhang.wang@intel.com>
>> ---
>>
>> Tested on my local arm environment and passed. Thanks Andrew Pinski's comment
>> the code is the same with that.
>>
>> gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
>> index b9615de6655..1cf6916a5e0 100644
>> --- a/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
>> +++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/asm/subr_s8.c
>> @@ -76,8 +76,7 @@ TEST_UNIFORM_Z (subr_1_s8_m_untied, svint8_t,
>>
>> /*
>> ** subr_m1_s8_m:
>> -** mov (z[0-9]+\.b), #-1
>> -** subr z0\.b, p0/m, z0\.b, \1
>> +** not z0.b, p0/m, z0.b
>> ** ret
>> */
>> TEST_UNIFORM_Z (subr_m1_s8_m, svint8_t,
>
> I think we need this for subr_u8.c too. OK with that change,
> and thanks for the fix!
Actually, never mind. I just saw a patch from Thiago Jung Bauerman
for the same issue, which is now in trunk. Sorry for the confusion,
and thanks again for posting the fix.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-04 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 1:09 [PATCH] Bug 111071: fix the subr with -1 to not due to the simplify yanzhang.wang
2023-09-04 15:21 ` Richard Sandiford
2023-09-04 18:59 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).