From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id C4AA23858D37 for ; Fri, 1 Sep 2023 13:41:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4AA23858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-31768ce2e81so1679149f8f.1 for ; Fri, 01 Sep 2023 06:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693575673; x=1694180473; darn=gcc.gnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cdsNDQ4V8xxhan38cy25TKR9z7v2iP3L4/Xs3jT4NNQ=; b=lQq5k++zr3+s5hk71U1Z4Y/CxOWtm0kN3sB1oMlL3nsvAgOPfQT2GxgvDvOyX5HWBv Fz3XgeneXHa1PxvCavWyK0MxBAPjFyIeOtNz/jNQBujQOV/SL7dQhl9OWQjAq7mEmPLo 6rrd06najHZgFqeQ6WrxKmL2z/AP+/2h4wEkvUH+5Jz9YFQ6nVl6vNqMEafAN9TEaras 08L7NmnKBylTPN/9WPYMqzVNZmwAmqKc6kqTE/OTVEbPlIo6o7KFVjD6kkghtckpdCpe A+q1UB3EZt9x6fzYY4uLqhdHOnQo6yX3yBOtimftA+sLPzSt3X2Gyx+ls8TJl1onZOlM K2Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693575673; x=1694180473; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdsNDQ4V8xxhan38cy25TKR9z7v2iP3L4/Xs3jT4NNQ=; b=MtskGnJBTCagkU98mQt1SjSnbLCSvSByip3fc+jmlWrI0xHEl0U2smmEqq3WGELslj Kosk3sxRrQUme8asAgXLAA2+oUYTd9CNslX4F5RQsYIzLvrZ53tI5LHgDFBhmWO/1oz6 8tbj3y6c/PYKQdURj/lFSAVnl5g7+rwCtEoc2Xz9PGGazL1h2ZKa1oHTmm4pVQC3UNJa LEON+rFuHhgq+qgTjGNBxmOEPN8r9Lm+M5gfoFgMi3lsTw0Z4RBqlPq9AQLDZNr2cKra WkULv5Pn8dACZ625jI74QERePDDZigrYFHl06q6w3FsOsAE7qp4RXDKIh7a+VsZFldXq oZrA== X-Gm-Message-State: AOJu0YwlTzef2QyXich2DUWVGLXhS2naEkeTHDNYyBt9a3o4mkV0yW7N sStjpITUrJkS0Xsi2GHqJrlILw== X-Google-Smtp-Source: AGHT+IFNK+lUYi1oHobCFkfAmDkdsN6o3eRxv0CQvZvt1qdQOLABNnRK8DasG5Lso0owHL23WRRgoQ== X-Received: by 2002:a5d:4b87:0:b0:31c:6591:d40d with SMTP id b7-20020a5d4b87000000b0031c6591d40dmr2053410wrt.29.1693575673344; Fri, 01 Sep 2023 06:41:13 -0700 (PDT) Received: from localhost ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id y3-20020adfe6c3000000b00317909f9985sm5280309wrm.113.2023.09.01.06.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 06:41:12 -0700 (PDT) Date: Fri, 1 Sep 2023 13:41:12 +0000 From: Arnaud Charlet To: Andris Pav??nis Cc: GCC Patches Subject: Re: [PATCH][Ada] Fix syntax errors in expect.c Message-ID: <20230901134112.GA1996962@adacore.com> References: <8f08933c-d988-c806-6a75-c8a12574c268@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f08933c-d988-c806-6a75-c8a12574c268@iki.fi> X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Change is OK, thanks! > Noticed trivial syntax errors in gcc/ada/expect.c when tried to compile gcc > 13.2 as cross-compiler for target i686-pc-msdosdjgpp. > > Errors were there since > > Tiedostossa, joka sisällytettiin kohdasta expect.c:54: > expect.c:Funktio ”__gnat_waitpid”: > expect.c:353:13:virhe: expected ”(” before numeric constant >  353 |   } else if WIFSTOPPED(status) { >      | ^~~~~~~~~~ > expect.c:358:1:varoitus: ei-void-tyyppisen funktion loppu saavutettu [-Wreturn-type] >  358 | } >      | ^ > make[5]: *** [../gcc-interface/Makefile:297: expect.o] Error 1 > > Errors were there since commit 9e6274e0a3b60e77a42784c3fb6ef2aa3cfc071a(Wed > Dec 15 19:26:50 2021 +0600) > > Fixing these errors (attached patch for master branch) was not sufficient > for building Ada cross-compiler, but it fixed compiler errors. > > This would perhaps qualify for trivial change, but it seems that I no more > have write access (I got it in 2015, but have not used it for a long time. > Perhaps I do not really need it) > > Andris > > commit 64c48aa99656e06d5728bf5837da3bbc50ae4cc5 > Author: Andris Pavēnis > Date: Sat Aug 19 10:40:22 2023 +0300 > > Fix syntax error > > gcc/ada/expect.c(__gnat_waitpid): > fix syntax errors