From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com [198.54.118.212]) by sourceware.org (Postfix) with ESMTPS id 6B0AC3858D20 for ; Fri, 1 Sep 2023 19:02:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B0AC3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=effective-light.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=effective-light.com Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 405A918000E2; Fri, 1 Sep 2023 15:02:52 -0400 (EDT) Received: from hal-station.. (bras-base-toroon4332w-grc-39-74-12-11-94.dsl.bell.ca [74.12.11.94]) by mta-05.privateemail.com (Postfix) with ESMTPA; Fri, 1 Sep 2023 15:02:44 -0400 (EDT) From: Hamza Mahfooz To: gcc-patches@gcc.gnu.org Cc: Nick Desaulniers , Nathan Chancellor , Richard Biener , Joseph Myers , Marek Polacek , Martin Uecker , Hamza Mahfooz Subject: [PATCH v2] c: don't emit -Wmissing-variable-declarations for register variables [PR110947] Date: Fri, 1 Sep 2023 15:02:41 -0400 Message-ID: <20230901190241.157034-1-someguy@effective-light.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Resolves: PR c/110947 - Should -Wmissing-variable-declarations not trigger on register variables? gcc/c/ChangeLog: PR c/110947 * c-decl.cc (start_decl): don't emit -Wmissing-variable-declarations for DECL_REGISTER VAR_DECLs. gcc/testsuite/ChangeLog: PR c/110947 * gcc.dg/pr110947.c: New test. Signed-off-by: Hamza Mahfooz --- Please push this for me if you think it looks good. Since, I don't have write access to the repository. v2: put "target" before the relevant architectures in pr110947.c. --- gcc/c/c-decl.cc | 3 ++- gcc/testsuite/gcc.dg/pr110947.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/pr110947.c diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc index 1f9eb44dbaa..819af6aa050 100644 --- a/gcc/c/c-decl.cc +++ b/gcc/c/c-decl.cc @@ -5376,7 +5376,8 @@ start_decl (struct c_declarator *declarator, struct c_declspecs *declspecs, warning (OPT_Wmain, "%q+D is usually a function", decl); if (warn_missing_variable_declarations && VAR_P (decl) - && !DECL_EXTERNAL (decl) && TREE_PUBLIC (decl) && old_decl == NULL_TREE) + && !DECL_EXTERNAL (decl) && !DECL_REGISTER (decl) && TREE_PUBLIC (decl) + && old_decl == NULL_TREE) warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wmissing_variable_declarations, "no previous declaration for %qD", decl); diff --git a/gcc/testsuite/gcc.dg/pr110947.c b/gcc/testsuite/gcc.dg/pr110947.c new file mode 100644 index 00000000000..3c0b8a82ab3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr110947.c @@ -0,0 +1,4 @@ +/* { dg-do compile { target i?86-*-* x86_64-*-* } } */ +/* { dg-options "-Wmissing-variable-declarations" } */ + +register unsigned long current_stack_pointer asm("rsp"); -- 2.41.0