* [PATCH] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm
@ 2023-09-10 3:55 Juzhe-Zhong
2023-09-10 13:34 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Juzhe-Zhong @ 2023-09-10 3:55 UTC (permalink / raw)
To: gcc-patches; +Cc: kito.cheng, kito.cheng, jeffreyalaw, rdapp.gcc, Juzhe-Zhong
If a const vector all elements are same, the slide up is unnecessary.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup.
---
gcc/config/riscv/riscv-v.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
index bee60de1d26..7ef884907b8 100644
--- a/gcc/config/riscv/riscv-v.cc
+++ b/gcc/config/riscv/riscv-v.cc
@@ -2697,7 +2697,7 @@ shuffle_compress_patterns (struct expand_vec_perm_d *d)
rtx mask = force_reg (mask_mode, builder.build ());
rtx merge = d->op1;
- if (need_slideup_p)
+ if (need_slideup_p && !const_vec_duplicate_p (d->op1))
{
int slideup_cnt = vlen - (d->perm[vlen - 1].to_constant () % vlen) - 1;
rtx ops[] = {d->target, d->op1, gen_int_mode (slideup_cnt, Pmode)};
--
2.36.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm
2023-09-10 3:55 [PATCH] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm Juzhe-Zhong
@ 2023-09-10 13:34 ` Jeff Law
2023-09-10 14:31 ` 钟居哲
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2023-09-10 13:34 UTC (permalink / raw)
To: Juzhe-Zhong, gcc-patches; +Cc: kito.cheng, kito.cheng, rdapp.gcc
On 9/9/23 21:55, Juzhe-Zhong wrote:
> If a const vector all elements are same, the slide up is unnecessary.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup.
>
> ---
> gcc/config/riscv/riscv-v.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
> index bee60de1d26..7ef884907b8 100644
> --- a/gcc/config/riscv/riscv-v.cc
> +++ b/gcc/config/riscv/riscv-v.cc
> @@ -2697,7 +2697,7 @@ shuffle_compress_patterns (struct expand_vec_perm_d *d)
> rtx mask = force_reg (mask_mode, builder.build ());
>
> rtx merge = d->op1;
> - if (need_slideup_p)
> + if (need_slideup_p && !const_vec_duplicate_p (d->op1))
> {
> int slideup_cnt = vlen - (d->perm[vlen - 1].to_constant () % vlen) - 1;
> rtx ops[] = {d->target, d->op1, gen_int_mode (slideup_cnt, Pmode)};
Would it be better to adjust how we compute need_slidup_p to check
!const_vec_duplicate_p (d->op1) instead of doing it here?
That way the name "need_slideup_p" stays consistent with the intent of
the code. It would also mean we wouldn't need to duplicate the
additional check if we wanted to model the use of slideup in the cost
calculations.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm
2023-09-10 13:34 ` Jeff Law
@ 2023-09-10 14:31 ` 钟居哲
0 siblings, 0 replies; 3+ messages in thread
From: 钟居哲 @ 2023-09-10 14:31 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: kito.cheng, kito.cheng, rdapp.gcc
[-- Attachment #1: Type: text/plain, Size: 1657 bytes --]
Address comment: [PATCH V2] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm (gnu.org)
juzhe.zhong@rivai.ai
From: Jeff Law
Date: 2023-09-10 21:34
To: Juzhe-Zhong; gcc-patches
CC: kito.cheng; kito.cheng; rdapp.gcc
Subject: Re: [PATCH] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm
On 9/9/23 21:55, Juzhe-Zhong wrote:
> If a const vector all elements are same, the slide up is unnecessary.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-v.cc (shuffle_compress_patterns): Avoid unnecessary slideup.
>
> ---
> gcc/config/riscv/riscv-v.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
> index bee60de1d26..7ef884907b8 100644
> --- a/gcc/config/riscv/riscv-v.cc
> +++ b/gcc/config/riscv/riscv-v.cc
> @@ -2697,7 +2697,7 @@ shuffle_compress_patterns (struct expand_vec_perm_d *d)
> rtx mask = force_reg (mask_mode, builder.build ());
>
> rtx merge = d->op1;
> - if (need_slideup_p)
> + if (need_slideup_p && !const_vec_duplicate_p (d->op1))
> {
> int slideup_cnt = vlen - (d->perm[vlen - 1].to_constant () % vlen) - 1;
> rtx ops[] = {d->target, d->op1, gen_int_mode (slideup_cnt, Pmode)};
Would it be better to adjust how we compute need_slidup_p to check
!const_vec_duplicate_p (d->op1) instead of doing it here?
That way the name "need_slideup_p" stays consistent with the intent of
the code. It would also mean we wouldn't need to duplicate the
additional check if we wanted to model the use of slideup in the cost
calculations.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-10 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-10 3:55 [PATCH] RISC-V: Avoid unnecessary slideup in compress pattern of vec_perm Juzhe-Zhong
2023-09-10 13:34 ` Jeff Law
2023-09-10 14:31 ` 钟居哲
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).