From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id BB1423856DDF for ; Mon, 11 Sep 2023 17:20:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB1423856DDF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qfkaU-0000iV-Ut for gcc-patches@gcc.gnu.org; Mon, 11 Sep 2023 19:20:38 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [PATCH] RISC-V Add Types to Un-Typed Thead Instructions: Date: Mon, 11 Sep 2023 10:20:30 -0700 Message-ID: <487e0b2b-4b4e-4209-b53a-146d0ecb5a59@rivosinc.com> References: <20230831173637.583424-1-ewlu@rivosinc.com> <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: <7fa41b97-dcf3-4a4c-bd86-e2f4de691f5a@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230911172030.BkgHmnv8VvIioQRTGq_Mye3Ia1podKNCrOnZYGsVW6U@z> On 9/10/2023 8:37 AM, Jeff Law via Gcc-patches wrote: > > > On 8/31/23 11:36, Edwin Lu wrote: >> Related Discussion: >> https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ >> >> This patch updates the THEAD instructions to ensure that no insn is left >> without a type attribute. >> >> Tested for regressions using rv32/64 multilib for linux/newlib. >> >> gcc/Changelog: >> >>     * config/riscv/thead.md: Update types > OK.  THe first could arguably be "multi", but both instructions it > generates appear to be move/conversions, so "fmove" is reasonable as well. > > Ok for the trunk.  And I think that's should allow us to turn on the > assertion, right? > > jeff > I just did one final check, there's one insn in autovec-opt.md that was added (line 635) but otherwise I think that should be it. I've typed it "vector" for now and am currently running a test to make sure nothing breaks. Would you like me to send another patch for it? Edwin