* [PATCH] check_GNU_style.py: Skip .md square bracket linting
@ 2023-09-12 18:54 Patrick O'Neill
2023-09-29 19:05 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Patrick O'Neill @ 2023-09-12 18:54 UTC (permalink / raw)
To: gcc-patches; +Cc: mliska, msebor, Patrick O'Neill
This testcase causes lots of false-positives for machine description files.
contrib/ChangeLog:
* check_GNU_style_lib.py: Skip machine description file bracket linting.
Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
---
contrib/check_GNU_style_lib.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/check_GNU_style_lib.py b/contrib/check_GNU_style_lib.py
index 94a742941cf..5096b1333f3 100755
--- a/contrib/check_GNU_style_lib.py
+++ b/contrib/check_GNU_style_lib.py
@@ -182,6 +182,9 @@ class SquareBracketCheck:
self.re = re.compile('\w\s+(\[)')
def check(self, filename, lineno, line):
+ if filename.endswith('.md'):
+ return None
+
m = self.re.search(line)
if m != None:
return CheckError(filename, lineno,
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] check_GNU_style.py: Skip .md square bracket linting
2023-09-12 18:54 [PATCH] check_GNU_style.py: Skip .md square bracket linting Patrick O'Neill
@ 2023-09-29 19:05 ` Jeff Law
2023-09-29 21:14 ` [Committed] " Patrick O'Neill
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2023-09-29 19:05 UTC (permalink / raw)
To: Patrick O'Neill, gcc-patches; +Cc: mliska, msebor
On 9/12/23 12:54, Patrick O'Neill wrote:
> This testcase causes lots of false-positives for machine description files.
>
> contrib/ChangeLog:
>
> * check_GNU_style_lib.py: Skip machine description file bracket linting.
OK. We probably need a completely separate checker for for .md files.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Committed] check_GNU_style.py: Skip .md square bracket linting
2023-09-29 19:05 ` Jeff Law
@ 2023-09-29 21:14 ` Patrick O'Neill
0 siblings, 0 replies; 3+ messages in thread
From: Patrick O'Neill @ 2023-09-29 21:14 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: mliska, msebor
On 9/29/23 12:05, Jeff Law wrote:
>
>
> On 9/12/23 12:54, Patrick O'Neill wrote:
>> This testcase causes lots of false-positives for machine description
>> files.
>>
>> contrib/ChangeLog:
>>
>> * check_GNU_style_lib.py: Skip machine description file bracket
>> linting.
> OK. We probably need a completely separate checker for for .md files.
>
>
> jeff
Committed.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-29 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 18:54 [PATCH] check_GNU_style.py: Skip .md square bracket linting Patrick O'Neill
2023-09-29 19:05 ` Jeff Law
2023-09-29 21:14 ` [Committed] " Patrick O'Neill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).