From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 818F53858412 for ; Thu, 14 Sep 2023 12:46:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 818F53858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-31f8a05aa24so849598f8f.1 for ; Thu, 14 Sep 2023 05:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1694695572; x=1695300372; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GKSn1l0XpbQanWf6VdP5/pdjvTA65apXr2zy87MeNXk=; b=dD5wkhdRud8BSXRlmBxej+/L9S2w7mYVlExBVLC9gkOFgks+EWdBQRfbIdDquahkq3 4x/68vUMUUrwJoCgeQWjbN91VLWITgCaf7b0z/KHk2i2XriDamxH5GOMZuYtetErnpps 4sH/7DQZC93P7TdyhJ0YlKjKEAg63EPDJr4nqpMlDXnRU4mQ13hB1OdCgVSYQE2u8NS/ WzKOy1DTTKVXC5JSptKZvdYD3pqU9GebGY10wO47EB4ZIUS7yzcaLJpv8ENdO9tqS2DY TTxLOXd2SLsUO8yy3UJ6R5yzgVPV6lCBUjHN8a+OWF6KOmMFoqBQWNDh/h1YawNok5gl 1EPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694695572; x=1695300372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GKSn1l0XpbQanWf6VdP5/pdjvTA65apXr2zy87MeNXk=; b=mX2elNJdT9DrCG8tavDiQ+daHyBRB/1N5LaUUSvHr1j9t4s+daj+79b9I/buGAAmOL TyaiH8ccip2yzm2oep60yumMhLN8iq1QVuhyoHjPtzrwdRV1SJC9TB4yzfYcHFSwBUeG vKTlk5uMqDIqZb3JfwN+PQd6n/C1z6oKW8Pin2ox8GvoGwXLebWnWUA77RIF4+GrpNkH ynBATCE1DW2YWYHeuIR0Crl2tkBNP1yeN4AxFZfsSLGd2inBqoII+aVoCQ1v+fZSq5rM WVGIjBIWI0LTimwkeom6tmm9L5/XKHNUt7hEVXbQgZvF6Xkay4vf8qj1sxL52HhZJQ84 mEdg== X-Gm-Message-State: AOJu0Yx2UDNauqAhbGWmfyQw6kGceu8A7pXbMRxctzH6sWv3CieQ0azC ytV4oZgHj50H//qkEv+ZQROGxQeMLdQ5psPdhLr9Zw== X-Google-Smtp-Source: AGHT+IECG2Q5rZEpEt98VY2wlpFQBOhH7jBUNAzgY0uykjWoSU4mQFiIvhVqsPQ0vUrW+RIH8j9KhQ== X-Received: by 2002:adf:fdca:0:b0:31f:9a0d:167f with SMTP id i10-20020adffdca000000b0031f9a0d167fmr4113622wrs.50.1694695572301; Thu, 14 Sep 2023 05:46:12 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id q8-20020a5d5748000000b0031de43fe9bfsm1717550wrw.0.2023.09.14.05.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 05:46:11 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Javier Miranda Subject: [COMMITTED] ada: Assertion failure on for-of loop iterating on selected component Date: Thu, 14 Sep 2023 14:46:11 +0200 Message-Id: <20230914124611.1951068-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Javier Miranda gcc/ada/ * sem_util.adb (Is_Dependent_Component_Of_Mutable_Object): Protect access to Entity attribute and add missing code to check function selector in a prefix form call. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_util.adb | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb index 35ec296ab93..3229f4e9dd2 100644 --- a/gcc/ada/sem_util.adb +++ b/gcc/ada/sem_util.adb @@ -16509,8 +16509,13 @@ package body Sem_Util is -- False (it could be a function selector in a prefix form call -- occurring in an iterator specification). - if Ekind (Entity (Selector_Name (Object))) not in - E_Component | E_Discriminant + if (Present (Entity (Selector_Name (Object))) + and then Ekind (Entity (Selector_Name (Object))) not in + E_Component | E_Discriminant) + or else + (Inside_A_Generic + and then Nkind (Parent (Selector_Name (Object))) + = N_Function_Call) then return False; end if; -- 2.40.0