From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Eric Botcazou <ebotcazou@adacore.com>
Subject: [COMMITTED] ada: Fix internal error on misaligned component with variable nominal size
Date: Fri, 15 Sep 2023 16:20:58 +0200 [thread overview]
Message-ID: <20230915142058.2100998-1-poulhies@adacore.com> (raw)
From: Eric Botcazou <ebotcazou@adacore.com>
The back-end cannot handle this kind of components even when they are small.
gcc/ada/
* exp_util.adb (Component_May_Be_Bit_Aligned): Do not return false
for a small component of a record type with a variant part.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/exp_util.adb | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gcc/ada/exp_util.adb b/gcc/ada/exp_util.adb
index b2542d4ae59..2e6a1cf892e 100644
--- a/gcc/ada/exp_util.adb
+++ b/gcc/ada/exp_util.adb
@@ -4989,12 +4989,15 @@ package body Exp_Util is
return False;
-- If we know that we have a small (at most the maximum integer size)
- -- record or bit-packed array, then everything is fine, since the back
- -- end can handle these cases correctly, except if a slice is involved.
+ -- bit-packed array or record without variant part, then everything is
+ -- fine, since the back end can handle these cases correctly, except if
+ -- a slice is involved.
elsif Known_Esize (Comp)
and then Esize (Comp) <= System_Max_Integer_Size
- and then (Is_Record_Type (UT) or else Is_Bit_Packed_Array (UT))
+ and then (Is_Bit_Packed_Array (UT)
+ or else (Is_Record_Type (UT)
+ and then not Has_Variant_Part (UT)))
and then not For_Slice
then
return False;
--
2.40.0
reply other threads:[~2023-09-15 14:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915142058.2100998-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).