public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gary Dismukes <dismukes@adacore.com>
To: Richard Wai <richard@annexi-strayline.com>
Cc: gcc-patches@gcc.gnu.org, Eric Botcazou <ebotcazou@adacore.com>,
	Arnaud Charlet <charlet@adacore.com>,
	Stephen Baird <baird@adacore.com>,
	Marc Poulhies <poulhies@adacore.com>
Subject: Re: [PATCH 2/2 v2] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions
Date: Fri, 15 Sep 2023 16:38:48 +0000	[thread overview]
Message-ID: <20230915163848.GA1562737@adacore.com> (raw)
In-Reply-To: <20230913213709.GA1074648@adacore.com>

Richard,

As a follow-on to my earlier message, additional testing has uncovered an issue
with your patch.  When run against a compiler built with assertions enabled,
the test of "Present (Corresponding_Record_Type (Parent_Utyp))" can fail.
An additional guard is needed prior to that test, as follows:

            if Ekind (Parent_Utyp) in Concurrent_Kind
              and then Present (Corresponding_Record_Type (Parent_Utyp))
            then
               Parent_Utyp := Corresponding_Record_Type (Parent_Utyp);
            end if;

-- Gary


  reply	other threads:[~2023-09-15 16:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 21:37 Gary Dismukes
2023-09-15 16:38 ` Gary Dismukes [this message]
     [not found]   ` <010d018aa45631b4-d2c02a5f-44ef-4dbe-b8c1-bd53686aff72-000000@ca-central-1.amazonses.com>
2023-09-18 13:43     ` [PATCH 2/2 v3] " Arnaud Charlet
2023-09-19  3:35       ` Richard Wai
2023-09-19 12:08         ` [COMMITTED] ada: TSS finalize address subprogram generation for constrained Marc Poulhiès
  -- strict thread matches above, loose matches on Subject: below --
2023-08-10  4:55 [PATCH 1/2] Ada: Synchronized private extensions are always limited Richard Wai
2023-08-23 14:24 ` [PATCH 2/2 v2] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions Richard Wai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915163848.GA1562737@adacore.com \
    --to=dismukes@adacore.com \
    --cc=baird@adacore.com \
    --cc=charlet@adacore.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=poulhies@adacore.com \
    --cc=richard@annexi-strayline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).