From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 41D7D3858C52 for ; Fri, 15 Sep 2023 16:38:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41D7D3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-404c023ef5eso3749165e9.2 for ; Fri, 15 Sep 2023 09:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1694795930; x=1695400730; darn=gcc.gnu.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=b9Vrb3YPesDu6HkMDoIpByiAVf2akp76rVc3liBSUd4=; b=UgUrpR0ghKL4ESw0hIT2trqUvLswbRR1RHW7n9afKPjSYa0ZpaZBMUdpdyJRsRGu/W 7sVWLvqGfpIqLeg6ganYxvgfXq+kJBGyNBsNGS7nk1a6mkAiiguUzuUJ2gdTIxa0RIKX l8m4BfodX+xZsaJy3L7JeSQ08HvYiS9akk8jT7hmecRM69LA/ISr//3m3WfLcsyzw31R KJdlQ9K0Hnr/5+uc9uTh/djfjVfIACPcKf7KXDA0CqQ9zgJQ19nvaBGR+7FIqFTAJrVs Z08Qf8ZkYv8zwddBTA8hwbku2Pz2p8eTKeC9a4rehYrZYSIz1FegrkRZ8GqYaJBGIuLr dmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694795930; x=1695400730; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b9Vrb3YPesDu6HkMDoIpByiAVf2akp76rVc3liBSUd4=; b=oGKMDwAUfsiwZ4LeC+OmN3I/Syuoi7qHr7tiklnpoMoKwwwjNqEKc0PTYeiBGNLbhT kFPj8rcT5cbnVmLy1Js7Zv+3NXUICaCjFxq6lhnYWIp0M93adTK3Y0P1UCWqw17KY2Ie 8I/5Vqy6v2fWrv4N42PRK9NdfhfaPTY4H2FxiQ6fq/9zn1e7qag0VgdGEH311KPS8h+u dpKgsnSpl0iTecBNPu3pyIs14i2mqg2hpmUlbyn0ODcZQpLhx9n34ak7i7S3+7PK76UJ vgk4CkvET+BEwjlZ/DrhSDbtxGF1mP8Aia34aWh4CVk4oWolTYDEqXF4eVffcHnSStJW mXNw== X-Gm-Message-State: AOJu0Yz6Eg5NGdaNLKJFSS4hC2Y0hyfxa5ezDevJlRjwpzqcV2DzxmTM crRPuxikHkD25sNWIwD5WAif/A== X-Google-Smtp-Source: AGHT+IFTWRdV154ykhj4roz3tddn9yeeNRD262n0kA+OugI4ggcK5muEzGvmRvhDtAASvlaond2fGA== X-Received: by 2002:a7b:cd17:0:b0:3fe:1871:1826 with SMTP id f23-20020a7bcd17000000b003fe18711826mr1973002wmj.27.1694795929914; Fri, 15 Sep 2023 09:38:49 -0700 (PDT) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id f24-20020a1c6a18000000b003fbb25da65bsm5097849wmc.30.2023.09.15.09.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 09:38:49 -0700 (PDT) Date: Fri, 15 Sep 2023 16:38:48 +0000 From: Gary Dismukes To: Richard Wai Cc: gcc-patches@gcc.gnu.org, Eric Botcazou , Arnaud Charlet , Stephen Baird , Marc Poulhies Subject: Re: [PATCH 2/2 v2] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions Message-ID: <20230915163848.GA1562737@adacore.com> Reply-To: dismukes@adacore.com References: <20230913213709.GA1074648@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913213709.GA1074648@adacore.com> X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard, As a follow-on to my earlier message, additional testing has uncovered an issue with your patch. When run against a compiler built with assertions enabled, the test of "Present (Corresponding_Record_Type (Parent_Utyp))" can fail. An additional guard is needed prior to that test, as follows: if Ekind (Parent_Utyp) in Concurrent_Kind and then Present (Corresponding_Record_Type (Parent_Utyp)) then Parent_Utyp := Corresponding_Record_Type (Parent_Utyp); end if; -- Gary