From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 386EA3858D32 for ; Sun, 17 Sep 2023 19:13:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 386EA3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694977999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zEYXPmEpH2T3sC+ZXw8Tv0MX8PWBGXUC76SMSpqgUgc=; b=d4xt1HuELjHfAq4VSLa8oPN57YrqmodVWCIe79nFYC3ERPTYkziEz6dDVpnnBR3NlElwQH CPnwpjNueHjqHq3koG1buF1zKeWcHgSr9OOTqe2wu/UctkhU4zqxuHupjjl9/OARHho0LD PJ9lpK/LbJtp9tl9QZYPFylfxV1P6Uc= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-kEJramC8PficLwXoPmw_dA-1; Sun, 17 Sep 2023 15:13:17 -0400 X-MC-Unique: kEJramC8PficLwXoPmw_dA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-773b05dfd4eso355457585a.2 for ; Sun, 17 Sep 2023 12:13:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694977996; x=1695582796; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zEYXPmEpH2T3sC+ZXw8Tv0MX8PWBGXUC76SMSpqgUgc=; b=iftGS8U6Bi9vl3IevugguBMSdY/VUlheu52ByLPNCfLUwN8v1GGdkiL1aZc4uOAYvb 0WGBBtI8H6f3kNse1Fcg9w3QC+EDTU3lVna490H/GAeHQiGCoC+Y+pRb3e+6nS5zshek zig/xsu/IyuXCH/rETx6+xtCxqhU9d3h1Gl4vjNxrQP+/l1snqugZl/CfPgYqtSZ8RFd aE+YDA7t4tFrsiCYTlntxTcY7eU5YRDvpbAKJRMUPx4to7+tS/+l4nS/lY+HANfp94FT 5QcVANNI3inXW8tDxdGBqMmwlAEz0w+4PF7l5/28zTVZAyHC5H2yvV21WIGObxNfDBTS lgBg== X-Gm-Message-State: AOJu0YznH6Al6FXnKsnt6LF1G5v/s5uDRLQC9mKu4EuJYheSC7uiOy0o yHA2EaIOrbW8qhfq6P4kI+HqSSsIG/euSWrzjhDqR0eVu6gGl6Nu32H20k9uQwOIxQ5uD65q2jp 0q7yG8qtDbq2PldpT5maDsQU7UA3BtMr+nspX95KmrYISUZCDQ+H9q9zOdVCd78VROgfnQ2P824 E= X-Received: by 2002:a05:620a:1908:b0:767:797b:4115 with SMTP id bj8-20020a05620a190800b00767797b4115mr7820900qkb.60.1694977996449; Sun, 17 Sep 2023 12:13:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEh+7nqkM7WMCku3wBjBL06Eau0Vw1zuI26iQ19jexM+5giYRl2rZNS9P6KAFWo3XD9popehQ== X-Received: by 2002:a05:620a:1908:b0:767:797b:4115 with SMTP id bj8-20020a05620a190800b00767797b4115mr7820885qkb.60.1694977996119; Sun, 17 Sep 2023 12:13:16 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id 27-20020a05620a079b00b00767b24f68edsm2658092qka.62.2023.09.17.12.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Sep 2023 12:13:15 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, Patrick Palka Subject: [PATCH] c++: optimize tsubst_template_decl for function templates Date: Sun, 17 Sep 2023 15:13:04 -0400 Message-ID: <20230917191304.1483576-1-ppalka@redhat.com> X-Mailer: git-send-email 2.42.0.216.gbda494f404 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- r14-2655-g92d1425ca78040 made instantiate_template avoid redundantly performing a specialization lookup when instantiating a function or alias template. This patch applies the same optimization to tsubst_template_decl when (partially) instantiating a function template, which allows us to remove a check from register_specialization since tsubst_function_decl no longer calls register_specialization for a function template partial instantiation. gcc/cp/ChangeLog: * pt.cc (register_specialization): Remove now-unnecessary early exit for FUNCTION_DECL partial instantiation. (tsubst_template_decl): Pass use_spec_table=false to tsubst_function_decl. Set DECL_TI_ARGS of a non-lambda FUNCTION_DECL specialization to the full set of arguments. Simplify register_specialization call accordingly. gcc/testsuite/ChangeLog: * g++.dg/template/nontype12.C: Expect two instead of three duplicate diagnostics for A::bar() specialization. --- gcc/cp/pt.cc | 29 +++++++---------------- gcc/testsuite/g++.dg/template/nontype12.C | 1 - 2 files changed, 9 insertions(+), 21 deletions(-) diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc index c311a6b88f5..a0296a1ea16 100644 --- a/gcc/cp/pt.cc +++ b/gcc/cp/pt.cc @@ -1507,21 +1507,6 @@ register_specialization (tree spec, tree tmpl, tree args, bool is_friend, || (TREE_CODE (tmpl) == FIELD_DECL && TREE_CODE (spec) == NONTYPE_ARGUMENT_PACK)); - if (TREE_CODE (spec) == FUNCTION_DECL - && uses_template_parms (DECL_TI_ARGS (spec))) - /* This is the FUNCTION_DECL for a partial instantiation. Don't - register it; we want the corresponding TEMPLATE_DECL instead. - We use `uses_template_parms (DECL_TI_ARGS (spec))' rather than - the more obvious `uses_template_parms (spec)' to avoid problems - with default function arguments. In particular, given - something like this: - - template void f(T t1, T t = T()) - - the default argument expression is not substituted for in an - instantiation unless and until it is actually needed. */ - return spec; - spec_entry elt; elt.tmpl = tmpl; elt.args = args; @@ -14663,7 +14648,7 @@ tsubst_template_decl (tree t, tree args, tsubst_flags_t complain, tree in_decl = t; tree spec; tree tmpl_args; - tree full_args; + tree full_args = NULL_TREE; tree r; hashval_t hash = 0; @@ -14754,7 +14739,8 @@ tsubst_template_decl (tree t, tree args, tsubst_flags_t complain, tree inner = decl; ++processing_template_decl; if (TREE_CODE (inner) == FUNCTION_DECL) - inner = tsubst_function_decl (inner, args, complain, lambda_fntype); + inner = tsubst_function_decl (inner, args, complain, lambda_fntype, + /*use_spec_table=*/false); else { if (TREE_CODE (inner) == TYPE_DECL && !TYPE_DECL_ALIAS_P (inner)) @@ -14792,6 +14778,11 @@ tsubst_template_decl (tree t, tree args, tsubst_flags_t complain, } else { + if (TREE_CODE (inner) == FUNCTION_DECL) + /* Set DECL_TI_ARGS to the full set of template arguments, which + tsubst_function_decl didn't do due to use_spec_table=false. */ + DECL_TI_ARGS (inner) = full_args; + DECL_TI_TEMPLATE (inner) = r; DECL_TI_ARGS (r) = DECL_TI_ARGS (inner); } @@ -14822,9 +14813,7 @@ tsubst_template_decl (tree t, tree args, tsubst_flags_t complain, if (TREE_CODE (decl) == FUNCTION_DECL && !lambda_fntype) /* Record this non-type partial instantiation. */ - register_specialization (r, t, - DECL_TI_ARGS (DECL_TEMPLATE_RESULT (r)), - false, hash); + register_specialization (r, t, full_args, false, hash); return r; } diff --git a/gcc/testsuite/g++.dg/template/nontype12.C b/gcc/testsuite/g++.dg/template/nontype12.C index 9a9c3ac1e66..e36a9f16f94 100644 --- a/gcc/testsuite/g++.dg/template/nontype12.C +++ b/gcc/testsuite/g++.dg/template/nontype12.C @@ -5,7 +5,6 @@ template struct A { template int foo(); // { dg-error "double" "" { target c++17_down } } template class> int bar(); // { dg-bogus {double[^\n]*\n[^\n]*C:7:[^\n]*double} "" { xfail c++17_down } } - // { dg-error "double" "" { target c++17_down } .-1 } template struct X; // { dg-error "double" "" { target c++17_down } } }; -- 2.42.0.216.gbda494f404