From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [IPv6:2a03:4000:10:469::]) by sourceware.org (Postfix) with ESMTPS id 0E2313858D37 for ; Mon, 2 Oct 2023 07:47:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E2313858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id B74A642120; Mon, 2 Oct 2023 09:47:57 +0200 (CEST) Date: Mon, 2 Oct 2023 09:47:57 +0200 From: Jan-Benedict Glaw To: gcc-patches@gcc.gnu.org, jakub@redhat.com, richard.sandiford@arm.com Subject: Re: [PATCH] Remove poly_int_pod Message-ID: <20231002074757.GK31556@lug-owl.de> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y0SACtZlsHo4Vp7j" Content-Disposition: inline In-Reply-To: X-Operating-System: Linux chamaeleon 6.4.0-0.deb12.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --y0SACtZlsHo4Vp7j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Richard, On Thu, 2023-09-28 10:55:46 +0100, Richard Sandiford wrote: > poly_int was written before the switch to C++11 and so couldn't > use explicit default constructors. This led to an awkward split > between poly_int_pod and poly_int. poly_int simply inherited from > poly_int_pod and added constructors, with the argumentless constructor > having an empty body. But inheritance meant that poly_int had to > repeat the assignment operators from poly_int_pod (again, no C++11, > so no "using" to inherit base-class implementations). [...] I haven't bisected it, but I guess your patch caused this: [all 2023-10-02 06:59:02] /var/lib/laminar/run/gcc-local/75/local-toolchain= -install/bin/g++ -std=3Dc++11 -fno-PIE -c -g -O2 -DIN_GCC -fno-exce= ptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwri= te-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported= -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-ov= erlength-strings -Werror -fno-common -DHAVE_CONFIG_H -fno-PIE -I. -I. -I..= /../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/.= =2E/libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnum= ber -I../../gcc/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/gcc/.= =2E/libbacktrace -o rtl-tests.o -MT rtl-tests.o -MMD -MP -MF ./.deps/rtl-= tests.TPo ../../gcc/gcc/rtl-tests.cc [all 2023-10-02 06:59:04] In file included from ../../gcc/gcc/coretypes.h:4= 80, [all 2023-10-02 06:59:04] from ../../gcc/gcc/rtl-tests.cc:= 22: [all 2023-10-02 06:59:04] ../../gcc/gcc/poly-int.h: In instantiation of 'co= nstexpr poly_int::poly_int(poly_int_full, const Cs& ...) [with Cs =3D= {int, int}; unsigned int N =3D 1; C =3D long int]': [all 2023-10-02 06:59:04] ../../gcc/gcc/poly-int.h:439:13: required from = here [all 2023-10-02 06:59:04] ../../gcc/gcc/rtl-tests.cc:249:25: in 'constexp= r' expansion of 'poly_int<1, long int>(1, 1)' [all 2023-10-02 06:59:04] ../../gcc/gcc/poly-int.h:453:5: error: too many i= nitializers for 'long int [1]' [all 2023-10-02 06:59:04] 453 | : coeffs { (typename poly_coeff_traits<= C>:: [all 2023-10-02 06:59:04] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~ [all 2023-10-02 06:59:04] 454 | template init_cast::typ= e (cs))... } {} [all 2023-10-02 06:59:04] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~ [all 2023-10-02 06:59:04] make[1]: *** [Makefile:1188: rtl-tests.o] Error 1 [all 2023-10-02 06:59:04] make[1]: Leaving directory '/var/lib/laminar/run/= gcc-local/75/toolchain-build/gcc' [all 2023-10-02 06:59:05] make: *** [Makefile:4993: all-gcc] Error 2 (Full build log at http://toolchain.lug-owl.de/laminar/jobs/gcc-local/75 . That's in a Docker container on amd64-linux with the host gcc being at fairly new at basepoints/gcc-14-3827-g30e6ee07458) MfG, JBG --=20 --y0SACtZlsHo4Vp7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZRp1qgAKCRAdvV51g5nh u4MuAJ49yHROOj93iwUek5aTN9YkDmRv/ACgkwBtP5nVDaCNvXk80B54ing0thM= =2E6n -----END PGP SIGNATURE----- --y0SACtZlsHo4Vp7j--