From: Patrick O'Neill <patrick@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: jeffreyalaw@gmail.com, palmer@rivosinc.com, kito.cheng@gmail.com,
gnu-toolchain@rivosinc.com, Jeff Law <jlaw@ventanamicro.com>,
Patrick O'Neill <patrick@rivosinc.com>
Subject: [RFC gcc13 backport 3/3] [RISCV][committed] Remove spurious newline in ztso sequence
Date: Tue, 3 Oct 2023 15:27:00 -0700 [thread overview]
Message-ID: <20231003222700.909771-4-patrick@rivosinc.com> (raw)
In-Reply-To: <20231003222700.909771-1-patrick@rivosinc.com>
From: Jeff Law <jlaw@ventanamicro.com>
amo-table-ztso-load-3 the coordination branch after merging up the Ztso changes
due to a spurious newline in the output causing scan-function-body to fail.
There's probably an over-zealous .* or similar regexp in the framework. I
didn't see it in a quick scan, but could have easily missed it.
Regardless, fixing the extraneous newline is easy :-)
gcc/
* config/riscv/sync-ztso.md (atomic_load_ztso<mode>): Avoid extraenous
newline.
Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
---
gcc/config/riscv/sync-ztso.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/sync-ztso.md b/gcc/config/riscv/sync-ztso.md
index 91c2a48c069..ed94471b96b 100644
--- a/gcc/config/riscv/sync-ztso.md
+++ b/gcc/config/riscv/sync-ztso.md
@@ -52,7 +52,7 @@
if (model == MEMMODEL_SEQ_CST)
return "fence\trw,rw\;"
- "l<amo>\t%0,%1\;";
+ "l<amo>\t%0,%1";
else
return "l<amo>\t%0,%1";
}
@@ -77,4 +77,4 @@
return "s<amo>\t%z1,%0";
}
[(set_attr "type" "atomic")
- (set (attr "length") (const_int 8))])
\ No newline at end of file
+ (set (attr "length") (const_int 8))])
--
2.34.1
next prev parent reply other threads:[~2023-10-03 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 22:26 [RFC gcc13 backport 0/3] Add Ztso atomic mappings Patrick O'Neill
2023-10-03 22:26 ` [RFC gcc13 backport 1/3] RISC-V: " Patrick O'Neill
2023-10-03 22:26 ` [RFC gcc13 backport 2/3] RISC-V: Specify -mabi for ztso testcases Patrick O'Neill
2023-10-03 22:27 ` Patrick O'Neill [this message]
2023-10-04 15:53 ` [RFC gcc13 backport 0/3] Add Ztso atomic mappings Jeff Law
2023-10-10 14:49 ` Patrick O'Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003222700.909771-4-patrick@rivosinc.com \
--to=patrick@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
--cc=jlaw@ventanamicro.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).