From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id D1D663858C2D for ; Tue, 10 Oct 2023 10:38:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1D663858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E355321833 for ; Tue, 10 Oct 2023 10:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696934300; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=FuH3wkdTJTiEWJU8xt8MWvR3JJzPfkLVUlnEeh9PPhY=; b=Hp/3/BqLQRHg5uRHNcSr7PWQa1HjJKvraJquWBpAoqBsIIKv3Yd28LY3Hjq47f/nz7hUjn DOGR3miN4DfVPLonpV7/xf4103lbySdxwwl7wFB04bdtMrWvPGtltIfmfeWaCBwkov2VxH ihoskJfjMtWhoZ/0LrlRPC4B5ECFJ84= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696934300; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=FuH3wkdTJTiEWJU8xt8MWvR3JJzPfkLVUlnEeh9PPhY=; b=CyxxNre+meNHjiRZ+A+q2VdD4otOfQrNz5uNjSv8ss7YhamMsIeOLF4w9gFVbPWcuUTL7P lFSjkPfWYBIHs/DA== Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B615A2C400 for ; Tue, 10 Oct 2023 10:38:20 +0000 (UTC) Date: Tue, 10 Oct 2023 10:38:20 +0000 (UTC) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix missed CSE with a BLKmode entity User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,MISSING_MID,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231010103820.U0f_Ev3a0kRmndZD_74JhaPs8v4fL8BbUR-KGfRdwQQ@z> The following fixes fallout of r10-7145-g1dc00a8ec9aeba which made us cautionous about CSEing a load to an object that has padding bits. The added check also triggers for BLKmode entities like STRING_CSTs but by definition a BLKmode entity does not have padding bits. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/111751 * tree-ssa-sccvn.cc (visit_reference_op_load): Exempt BLKmode result from the padding bits check. --- gcc/tree-ssa-sccvn.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc index d2aab38c2d2..ce8ae8c6753 100644 --- a/gcc/tree-ssa-sccvn.cc +++ b/gcc/tree-ssa-sccvn.cc @@ -5747,8 +5747,9 @@ visit_reference_op_load (tree lhs, tree op, gimple *stmt) { /* Avoid the type punning in case the result mode has padding where the op we lookup has not. */ - if (maybe_lt (GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (result))), - GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (op))))) + if (TYPE_MODE (TREE_TYPE (result)) != BLKmode + && maybe_lt (GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (result))), + GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (op))))) result = NULL_TREE; else { -- 2.35.3