From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 70DBE3858D37 for ; Sun, 22 Oct 2023 22:22:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70DBE3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70DBE3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698013356; cv=none; b=BMf/twspBfjStzlBPW0MUoJWKTpwOoMYKHEhsUtco6SpYC6U9sL6DEs6wR2pu1u99y8vojJeWksjSFt+LbibBjsgjtTfMZmkYzPz2z2/45Xtba1d7IFPZrYrN8DRSAKijerPgR6/YCzZKviTFinlg4zx0ouoJ6vWLCIg5hTGCb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698013356; c=relaxed/simple; bh=398s4XfBmpE7Lt88bYm7+7daXGxEEXjIgmp9SC0lI9Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=NpxoqT0YfHUPu8pAAFyA3jiXnKvQARhpZoAeZOjLUr6W8kOJ4oZzelzNRFdS04XOXJOUQ1zycgT00WVqjLV+RRPi9HgYWeVIOMrb4pabN+FlFBpGKrCWC5tnKjKP9ilQ8zN2sKJeIUdNW3ACmIhO0qXEqaVPLcq+2Zmh0PI9LZ8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-584a761b301so1971439a12.3 for ; Sun, 22 Oct 2023 15:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698013353; x=1698618153; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=j4OvadKifeimmnP65K+i9NmdPiKJvO4ZwIMZf5IqQe4=; b=BYGyqHW4nBIDbQJkIo4q6UVVUyKJ2C557EY8Z67TWzu/8IWdvJ0tYjQgjO800ggl2S LF1C3mojVKp23BZ+Mf9DPmq1NI6/O2fT2mN+SxswFiVkiueWLh6ke0lEQjusYgiG0diJ xrPOANtpmIMiX6SUM2hspZ/GROXW8PvwTzU5ScaIYIBvdoh3zSvQ1dd9c5+y1qhkA90/ /f/JrERicdl4ktwKgyxeOuNPdOCfD1j7IKE+yg3vETqaOJrdkpItEXT+zcSbj3axyOR4 hubfYcb5Ys249xp87Vgkbtai84j+HE9fbxRJZjhhicDJpVv+XTlBpIv7fuLlEGkUZLoL dKDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698013353; x=1698618153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j4OvadKifeimmnP65K+i9NmdPiKJvO4ZwIMZf5IqQe4=; b=cuZIOv0VBIYJralAyruhmzQpKaqEfn7VAfp7cLkJ1jWo96io+Ewqvknw/HPsrBIx3h aidktZCSHoonysR9AsI1YaLl6s7D7eVCIpWe58E7L8vRAV+71nIUmrwoMNTKnq8wpDcg jVLYZqTnUHxQEwzFJrgYWb18heoQDw5JYA4Jlr5uKjHsKBJpyNBB1txOcggwPwXTTLsn JMr7y0llENvr1rbCxRDxGAsRdMGaHmA4vCCyO0FXkBMIxEzfKSzW4S6Ft1ya5Q12CCqe zgk0DTytAtaxBajgb2zCNvk3cf+NLZ6yFgLATqYl+tTKV7Xn1juyk8KifCbYyF1ZoVbe q4wg== X-Gm-Message-State: AOJu0YydaUX2TGoJPpnj6lQ5gsggN86E1FicZZl3BNn19FEZIKbUu3cl kOcJXk5/wJjkc5QSnQl4zPst5xyJ6G4brQ== X-Google-Smtp-Source: AGHT+IGwfi7KET1CsXwocZJkX0nbl+5PM/7s8qjWdS4lxRFmLY7HF9uHj0pl4SRfybYKje1HRGC9TA== X-Received: by 2002:a05:6a20:4428:b0:15c:b7ba:6a4d with SMTP id ce40-20020a056a20442800b0015cb7ba6a4dmr10953929pzb.50.1698013353073; Sun, 22 Oct 2023 15:22:33 -0700 (PDT) Received: from xeond2.wrightpinski.org ([98.97.114.173]) by smtp.gmail.com with ESMTPSA id c4-20020a056a00008400b006be22fde07dsm4948589pfj.106.2023.10.22.15.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 15:22:32 -0700 (PDT) From: Andrew Pinski To: gcc-patches@gcc.gnu.org Cc: Andrew Pinski Subject: [PATCH] Use error_mark_node after error in convert Date: Sun, 22 Oct 2023 15:22:30 -0700 Message-Id: <20231022222230.1633485-1-pinskia@gmail.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While working on PR c/111903, I Noticed that convert will convert integer_zero_node to that type after an error instead of returning error_mark_node. >From what I can tell this was the old way of not having error recovery since other places in this file does return error_mark_node and the places I am replacing date from when the file was imported into the repro (either via a gcc2 merge or earlier). I also had to update the objc front-end to allow for the error_mark_node change, I suspect you could hit the ICE without this change though. Bootstrapped and tested on x86_64-linux-gnu with no regressions. gcc/ChangeLog: * convert.cc (convert_to_pointer_1): Return error_mark_node after an error. (convert_to_real_1): Likewise. (convert_to_integer_1): Likewise. (convert_to_complex_1): Likewise. gcc/objc/ChangeLog: * objc-gnu-runtime-abi-01.cc (build_objc_method_call): Allow for error_operand after call to build_c_cast. * objc-next-runtime-abi-01.cc (build_objc_method_call): Likewise. * objc-next-runtime-abi-02.cc (build_v2_build_objc_method_call): Likewise. --- gcc/convert.cc | 12 ++++++------ gcc/objc/objc-gnu-runtime-abi-01.cc | 3 +++ gcc/objc/objc-next-runtime-abi-01.cc | 3 +++ gcc/objc/objc-next-runtime-abi-02.cc | 3 +++ 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/gcc/convert.cc b/gcc/convert.cc index 5357609d8f0..ac6af7026a7 100644 --- a/gcc/convert.cc +++ b/gcc/convert.cc @@ -96,7 +96,7 @@ convert_to_pointer_1 (tree type, tree expr, bool fold_p) default: error ("cannot convert to a pointer type"); - return convert_to_pointer_1 (type, integer_zero_node, fold_p); + return error_mark_node; } } @@ -332,11 +332,11 @@ convert_to_real_1 (tree type, tree expr, bool fold_p) case POINTER_TYPE: case REFERENCE_TYPE: error ("pointer value used where a floating-point was expected"); - return convert_to_real_1 (type, integer_zero_node, fold_p); + return error_mark_node; default: error ("aggregate value used where a floating-point was expected"); - return convert_to_real_1 (type, integer_zero_node, fold_p); + return error_mark_node; } } @@ -959,7 +959,7 @@ convert_to_integer_1 (tree type, tree expr, bool dofold) default: error ("aggregate value used where an integer was expected"); - return convert (type, integer_zero_node); + return error_mark_node; } } @@ -1053,11 +1053,11 @@ convert_to_complex_1 (tree type, tree expr, bool fold_p) case POINTER_TYPE: case REFERENCE_TYPE: error ("pointer value used where a complex was expected"); - return convert_to_complex_1 (type, integer_zero_node, fold_p); + return error_mark_node; default: error ("aggregate value used where a complex was expected"); - return convert_to_complex_1 (type, integer_zero_node, fold_p); + return error_mark_node; } } diff --git a/gcc/objc/objc-gnu-runtime-abi-01.cc b/gcc/objc/objc-gnu-runtime-abi-01.cc index fbf8307297a..6f45283b307 100644 --- a/gcc/objc/objc-gnu-runtime-abi-01.cc +++ b/gcc/objc/objc-gnu-runtime-abi-01.cc @@ -700,6 +700,9 @@ build_objc_method_call (location_t loc, int super_flag, tree method_prototype, lookup_object = build_c_cast (loc, rcv_p, lookup_object); + if (error_operand_p (lookup_object)) + return error_mark_node; + /* Use SAVE_EXPR to avoid evaluating the receiver twice. */ lookup_object = save_expr (lookup_object); diff --git a/gcc/objc/objc-next-runtime-abi-01.cc b/gcc/objc/objc-next-runtime-abi-01.cc index 70ab5262e17..9e28976043e 100644 --- a/gcc/objc/objc-next-runtime-abi-01.cc +++ b/gcc/objc/objc-next-runtime-abi-01.cc @@ -846,6 +846,9 @@ build_objc_method_call (location_t loc, int super_flag, tree method_prototype, lookup_object = build_c_cast (loc, rcv_p, lookup_object); + if (error_operand_p (lookup_object)) + return error_mark_node; + /* Use SAVE_EXPR to avoid evaluating the receiver twice. */ lookup_object = save_expr (lookup_object); diff --git a/gcc/objc/objc-next-runtime-abi-02.cc b/gcc/objc/objc-next-runtime-abi-02.cc index 6548c0078e0..723b47c9cf6 100644 --- a/gcc/objc/objc-next-runtime-abi-02.cc +++ b/gcc/objc/objc-next-runtime-abi-02.cc @@ -1729,6 +1729,9 @@ build_v2_build_objc_method_call (int super, tree method_prototype, lookup_object = build_c_cast (loc, rcv_p, lookup_object); + if (error_operand_p (lookup_object)) + return error_mark_node; + /* Use SAVE_EXPR to avoid evaluating the receiver twice. */ lookup_object = save_expr (lookup_object); -- 2.39.3