From: Patrick Palka <ppalka@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: jason@redhat.com, Patrick Palka <ppalka@redhat.com>
Subject: [PATCH v2 3/3] c++: note other candidates when diagnosing deletedness
Date: Mon, 23 Oct 2023 19:51:54 -0400 [thread overview]
Message-ID: <20231023235154.2971561-3-ppalka@redhat.com> (raw)
In-Reply-To: <20231023235154.2971561-1-ppalka@redhat.com>
With the previous two patches in place, we can now extend our
deletedness diagnostic to note the other considered candidates, e.g.:
deleted16.C: In function 'int main()':
deleted16.C:10:4: error: use of deleted function 'void f(int)'
10 | f(0);
| ~^~~
deleted16.C:5:6: note: declared here
5 | void f(int) = delete;
| ^
deleted16.C:5:6: note: candidate: 'void f(int)' (deleted)
deleted16.C:6:6: note: candidate: 'void f(...)'
6 | void f(...);
| ^
deleted16.C:7:6: note: candidate: 'void f(int, int)'
7 | void f(int, int);
| ^
deleted16.C:7:6: note: candidate expects 2 arguments, 1 provided
For now, these these notes are disabled when a deleted special member
function is selected because it introduces a lot of new "cannot bind
reference" errors in the testsuite when noting non-viable candidates,
e.g. in cpp0x/initlist-opt1.C we would need to expect an error when
noting unviability of A(A&&). (It'd be nice if we could downgrade such
errors into notes when noting candidates...)
gcc/cp/ChangeLog:
* call.cc (build_over_call): Call print_z_candidates when
diagnosing deletedness.
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/deleted16.C: New test.
---
gcc/cp/call.cc | 10 +++++++++-
gcc/testsuite/g++.dg/cpp0x/deleted16.C | 24 ++++++++++++++++++++++++
2 files changed, 33 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/g++.dg/cpp0x/deleted16.C
diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc
index 3212d5268e0..1313d6516bd 100644
--- a/gcc/cp/call.cc
+++ b/gcc/cp/call.cc
@@ -9932,7 +9932,15 @@ build_over_call (struct z_candidate *cand, int flags, tsubst_flags_t complain)
if (DECL_DELETED_FN (fn))
{
if (complain & tf_error)
- mark_used (fn);
+ {
+ mark_used (fn);
+ /* Note the other candidates we considered unless we selected a
+ special member function since the mismatch reasons for other
+ candidates are usually uninteresting, e.g. rvalue vs lvalue
+ reference binding . */
+ if (cand->next && !special_memfn_p (fn))
+ print_z_candidates (input_location, cand, /*only_viable_p=*/false);
+ }
return error_mark_node;
}
diff --git a/gcc/testsuite/g++.dg/cpp0x/deleted16.C b/gcc/testsuite/g++.dg/cpp0x/deleted16.C
new file mode 100644
index 00000000000..55acbfd9188
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/deleted16.C
@@ -0,0 +1,24 @@
+// Verify we note other candidates when a deleted function is
+// selected by overload resolution.
+// { dg-do compile { target c++11 } }
+
+void f(int) = delete; // { dg-message "declared here|candidate" }
+void f(...); // { dg-message "candidate" }
+void f(int, int); // { dg-message "candidate" }
+
+// An example where the perfect candidate optimization causes us
+// to ignore function templates.
+void g(int) = delete; // { dg-message "declared here|candidate" }
+template<class T> void g(T); // { dg-message "candidate" }
+
+// An example where we have a strictly viable candidate and
+// an incompletely considered bad candidate.
+template<class T> void h(T, T) = delete; // { dg-message "declared here|candidate" }
+void h(int*, int) = delete; // { dg-message "candidate" }
+
+int main() {
+ f(0); // { dg-error "deleted" }
+ g(0); // { dg-error "deleted" }
+ h(1, 1); // { dg-error "deleted" }
+ // { dg-error "invalid conversion" "" { target *-*-* } .-1 } when noting 2nd cand
+}
--
2.42.0.424.gceadf0f3cf
next prev parent reply other threads:[~2023-10-23 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 23:51 [PATCH v2 1/3] c++: sort candidates according to viability Patrick Palka
2023-10-23 23:51 ` [PATCH v2 2/3] c++: remember candidates that we ignored Patrick Palka
2023-10-24 21:51 ` Jason Merrill
2023-10-23 23:51 ` Patrick Palka [this message]
2023-10-24 21:56 ` [PATCH v2 3/3] c++: note other candidates when diagnosing deletedness Jason Merrill
2023-10-24 21:28 ` [PATCH v2 1/3] c++: sort candidates according to viability Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023235154.2971561-3-ppalka@redhat.com \
--to=ppalka@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).